[Feature Request] Use included screenshot

[Drsheppard01]

I think the best UX is to use the screenshot specified in appdata.metainfo. I even wrote a small parser (I managed to get the right result, but I'm sure it won't always be like this)

cat $METAFILE | grep '<image type="source">' | sed "s/^\ *<[^>]*>//g;s/<\/[^>]*>//g" | cut -d'>' -f2  # For 1 screenshot
cat $METAFILE | grep '<image>' | sed "s/^\ *<[^>]*>//g;s/<\/[^>]*>//g" | cut -d '>' -f1 | head -n1 # For multiple screenshots

Benefits:

• User see app in better resolution
• this will simplify worker.sh

Warning:

Not all include appdata.xml or metainfo.xml in your AppImage

[probonopd]

I think we already show the screenshot specified there, if one exists?

In any case, part of the test is that we can take a screenshot, and I am checking those for any obvious issues (like just a black or white window).

This test must still be passed, even though we then use the AppStream screenshot when putting together the HTML.

[Drsheppard01]

Historically, most applications in Linux have an "Internet addiction" and often instead of a screenshot giving the user an idea of the application's appearance and functions, the user sees a "No Internet connection" window

[probonopd]

Yes. Hence if the AppStream metadata includes a screenshot, we use that one.

But if the application just shows a black or white window, I consider that a failed test.