Skip to content

Sample content constrained to 600px MaxHeight in Normal visual state #301

@Arlodotexe

Description

@Arlodotexe

Describe the bug

The sample hosting framework applies a hardcoded MaxHeight constraint of 600 pixels to sample content in the "Normal" visual state. This causes sample content to be artificially cut off when the options pane is taller than the sample content area.

Steps to reproduce

  1. Open the Sample Gallery application
  2. Navigate to a sample that uses [ToolkitSampleOptionsPane] with a tall options pane (e.g., MarkdownTextBlock Custom Theme Sample)
  3. Observe that the sample content area is constrained to 600px height even when the options pane is significantly taller
  4. The sample content appears cut off at the bottom

Problematic code: ToolkitSampleRenderer.xaml#L26

Expected behavior

MaxHeight should be applied to both the sample content and the sample options pane.

Worth also trying a MinHeight instead to allow it to expand without taking all available height.

Code Platform

  • UWP
  • WinAppSDK / WinUI 3

Device form factor

  • Desktop

Additional context

Found during review of CommunityToolkit/Labs-Windows#761 (review)

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🐛Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions