Cleanup warnings by scanBuild (#444)

* v0

* v1

* v2

* fix buffer

* Revert buffer changes

* Fix

* Fix

* Revert otel_process_ctx.cpp

* Fix uninitialized varible

* scanBuild to include subdirectories

* Changes based on comments

Author: zhengyu123

ddprof-lib/src/main/cpp/arguments.h

@@ -202,6 +202,7 @@ class Arguments {
         _wall(-1),
         _wall_collapsing(false),
         _wall_threads_per_tick(DEFAULT_WALL_THREADS_PER_TICK),
+        _wallclock_sampler(ASGCT),
         _memory(-1),
         _record_allocations(false),
         _record_liveness(false),
@@ -220,10 +221,10 @@ class Arguments {
         _clock(CLK_DEFAULT),
         _jfr_options(0),
         _context_attributes({}),
-        _wallclock_sampler(ASGCT),
         _lightweight(false),
         _enable_method_cleanup(true),
-        _remote_symbolication(false) {}
+        _remote_symbolication(false) { }
+
 
   ~Arguments();
 

ddprof-lib/src/main/cpp/buffers.h

@@ -229,7 +229,7 @@ class RecordingBuffer : public Buffer {
 public:
   RecordingBuffer() : Buffer() {
     new (_data + sizeof(_data)) char[sizeof(_buf)];
-    memset(_buf, 0, _limit); 
+    memset(_buf, 0, _limit);
   }
 
   int limit() const override { return _limit; }

ddprof-lib/src/main/cpp/callTraceHashTable.cpp

@@ -85,7 +85,7 @@ static void init_overflow_trace() {
   CallTraceHashTable::_overflow_trace.frames[0] = {BCI_ERROR, LP64_ONLY(0 COMMA) (jmethodID)"storage_overflow"};
 }
 
-CallTraceHashTable::CallTraceHashTable() : _allocator(CALL_TRACE_CHUNK), _instance_id(0), _parent_storage(nullptr) {
+CallTraceHashTable::CallTraceHashTable() : _instance_id(0), _parent_storage(nullptr), _allocator(CALL_TRACE_CHUNK) {
   // Instance ID will be set externally via setInstanceId()
 
   // Start with initial capacity, allowing expansion as needed

ddprof-lib/src/main/cpp/callTraceStorage.h

@@ -142,12 +142,6 @@ class CallTraceStorage {
     std::unordered_set<CallTrace*> _traces_buffer;           // All traces for JFR processing
     std::unordered_set<u64> _preserve_set_buffer;           // Preserve set for current cycle
 
-    
-private:
-
-    
-
-
 public:
     CallTraceStorage();
     ~CallTraceStorage();

ddprof-lib/src/main/cpp/codeCache.cpp

@@ -284,7 +284,7 @@ void CodeCache::findSymbolsByPrefix(std::vector<const char *> &prefixes,
   for (int i = 0; i < _count; i++) {
     const char *blob_name = _blobs[i]._name;
     if (blob_name != NULL) {
-      for (int i = 0; i < prefixes.size(); i++) {
+      for (size_t i = 0; i < prefixes.size(); i++) {
         if (strncmp(blob_name, prefixes[i], prefix_lengths[i]) == 0) {
           symbols.push_back(_blobs[i]._start);
         }

ddprof-lib/src/main/cpp/context.cpp

@@ -38,6 +38,8 @@ Context& Contexts::initializeContextTls() {
   return ctx;
 }
 
+static Context DD_EMPTY_CONTEXT = {};
+
 Context& Contexts::get() {
   ProfiledThread* thrd = ProfiledThread::currentSignalSafe();
   if (thrd == nullptr || !thrd->isContextTlsInitialized()) {

ddprof-lib/src/main/cpp/context.h

@@ -39,8 +39,6 @@ class alignas(DEFAULT_CACHE_LINE_SIZE) Context {
   Tag get_tag(int i) { return tags[i]; }
 };
 
-static Context DD_EMPTY_CONTEXT = {};
-
 class Contexts {
 
 public:

ddprof-lib/src/main/cpp/dwarf.h

@@ -74,7 +74,7 @@ const int INITIAL_PC_OFFSET = DW_LINK_REGISTER;
 
 struct FrameDesc {
     u32 loc;
-    int cfa;
+    u32 cfa;
     int fp_off;
     int pc_off;
 

ddprof-lib/src/main/cpp/flightRecorder.cpp

@@ -808,7 +808,7 @@ void Recording::writeMetadata(Buffer *buf) {
 
   std::vector<std::string> &strings = JfrMetadata::strings();
   buf->putVar64(strings.size());
-  for (int i = 0; i < strings.size(); i++) {
+  for (size_t i = 0; i < strings.size(); i++) {
     const char *string = strings[i].c_str();
     int length = strlen(string);
     flushIfNeeded(buf, RECORDING_BUFFER_LIMIT - length);
@@ -842,14 +842,14 @@ void Recording::writeElement(Buffer *buf, const Element *e) {
   buf->putVar64(e->_name);
 
   buf->putVar64(e->_attributes.size());
-  for (int i = 0; i < e->_attributes.size(); i++) {
+  for (size_t i = 0; i < e->_attributes.size(); i++) {
     flushIfNeeded(buf);
     buf->putVar64(e->_attributes[i]._key);
     buf->putVar64(e->_attributes[i]._value);
   }
 
   buf->putVar64(e->_children.size());
-  for (int i = 0; i < e->_children.size(); i++) {
+  for (size_t i = 0; i < e->_children.size(); i++) {
     flushIfNeeded(buf);
     writeElement(buf, e->_children[i]);
   }
@@ -1426,7 +1426,7 @@ void Recording::writeCounters(Buffer *buf) {
   long long *counters = Counters::getCounters();
   if (counters) {
     std::vector<const char *> names = Counters::describeCounters();
-    for (int i = 0; i < names.size(); i++) {
+    for (size_t i = 0; i < names.size(); i++) {
       int start = buf->skip(1);
       buf->putVar64(T_DATADOG_COUNTER);
       buf->putVar64(_start_ticks);
@@ -1683,10 +1683,11 @@ void FlightRecorder::stop() {
 }
 
 Error FlightRecorder::dump(const char *filename, const int length) {
+  assert(length >= 0);
   ExclusiveLockGuard locker(&_rec_lock);
   Recording* rec = _rec;
   if (rec != nullptr) {
-    if (_filename.length() != length ||
+    if (_filename.length() != static_cast<size_t>(length) ||
         strncmp(filename, _filename.c_str(), length) != 0) {
       // if the filename to dump the recording to is specified move the current
       // working file there

ddprof-lib/src/main/cpp/hotspot/vmStructs.cpp

@@ -1103,7 +1103,7 @@ HeapUsage HeapUsage::get(bool allow_jmx) {
             usage._maxSize = summary.maxSize();
         }
     }
-    if (usage._maxSize == -1 && _memory_usage_func != NULL && allow_jmx && isJMXSupported()) {
+    if (usage._maxSize == size_t(-1) && _memory_usage_func != NULL && allow_jmx && isJMXSupported()) {
         // this path is for non-hotspot JVMs
         // we need to patch the native method binding for JMX GetMemoryUsage to
         // capture the native method pointer first also, it requires JMX and