Fix VMMethod::validatedId() crash (#453)

zhengyu123 · web-flow · commit fa203ab2a52c · 2026-04-08T09:07:08.000-04:00
diff --git a/ddprof-lib/src/main/cpp/hotspot/vmStructs.cpp b/ddprof-lib/src/main/cpp/hotspot/vmStructs.cpp
@@ -733,7 +733,8 @@ jmethodID VMMethod::id() {
 
 jmethodID VMMethod::validatedId() {
     jmethodID method_id = id();
-    if (!_can_dereference_jmethod_id || (goodPtr(method_id) && *(VMMethod**)method_id == this)) {
+    if (!_can_dereference_jmethod_id || 
+        ((goodPtr(method_id) && SafeAccess::loadPtr((void**)method_id, nullptr) == this))) {
         return method_id;
     }
     return NULL;

Original file line number	Diff line number	Diff line change
`@@ -733,7 +733,8 @@ jmethodID VMMethod::id() {`
`733`	`733`
`734`	`734`	`jmethodID VMMethod::validatedId() {`
`735`	`735`	`jmethodID method_id = id();`
`736`		`- if (!_can_dereference_jmethod_id \|\| (goodPtr(method_id) && (VMMethod*)method_id == this)) {`
	`736`	`+ if (!_can_dereference_jmethod_id \|\|`
	`737`	`+ ((goodPtr(method_id) && SafeAccess::loadPtr((void**)method_id, nullptr) == this))) {`
`737`	`738`	`return method_id;`
`738`	`739`	`}`
`739`	`740`	`return NULL;`