Skip to content

Commit b98cc80

Browse files
authored
Merge pull request #35 from EasyPost/remove_dependency-check-maven
chore: remove dependency-check-maven
2 parents bb60cea + b28e47c commit b98cc80

3 files changed

Lines changed: 1 addition & 45 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -83,26 +83,3 @@ jobs:
8383
fail_on_error: true
8484
checkstyle_config: easypost_java_style.xml
8585
tool_name: "style_enforcer"
86-
security:
87-
runs-on: ubuntu-latest
88-
steps:
89-
- uses: actions/checkout@v4
90-
- name: Set up JDK for compilation
91-
uses: actions/setup-java@v4
92-
with:
93-
distribution: "zulu"
94-
java-version: "23" # Always use the latest JDK for building
95-
- name: Load Maven dependencies and CVE database cache
96-
uses: actions/cache@v3
97-
with:
98-
path: ~/.m2/repository # The CVE database is included in the Maven repository folder
99-
key: ${{ runner.os }}-maven-security-${{ hashFiles('**/pom.xml') }}
100-
restore-keys: |
101-
${{ runner.os }}-maven-
102-
- name: Run security analysis
103-
run: make scan
104-
- name: Upload Test results
105-
uses: actions/upload-artifact@master
106-
with:
107-
name: DependencyCheck report
108-
path: ${{github.workspace}}/target/dependency-check-report.html

Makefile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,8 @@ publish-dry:
4545
release:
4646
gh release create ${tag} target/*.jar target/*.asc target/*.pom
4747

48-
## scan - Scan the project for serious security issues
49-
scan:
50-
mvn verify -DskipTests=true -Dgpg.skip=true -Dcheckstyle.skip=true -Djavadoc.skip=true -Ddependency-check.failBuildOnCVSS=0 -Ddependency-check.junitFailOnCVSS=0
51-
5248
## test - Test the project
5349
test:
5450
mvn surefire:test
5551

56-
.PHONY: help build clean coverage install-checkstyle install lint publish publish-dry release scan test
52+
.PHONY: help build clean coverage install-checkstyle install lint publish publish-dry release test

pom.xml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -258,23 +258,6 @@
258258
</execution>
259259
</executions>
260260
</plugin>
261-
<plugin>
262-
<groupId>org.owasp</groupId>
263-
<artifactId>dependency-check-maven</artifactId>
264-
<version>7.4.4</version>
265-
<configuration>
266-
<failBuildOnCVSS>7</failBuildOnCVSS>
267-
<junitFailOnCVSS>7</junitFailOnCVSS>
268-
</configuration>
269-
<executions>
270-
<execution>
271-
<goals>
272-
<goal>check</goal>
273-
</goals>
274-
</execution>
275-
</executions>
276-
</plugin>
277261
</plugins>
278262
</build>
279-
280263
</project>

0 commit comments

Comments
 (0)