Improve developer terms flow for updated terms and new submissions

- Differentiate between "never onboarded" and "outdated terms" on plugin create page
- Add updated terms banner to customer dashboard and developer dashboard
- Fix onboarding to skip Stripe redirect when only re-accepting terms
- Fix onboarding page to not show "Incomplete" banner for completed accounts
- Fix null stripe_price error in CustomerLicenseController
- Update onboarding FAQ and copy
- Add test for outdated terms version banner

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: simonhamp

app/Http/Controllers/CustomerLicenseController.php

@@ -64,6 +64,8 @@ public function index(): View
         // Total purchases (licenses + plugins)
         $totalPurchases = $licenseCount + $pluginLicenseCount;
 
+        $developerAccount = $user->developerAccount;
+
         return view('customer.dashboard', compact(
             'licenseCount',
             'isEapCustomer',
@@ -73,7 +75,8 @@ public function index(): View
             'renewalLicenseKey',
             'connectedAccountsCount',
             'connectedAccountsDescription',
-            'totalPurchases'
+            'totalPurchases',
+            'developerAccount'
         ));
     }
 

app/Http/Controllers/DeveloperOnboardingController.php

@@ -51,6 +51,12 @@ public function start(Request $request): RedirectResponse
             ]);
         }
 
+        // If Stripe onboarding is already complete, skip the Stripe redirect
+        if ($developerAccount->hasCompletedOnboarding()) {
+            return to_route('customer.plugins.create')
+                ->with('success', 'Terms accepted! You can now submit plugins.');
+        }
+
         try {
             $onboardingUrl = $this->stripeConnectService->createOnboardingLink($developerAccount);
 

resources/views/customer/dashboard.blade.php

@@ -29,6 +29,27 @@
             </div>
         </div>
 
+        {{-- Updated Terms Banner --}}
+        @if ($developerAccount && $developerAccount->hasAcceptedPluginTerms() && !$developerAccount->hasAcceptedCurrentTerms())
+            <div class="mx-auto max-w-7xl px-4 sm:px-6 lg:px-8">
+                <div class="mb-6 rounded-lg border border-amber-200 bg-amber-50 p-4 dark:border-amber-900/50 dark:bg-amber-900/20">
+                    <div class="flex items-center justify-between gap-4">
+                        <div class="flex items-center gap-3">
+                            <svg class="size-5 shrink-0 text-amber-400" viewBox="0 0 20 20" fill="currentColor">
+                                <path fill-rule="evenodd" d="M8.485 2.495c.673-1.167 2.357-1.167 3.03 0l6.28 10.875c.673 1.167-.17 2.625-1.516 2.625H3.72c-1.347 0-2.189-1.458-1.515-2.625L8.485 2.495zM10 5a.75.75 0 01.75.75v3.5a.75.75 0 01-1.5 0v-3.5A.75.75 0 0110 5zm0 9a1 1 0 100-2 1 1 0 000 2z" clip-rule="evenodd" />
+                            </svg>
+                            <p class="text-sm font-medium text-amber-800 dark:text-amber-200">
+                                Our <a href="{{ route('developer-terms') }}" class="underline" target="_blank">Plugin Developer Terms and Conditions</a> have been updated. You must accept the new terms before you can submit new plugins.
+                            </p>
+                        </div>
+                        <a href="{{ route('customer.developer.onboarding') }}" class="shrink-0 rounded-md bg-amber-600 px-3 py-1.5 text-sm font-medium text-white hover:bg-amber-500">
+                            Review &amp; Accept
+                        </a>
+                    </div>
+                </div>
+            </div>
+        @endif
+
         {{-- Dashboard Cards --}}
         <div class="mx-auto max-w-7xl px-4 py-6 sm:px-6 lg:px-8">
             <div class="grid grid-cols-1 gap-6 sm:grid-cols-2 lg:grid-cols-3">

resources/views/customer/developer/dashboard.blade.php

@@ -38,6 +38,27 @@
             @endif
         </div>
 
+        {{-- Updated Terms Banner --}}
+        @if ($developerAccount && $developerAccount->hasAcceptedPluginTerms() && !$developerAccount->hasAcceptedCurrentTerms())
+            <div class="mx-auto max-w-7xl px-4 sm:px-6 lg:px-8">
+                <div class="mb-6 rounded-lg border border-amber-200 bg-amber-50 p-4 dark:border-amber-900/50 dark:bg-amber-900/20">
+                    <div class="flex items-center justify-between gap-4">
+                        <div class="flex items-center gap-3">
+                            <svg class="size-5 shrink-0 text-amber-400" viewBox="0 0 20 20" fill="currentColor">
+                                <path fill-rule="evenodd" d="M8.485 2.495c.673-1.167 2.357-1.167 3.03 0l6.28 10.875c.673 1.167-.17 2.625-1.516 2.625H3.72c-1.347 0-2.189-1.458-1.515-2.625L8.485 2.495zM10 5a.75.75 0 01.75.75v3.5a.75.75 0 01-1.5 0v-3.5A.75.75 0 0110 5zm0 9a1 1 0 100-2 1 1 0 000 2z" clip-rule="evenodd" />
+                            </svg>
+                            <p class="text-sm font-medium text-amber-800 dark:text-amber-200">
+                                Our <a href="{{ route('developer-terms') }}" class="underline" target="_blank">Plugin Developer Terms and Conditions</a> have been updated. You must accept the new terms before you can submit new plugins.
+                            </p>
+                        </div>
+                        <a href="{{ route('customer.developer.onboarding') }}" class="shrink-0 rounded-md bg-amber-600 px-3 py-1.5 text-sm font-medium text-white hover:bg-amber-500">
+                            Review &amp; Accept
+                        </a>
+                    </div>
+                </div>
+            </div>
+        @endif
+
         {{-- Content --}}
         <div class="mx-auto max-w-7xl px-4 py-6 sm:px-6 lg:px-8">
             {{-- Stats Grid --}}

resources/views/customer/developer/onboarding.blade.php

@@ -97,7 +97,7 @@
                     </div>
 
                     {{-- Status for existing account --}}
-                    @if ($hasExistingAccount && $developerAccount)
+                    @if ($hasExistingAccount && $developerAccount && !$developerAccount->hasCompletedOnboarding())
                         <div class="mt-8 rounded-lg border border-yellow-200 bg-yellow-50 p-4 dark:border-yellow-800 dark:bg-yellow-900/20">
                             <div class="flex items-center gap-3">
                                 <svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke-width="1.5" stroke="currentColor" class="size-5 text-yellow-600 dark:text-yellow-400">

resources/views/customer/plugins/create.blade.php

@@ -98,8 +98,8 @@
                         </div>
                     </div>
                 </div>
-            @elseif (!$hasAcceptedTerms)
-                {{-- Developer Onboarding Required --}}
+            @elseif (!$hasCompletedOnboarding)
+                {{-- Developer Onboarding Required (never onboarded) --}}
                 <div class="rounded-lg border border-amber-200 bg-amber-50 p-6 dark:border-amber-900/50 dark:bg-amber-900/20">
                     <div class="flex">
                         <div class="shrink-0">
@@ -127,6 +127,23 @@
                         </div>
                     </div>
                 </div>
+            @elseif (!$hasAcceptedTerms)
+                {{-- Updated terms need acceptance (already onboarded) --}}
+                <div class="rounded-lg border border-amber-200 bg-amber-50 p-4 dark:border-amber-900/50 dark:bg-amber-900/20">
+                    <div class="flex items-center justify-between gap-4">
+                        <div class="flex items-center gap-3">
+                            <svg class="size-5 shrink-0 text-amber-400" viewBox="0 0 20 20" fill="currentColor">
+                                <path fill-rule="evenodd" d="M8.485 2.495c.673-1.167 2.357-1.167 3.03 0l6.28 10.875c.673 1.167-.17 2.625-1.516 2.625H3.72c-1.347 0-2.189-1.458-1.515-2.625L8.485 2.495zM10 5a.75.75 0 01.75.75v3.5a.75.75 0 01-1.5 0v-3.5A.75.75 0 0110 5zm0 9a1 1 0 100-2 1 1 0 000 2z" clip-rule="evenodd" />
+                            </svg>
+                            <p class="text-sm font-medium text-amber-800 dark:text-amber-200">
+                                Our <a href="{{ route('developer-terms') }}" class="underline" target="_blank">Plugin Developer Terms and Conditions</a> have been updated. You must accept the new terms before you can submit new plugins.
+                            </p>
+                        </div>
+                        <a href="{{ route('customer.developer.onboarding') }}" class="shrink-0 rounded-md bg-amber-600 px-3 py-1.5 text-sm font-medium text-white hover:bg-amber-500">
+                            Review &amp; Accept
+                        </a>
+                    </div>
+                </div>
             @else
             <form
                 method="POST"

tests/Feature/DeveloperTermsTest.php

@@ -251,7 +251,26 @@ public function plugin_create_page_does_not_show_warning_when_terms_accepted():
             'github_id' => '12345',
             'github_username' => 'testdev',
         ]);
-        DeveloperAccount::factory()->withAcceptedTerms()->create([
+        DeveloperAccount::factory()->onboarded()->withAcceptedTerms()->create([
+            'user_id' => $user->id,
+        ]);
+
+        $response = $this->actingAs($user)
+            ->get(route('customer.plugins.create'));
+
+        $response->assertStatus(200);
+        $response->assertDontSee('Developer Onboarding Required');
+        $response->assertDontSee('have been updated');
+    }
+
+    /** @test */
+    public function plugin_create_page_shows_updated_terms_banner_for_outdated_version(): void
+    {
+        $user = User::factory()->create([
+            'github_id' => '12345',
+            'github_username' => 'testdev',
+        ]);
+        DeveloperAccount::factory()->onboarded()->withAcceptedTerms('0.9')->create([
             'user_id' => $user->id,
         ]);
 
@@ -260,5 +279,7 @@ public function plugin_create_page_does_not_show_warning_when_terms_accepted():
 
         $response->assertStatus(200);
         $response->assertDontSee('Developer Onboarding Required');
+        $response->assertSee('have been updated');
+        $response->assertSee('Review & Accept', false);
     }
 }