fix: platform add should not return null paths

Author: rigor789

lib/services/platform/add-platform-service.ts

@@ -18,6 +18,7 @@ import { IPackageManager } from "../../declarations";
 export class AddPlatformService implements IAddPlatformService {
 	constructor(
 		private $fs: IFileSystem,
+		private $logger: ILogger,
 		// private $pacoteService: IPacoteService,
 		// private $projectDataService: IProjectDataService,
 		private $packageManager: IPackageManager,
@@ -121,10 +122,10 @@ export class AddPlatformService implements IAddPlatformService {
 		);
 
 		if (!installedPackage.name) {
-			return null;
+			return "";
 		}
 
-		return this.resolveFrameworkDir(projectDir, installedPackage.name);
+		return this.resolveFrameworkDir(projectDir, installedPackage.name) || "";
 	}
 
 	private resolveFrameworkDir(projectDir: string, packageName: string): string {
@@ -137,10 +138,15 @@ export class AddPlatformService implements IAddPlatformService {
 				})
 				.replace("package.json", PROJECT_FRAMEWORK_FOLDER_NAME);
 
-			return path.resolve(frameworkDir);
+			if (frameworkDir) {
+				return path.resolve(frameworkDir);
+			}
 		} catch (err) {
-			return null;
+			this.$logger.trace(
+				`Couldn't resolve installed framework. Continuing with install...`
+			);
 		}
+		return null;
 	}
 
 	@performanceLog()

test/services/platform/add-platform-service.ts

@@ -1,8 +1,4 @@
-import {
-	InjectorStub,
-	TempServiceStub,
-	PackageInstallationManagerStub,
-} from "../../stubs";
+import * as stubs from "../../stubs";
 import { AddPlatformService } from "../../../lib/services/platform/add-platform-service";
 import { assert } from "chai";
 import * as _ from "lodash";
@@ -13,7 +9,7 @@ import { IInjector } from "../../../lib/common/definitions/yok";
 const nativePrepare: INativePrepare = null;
 
 function createTestInjector() {
-	const injector = new InjectorStub();
+	const injector = new stubs.InjectorStub();
 	injector.register("pacoteService", {
 		extractPackage: async (name: string) => ({}),
 	});
@@ -25,12 +21,12 @@ function createTestInjector() {
 			};
 		},
 	});
-	injector.register("packageManager", PackageInstallationManagerStub);
+	injector.register("packageManager", stubs.NodePackageManagerStub);
 	injector.register("addPlatformService", AddPlatformService);
 	injector.register("analyticsService", {
 		trackEventActionInGoogleAnalytics: () => ({}),
 	});
-	injector.register("tempService", TempServiceStub);
+	injector.register("tempService", stubs.TempServiceStub);
 
 	const fs = injector.resolve("fs");
 	fs.exists = () => false;

test/stubs.ts

@@ -443,7 +443,10 @@ export class NodePackageManagerStub implements INodePackageManager {
 		pathToSave: string,
 		config: INodePackageManagerInstallOptions
 	): Promise<INpmInstallResultInfo> {
-		return null;
+		return {
+			name: packageName,
+			version: "latest",
+		};
 	}
 
 	public async uninstall(