Skip to content

Commit 829a66e

Browse files
committed
[spalenque] - #14339 * fix summit about page link in nav
1 parent a986877 commit 829a66e

5 files changed

Lines changed: 39 additions & 44 deletions

File tree

summit/code/pages/StaticSummitAboutPage.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,12 @@ public function init()
1919
Requirements::javascript('summit/javascript/static-summit-about-page.js');
2020

2121
}
22+
23+
public function getSummitAboutPageLink() {
24+
return $this->Link();
25+
}
26+
27+
public function getAboutPageNavClass(){
28+
return 'current';
29+
}
2230
}

summit/code/pages/SummitPage.php

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -252,29 +252,14 @@ function TwitterTrackingCode()
252252
return $tracking_code;
253253
}
254254

255-
public function getSummitRoot(){
256-
if($this->ClassName === 'SummitOverviewPage')
257-
return $this->Link();
258-
else{
259-
//childs page
260-
return $this->Parent()->Link();
261-
}
262-
}
263-
264-
public function getSummitAboutLink() {
265-
if($this->ClassName === 'SummitStaticAboutBostonPage')
266-
return $this->Link();
267-
else{
268-
//childs page
269-
return $this->Parent()->Link();
270-
}
255+
public function getSummitAboutPageLink() {
256+
return $this->Summit()->Link;
271257
}
272258

273-
public function MainNavClass(){
274-
if($this->ClassName === 'SummitOverviewPage' || $this->ClassName === 'SummitNewStaticAboutPage')
259+
public function getAboutPageNavClass(){
260+
if($this->Summit()->Link == $this->Link())
275261
return 'current';
276-
else{
277-
//childs page
262+
else {
278263
return 'link';
279264
}
280265
}

summit/templates/Includes/StaticSummitPageHeader.ss

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,20 @@
1515

1616
<div class="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
1717
<ul class="nav navbar-nav">
18-
<li class="{$MainNavClass} <% if $ClassName == 'SummitAboutPage' %> current<% end_if %> link">
19-
<a href="$SummitAboutLink">About</a>
18+
<li class="{$getAboutPageNavClass}">
19+
<a href="{$getSummitAboutPageLink}">About</a>
2020
</li>
2121
<% loop $Menu(3) %>
22-
<li class="$LinkingMode">
23-
<a href="$Link">$MenuTitle</a>
24-
</li>
25-
<% end_loop %>
22+
<li class="{$LinkingMode}">
23+
<a href="{$Link}">$MenuTitle</a>
24+
</li>
25+
<% end_loop %>
2626

27-
<li class="link button-box">
28-
<a href="https://www.eventbrite.com/e/openstack-summit-november-2018-berlin-tickets-41880169715" class="btn register-btn-lrg">Get your tickets <i class="fa fa-arrow-right"></i>
29-
</a>
30-
</li>
27+
<li class="link button-box">
28+
<a href="https://www.eventbrite.com/e/openstack-summit-november-2018-berlin-tickets-41880169715" class="btn register-btn-lrg">
29+
Get your tickets <i class="fa fa-arrow-right"></i>
30+
</a>
31+
</li>
3132
</ul>
3233
</div>
3334
</div>

summit/templates/Includes/StaticSummitPageHeaderSmall.ss

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,20 @@
1515

1616
<div class="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
1717
<ul class="nav navbar-nav">
18-
<li class="{$MainNavClass} <% if $ClassName == 'SummitAboutPage' %> current<% end_if %> link">
19-
<a href="$SummitAboutLink">About</a>
18+
<li class="{$getAboutPageNavClass}">
19+
<a href="{$getSummitAboutPageLink}">About</a>
2020
</li>
2121
<% loop $Menu(3) %>
22-
<li class="$LinkingMode">
23-
<a href="$Link">$MenuTitle</a>
24-
</li>
25-
<% end_loop %>
22+
<li class="{$LinkingMode}">
23+
<a href="{$Link}">$MenuTitle</a>
24+
</li>
25+
<% end_loop %>
2626

27-
<li class="link button-box">
28-
<a href="https://www.eventbrite.com/e/openstack-summit-november-2018-berlin-tickets-41880169715" class="btn register-btn-lrg">Get your tickets <i class="fa fa-arrow-right"></i>
29-
</a>
30-
</li>
27+
<li class="link button-box">
28+
<a href="https://www.eventbrite.com/e/openstack-summit-november-2018-berlin-tickets-41880169715" class="btn register-btn-lrg">
29+
Get your tickets <i class="fa fa-arrow-right"></i>
30+
</a>
31+
</li>
3132
</ul>
3233
</div>
3334
</div>

summit/templates/Includes/SummitNav.ss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99

1010
<div className="collapse navbar-collapse" id="header-navbar-collapse">
1111
<ul class="nav nav-tabs" >
12-
<li class="{$MainNavClass} <% if $ClassName == 'SummitAboutPage' %> current<% end_if %>">
13-
<a href="$SummitAboutLink">About The Summit</a>
12+
<li class="{$getAboutPageNavClass}">
13+
<a href="{$getSummitAboutPageLink}">About The Summit</a>
1414
</li>
1515
<% loop $Menu(3) %>
16-
<li class="$LinkingMode">
17-
<a href="$Link">$MenuTitle</a>
16+
<li class="{$LinkingMode}">
17+
<a href="{$Link}">$MenuTitle</a>
1818
</li>
1919
<% end_loop %>
2020
</ul>

0 commit comments

Comments
 (0)