Skip to content

Commit 1e1b064

Browse files
committed
[spalenque] - fix context and baseUrl not working
1 parent e734d32 commit 1e1b064

5 files changed

Lines changed: 24 additions & 22 deletions

File tree

app/app.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
55
var xhr_suggestions = null;
66
var timeout_suggestions = null;
77
var search_widget = {
8-
init: function (baseUrl, context) {
9-
10-
baseUrl = baseUrl ? baseUrl : 'devbranch.search.openstack.org';
11-
context = context ? context : 'www-openstack';
8+
init: function (z) {
129

1310
var $style = $("<style></style>", {type: "text/css"});
1411
$style.text(css);
@@ -18,6 +15,8 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
1815
$('.openstack-search-bar').each(function() {
1916

2017
var el = $(this);
18+
var baseUrl = el.data('baseurl') ? el.data('baseurl') : 'devbranch.search.openstack.org';
19+
var context = el.data('context') ? el.data('context') : 'www-openstack';
2120
// render our main view
2221
this.ractive = new Ractive({
2322
el: el,
@@ -40,11 +39,10 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
4039
this.ractive.on({
4140
clear: function(ev) {
4241
ev.original.preventDefault();
43-
$('.ossw-search-suggestions', el).hide();
42+
$('.ossw-search-suggestions-wrapper', el).hide();
4443
this.set('term', '');
4544
},
4645
search: function(ev) {
47-
var term = this.get('term');
4846
var that = this;
4947
ev.original.preventDefault();
5048

@@ -56,13 +54,12 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
5654
centerPopup(el);
5755

5856
} else {
59-
$('.ossw-search-suggestions', el).show();
57+
$('.ossw-search-suggestions-wrapper', el).show();
6058
if ( timeout_suggestions ) clearTimeout(timeout_suggestions);
6159
timeout_suggestions = window.setTimeout(doSuggestions, 500, that);
6260
}
6361
},
6462
searchPopup: function(ev) {
65-
var term = this.get('term');
6663
var that = this;
6764

6865
ev.original.preventDefault();
@@ -209,8 +206,8 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
209206
var popMaxWidth = parseInt($('.ossw-container', el).css('max-width').slice(0, -2));
210207

211208
$('.ossw-search-results', el).show();
212-
$('.ossw-search-suggestions', el).hide();
213209
$('.ossw-suggestions-wrapper', el).hide();
210+
$('.ossw-search-suggestions-wrapper', el).hide();
214211

215212
if (newPopWidth < popMaxWidth) {
216213
$('.ossw-container', el).css('left', winW*0.1);

css/widget-styles.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,11 @@
4646
color: #8B9BAD;
4747
}
4848

49-
.ossw-search-suggestions {
49+
.ossw-search-suggestions-wrapper {
5050
display: none;
51+
}
52+
53+
.ossw-search-suggestions {
5154
border: 1px solid #DDDDDD;
5255
padding: 5px;
5356
position: relative;

embed.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ require(["jquery", "app/app"], function($, app) {
33
"use strict";
44

55
$(function() {
6-
var baseUrl = $('#openstack-search-bar').data('baseUrl');
7-
var context = $('#openstack-search-bar').data('context');
8-
app.init(baseUrl, context);
6+
app.init();
97
});
108
});

embed.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/template.html

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,18 @@
33
<input value="{{term}}" on-keyup="search" type="text" id="search-bar-input" placeholder="Search OpenStack" />
44
<i class="fa fa-times ossw-search-bar-close" on-click="clear"></i>
55
</div>
6-
<div class="ossw-search-suggestions">
7-
<div class="ossw-results">
8-
{{#suggestions}}
9-
<a href="{{link}}" class="ossw-result-item" >
10-
<div class="ossw-result-heading"> {{{title}}} </div>
11-
</a>
12-
{{/}}
6+
<div class="ossw-search-suggestions-wrapper">
7+
{{#if suggestions.length}}
8+
<div class="ossw-search-suggestions">
9+
<div class="ossw-results">
10+
{{#suggestions}}
11+
<a href="{{link}}" class="ossw-result-item" >
12+
<div class="ossw-result-heading"> {{{title}}} </div>
13+
</a>
14+
{{/}}
15+
</div>
1316
</div>
17+
{{/if}}
1418
</div>
1519

1620
<div class="ossw-search-results">

0 commit comments

Comments
 (0)