Skip to content

Commit 448c797

Browse files
committed
[smarcet]
* used meta title and description as a first choice on search results
1 parent 52f1120 commit 448c797

6 files changed

Lines changed: 28 additions & 28 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Search Bar embedded widget using [RequireJS](http://requirejs.org) and [Ractive.
44

55
## Building the widget
66

7-
Assuming RequireJS and bower are already installed:
7+
Assuming RequireJS is already installed:
88

99
```console
1010
$ make init

app/app.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
33
'use strict';
44

55
$.noConflict();
6-
6+
var MAX_DETAIL_LEN = 100;
77
var xhr_suggestions = null;
88
var timeout_suggestions = null;
99
var search_widget = {
@@ -19,7 +19,7 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
1919
$('.openstack-search-bar').each(function() {
2020

2121
var el = $(this);
22-
var baseUrl = el.data('baseurl') ? el.data('baseurl') : 'devbranch.search.openstack.org';
22+
var baseUrl = el.data('baseurl') ? el.data('baseurl') : 'search.openstack.org';
2323
var context = el.data('context') ? el.data('context') : 'www-openstack';
2424
// render our main view
2525
this.ractive = new Ractive({
@@ -111,10 +111,10 @@ define(['jquery', 'ractive', 'rv!templates/template', 'text!css/widget-styles.cs
111111
dataType: "json"
112112
}).done(function(resp) {
113113
var results = resp.results.map(function(r) {
114-
var term_idx = r.content.toLowerCase().indexOf(term.toLowerCase());
115-
var detail = '...' + r.content.slice(term_idx - 40, term_idx + 40) + '...';
116-
117-
return {link: r.url, title: r.title, detail: detail};
114+
var detail = r.hasOwnProperty('meta_description') ? r.meta_description : r.content;
115+
detail = detail.length > MAX_DETAIL_LEN ? detail.substring(0, MAX_DETAIL_LEN) + '...' : detail;
116+
var title = r.hasOwnProperty('meta_title') ? r.meta_title : r.title;
117+
return {link: r.url, title: title, detail: detail};
118118
});
119119

120120
that.set('total', resp.qty);

embed.min.js

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</head>
1010
<body>
1111
<h1>Embedded widget test</h1>
12-
<div class="openstack-search-bar" data-baseUrl="search.openstack.org" data-context="www-openstack"></div>
12+
<div class="openstack-search-bar" data-baseUrl="localhost:8081" data-context="www-openstack"></div>
1313
<script>
1414
(function (window, document) {
1515
var loader = function () {

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"dependencies": {
1010
"almond": "^0.3.3",
1111
"jquery": "^3.3.1",
12-
"ractive": "^0.10.3",
13-
"requirejs": "^2.3.5",
12+
"ractive": "^0.10.9",
13+
"requirejs": "^2.3.6",
1414
"requirejs-text": "^2.0.15",
1515
"rv": "^0.1.8",
1616
"rvc": "^0.5.0"

0 commit comments

Comments
 (0)