Skip to content

Commit 0c6a820

Browse files
committed
fix(repository): SummitEventReposutory has a missing join on filtering
1 parent fb45bcc commit 0c6a820

4 files changed

Lines changed: 408 additions & 2 deletions

File tree

.github/workflows/push.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ jobs:
6868
- { name: "AuditOtlpStrategyTest", filter: "--filter AuditOtlpStrategyTest" }
6969
- { name: "AuditEventTypesTest", filter: "--filter AuditEventTypesTest" }
7070
- { name: "GuzzleTracingTest", filter: "--filter GuzzleTracingTest" }
71+
- { name: "Repositories", filter: "--filter tests/Repositories/" }
7172
env:
7273
OTEL_SERVICE_ENABLED: false
7374
APP_ENV: testing

app/Repositories/Summit/DoctrineSummitEventRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ private function requiredAliases(?Filter $filter, ?Order $order): array
545545
}
546546

547547
if($has('track_chairs_status'))
548-
$need['sspl'] = $need['ssp'] = true;
548+
$need['sspl'] = $need['ssp'] = $need['ssp_member'] = true;
549549

550550
if($ord('trackchairsel'))
551551
$need['ssp'] = true;

app/Services/Model/Imp/SpeakerService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ public function deleteSpeaker(int $speaker_id):void
766766
{
767767
$this->tx_service->transaction(function () use ($speaker_id) {
768768
$speaker = $this->speaker_repository->getById($speaker_id);
769-
if (!$speaker instanceof PresentationSpeaker::class)
769+
if (!$speaker instanceof PresentationSpeaker)
770770
throw new EntityNotFoundException;
771771

772772
// Break circular FK reference to avoid Doctrine CycleDetectedException:

0 commit comments

Comments
 (0)