Registration Invitations

Fix on accepted filter

Change-Id: I23387acb68d7af3d52c0ac0e2a877d1ef6d9eb0f

Author: smarcet

app/Models/Foundation/Summit/Registration/SummitRegistrationInvitation.php

@@ -373,7 +373,7 @@ public function getRemainingAllowedTicketTypes():array {
 
     public function markAsAccepted(): void
     {
-        Log::debug(sprintf("SummitRegistrationInvitation::markAsAccepted %s ", $this->id));
+        Log::debug(sprintf("SummitRegistrationInvitation::markAsAccepted %s orders count %s", $this->id, $this->orders->count()));
         if($this->orders->count() === 0 ) return;
 
         $bought_tickets = $this->getBoughtTicketTypesExcerpt();
@@ -397,14 +397,18 @@ public function markAsAccepted(): void
             );
 
         foreach ($invitation_ticket_types as $ticket_type){
+            Log::debug(sprintf("SummitRegistrationInvitation::markAsAccepted %s checking if ticket type %s is purchased ... ", $this->id, $ticket_type->getId()));
             if(!isset($bought_tickets[$ticket_type->getId()])){
-                Log::debug(sprintf("SummitRegistrationInvitation::markAsAccepted %s ticket type %s is not purchased yet ", $this->id, $ticket_type->getId()));
+                Log::debug(sprintf("SummitRegistrationInvitation::markAsAccepted %s ticket type %s is not purchased yet, marking invitation as non accepted ... ", $this->id, $ticket_type->getId()));
                 $this->accepted_date = null;
                 return;
             }
         }
+
         // once i bought all meant ticket types ... the invitation is marked as accepted
         $this->accepted_date = new \DateTime('now', new \DateTimeZone('UTC'));
+
+        Log::debug(sprintf("SummitRegistrationInvitation::markAsAccepted %s marked as accepted", $this->id));
     }
 
     public function isAccepted(): bool
@@ -426,6 +430,10 @@ public function getOrders(){
         return $this->orders;
     }
 
+    public function hasTicketType(SummitTicketType $ticketType):bool{
+        return $this->ticket_types->contains($ticketType);
+    }
+
     /**
      * @param SummitTicketType $ticketType
      * @throws ValidationException

app/Repositories/Summit/DoctrineSummitRegistrationInvitationRepository.php

@@ -57,7 +57,7 @@ protected function getFilterMappings()
             'email' => 'e.email:json_string',
             'first_name' => 'e.first_name:json_string',
             'last_name' => 'e.last_name:json_string',
-            'is_completed' => new DoctrineSwitchFilterMapping([
+            'is_accepted' => new DoctrineSwitchFilterMapping([
                     'true' => new DoctrineCaseFilterMapping(
                         'true',
                         "e.accepted_date is not null"
@@ -68,17 +68,6 @@ protected function getFilterMappings()
                     ),
                 ]
             ),
-            'is_accepted' => new DoctrineSwitchFilterMapping([
-                    'true' => new DoctrineCaseFilterMapping(
-                        'true',
-                        "SIZE(e.orders) > 0"
-                    ),
-                    'false' => new DoctrineCaseFilterMapping(
-                        'false',
-                        "e.orders IS EMPTY"
-                    ),
-                ]
-            ),
             'is_sent' => new DoctrineSwitchFilterMapping([
                     'true' => new DoctrineCaseFilterMapping(
                         'true',

app/Services/Model/Imp/SummitRegistrationInvitationService.php

@@ -357,28 +357,44 @@ public function update(Summit $summit, int $invitation_id, array $payload): Summ
                 $email = trim($payload['email']);
                 try {
                     $invitation = $this->setInvitationMember($invitation, $email);
-                }
-                catch (\Exception $ex){
+                } catch (\Exception $ex) {
                     Log::warning($ex);
                 }
             }
 
+            $is_formerly_accepted = $invitation->isAccepted();
             $allowed_ticket_types = $payload['allowed_ticket_types'] ?? [];
-            $invitation->clearTicketTypes();
-            foreach ($allowed_ticket_types as $ticket_type_id) {
-                $ticket_type = $summit->getTicketTypeById(intval($ticket_type_id));
-                if (is_null($ticket_type)) {
-                    throw new ValidationException
-                    (
-                        sprintf
+            if (count($allowed_ticket_types) > 0) {
+                foreach ($allowed_ticket_types as $ticket_type_id) {
+                    $ticket_type = $summit->getTicketTypeById(intval($ticket_type_id));
+                    if (is_null($ticket_type)) {
+                        throw new ValidationException
                         (
-                            "SummitRegistrationInvitationService::add ticket type %s does not exists on summit %s.",
-                            $ticket_type_id,
-                            $summit->getId()
-                        )
-                    );
+                            sprintf
+                            (
+                                "SummitRegistrationInvitationService::add ticket type %s does not exists on summit %s.",
+                                $ticket_type_id,
+                                $summit->getId()
+                            )
+                        );
+                    }
+                    $invitation->addTicketType($ticket_type);
                 }
-                $invitation->addTicketType($ticket_type);
+                // remove missing ones
+                $to_remove = [];
+                foreach ($invitation->getTicketTypes() as $invitation_ticket_type){
+                    if(!in_array($invitation_ticket_type->getId(), $allowed_ticket_types)){
+                        $to_remove[] = $invitation_ticket_type;
+                    }
+                }
+                foreach ($to_remove as $ticket_type_to_remove){
+                    $invitation->removeTicketType($ticket_type_to_remove);
+                }
+            }
+
+            if($invitation->isAccepted() != $is_formerly_accepted){
+               // it changed its state bc the ticket types update
+                $payload['is_accepted'] = $invitation->isAccepted();
             }
 
             // tags