fix: change in public endpoints, removal of unnecessary scope security

Author: andrestejerina97

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSponsorApiController.php

@@ -298,27 +298,10 @@ public function getAllBySummitV2($summit_id){
 
     #[OA\Get(
         path: "/api/public/v1/summits/all/{id}/sponsors",
-        description: "Get a specific sponsor by id",
+        description: "Get all sponsors for a summit",
         summary: 'Get Sponsors by Summit ID (Public)',
         operationId: 'getSponsorsV2BySummitPublic',
         tags: ['Sponsors (Public)'],
-        security: [
-            [
-                'summit_sponsor_oauth2' => [
-                    SummitScopes::ReadSummitData,
-                    SummitScopes::ReadAllSummitData,
-                ]
-            ]
-        ],
-        x: [
-            'required-groups' => [
-                IGroup::SuperAdmins,
-                IGroup::Administrators,
-                IGroup::SummitAdministrators,
-                IGroup::Sponsors,
-                IGroup::SponsorExternalUsers,
-            ]
-        ],
         parameters: [
             new OA\Parameter(
                 name: 'id',
@@ -327,22 +310,13 @@ public function getAllBySummitV2($summit_id){
                 schema: new OA\Schema(type: 'integer'),
                 description: 'The summit id'
             ),
-            new OA\Parameter(
-                name: 'sponsor_id',
-                in: 'path',
-                required: true,
-                schema: new OA\Schema(type: 'integer'),
-                description: 'The sponsor id'
-            ),
         ],
         responses: [
             new OA\Response(
                 response: Response::HTTP_OK,
                 description: 'Success',
                 content: new OA\JsonContent(ref: '#/components/schemas/SponsorV2')
             ),
-            new OA\Response(response: Response::HTTP_UNAUTHORIZED, description: "Unauthorized"),
-            new OA\Response(response: Response::HTTP_FORBIDDEN, description: "Forbidden"),
             new OA\Response(response: Response::HTTP_NOT_FOUND, description: "Not Found"),
             new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
         ]
@@ -359,10 +333,27 @@ public function getAllBySummitPublic($summit_id)
 
     #[OA\Get(
         path: "/api/v2/summits/{id}/sponsors/{sponsor_id}",
-        description: "Get all sponsors for a summit (Public API)",
-        summary: 'Read Sponsors by Summit',
+        description: "Get a specific sponsor by id",
+        summary: 'Read Sponsor by Summit',
         operationId: 'getSponsorsV2BySummit',
         tags: ['Sponsors'],
+        security: [
+            [
+                'summit_sponsor_oauth2' => [
+                    SummitScopes::ReadSummitData,
+                    SummitScopes::ReadAllSummitData,
+                ]
+            ]
+        ],
+        x: [
+            'required-groups' => [
+                IGroup::SuperAdmins,
+                IGroup::Administrators,
+                IGroup::SummitAdministrators,
+                IGroup::Sponsors,
+                IGroup::SponsorExternalUsers,
+            ]
+        ],
         parameters: [
             new OA\Parameter(
                 name: 'id',
@@ -371,6 +362,13 @@ public function getAllBySummitPublic($summit_id)
                 schema: new OA\Schema(type: 'integer'),
                 description: 'The summit id'
             ),
+            new OA\Parameter(
+                name: 'sponsor_id',
+                in: 'path',
+                required: true,
+                schema: new OA\Schema(type: 'integer'),
+                description: 'The sponsor id'
+            ),
         ],
         responses: [
             new OA\Response(
@@ -2057,7 +2055,7 @@ public function getAd($summit_id, $sponsor_id, $ad_id)
 
     #[OA\Get(
         path: "/api/v1/summits/{id}/sponsors/{sponsor_id}/materials",
-        description: "required-groups " . IGroup::SuperAdmins . ", " . IGroup::Administrators . ", " . IGroup::SummitAdministrators . ", " . IGroup::Sponsors . ", " . IGroup::SponsorExternalUsers,
+        description: "required-groups " . IGroup::SuperAdmins . ", " . IGroup::Administrators . ", " . IGroup::SummitAdministrators . ", " . IGroup::Sponsors,
         summary: 'Read Sponsor Materials',
         operationId: 'getSponsorMaterials',
         tags: ['Sponsors'],
@@ -2067,7 +2065,6 @@ public function getAd($summit_id, $sponsor_id, $ad_id)
                 IGroup::Administrators,
                 IGroup::SummitAdministrators,
                 IGroup::Sponsors,
-                IGroup::SponsorExternalUsers,
             ]
         ],
         security: [
@@ -2512,7 +2509,7 @@ public function getMaterial($summit_id, $sponsor_id, $material_id)
 
     #[OA\Get(
         path: "/api/v1/summits/{id}/sponsors/{sponsor_id}/social-networks",
-        description: "required-groups " . IGroup::SuperAdmins . ", " . IGroup::Administrators . ", " . IGroup::SummitAdministrators . ", " . IGroup::Sponsors . ", " . IGroup::SponsorExternalUsers,
+        description: "required-groups " . IGroup::SuperAdmins . ", " . IGroup::Administrators . ", " . IGroup::SummitAdministrators . ", " . IGroup::Sponsors,
         summary: 'Read Sponsor Social Networks',
         operationId: 'getSponsorSocialNetworks',
         tags: ['Sponsors'],
@@ -2522,7 +2519,6 @@ public function getMaterial($summit_id, $sponsor_id, $material_id)
                 IGroup::Administrators,
                 IGroup::SummitAdministrators,
                 IGroup::Sponsors,
-                IGroup::SponsorExternalUsers,
             ]
         ],
         security: [

app/Swagger/Models/SubQuestionRuleSchema.php

@@ -14,7 +14,7 @@
         new OA\Property(property: 'last_edited', type: 'integer', example: 1, format: "time_epoch"),
         new OA\Property(property: 'visibility', type: 'string'),
         new OA\Property(property: 'visibility_condition', type: 'string'),
-        new OA\Property(property: 'answer_values', type: 'string_array'),
+        new OA\Property(property: 'answer_values', type: 'array', items: new OA\Items(type: 'string')),
         new OA\Property(property: 'answer_values_operator', type: 'string'),
         new OA\Property(property: 'order', type: 'integer'),
         new OA\Property(property: 'sub_question_id', type: 'integer'),