fix: CSVReader row has not same length as header

Change-Id: I407db16125c50948167e71524b37e5bcdd42d420

Author: smarcet

app/Services/Utils/CSVReader.php

@@ -71,9 +71,8 @@ public static function buildFrom(string $content):CSVReader
                 continue;
             }
             $line  = [];
-            if(count($row) != count($header)) continue;
             for($i = 0; $i < count($header); $i++){
-                $line[$header[$i]] = trim($row[$i]);
+                $line[$header[$i]] = $row[$i] ?? '';
             }
             $lines[] = $line;
 
@@ -146,4 +145,8 @@ public function rewind()
     {
         $this->position = 0;
     }
+
+    public function count():int{
+        return count($this->lines);
+    }
 }

tests/CSVReaderTest.php

@@ -40,6 +40,20 @@ public function testOneColCSV()
         }
     }
 
+    public function testRowHasMoreColsThanHeaderCSV()
+    {
+        $data = <<<CSV
+code,class_name,quantity_available,sponsor_id,contact_email
+TEST_SANTI_SPONS_DIS,SPONSOR_DISCOUNT_CODE,10,,,
+TEST_SANTI_SPONS_PROMO,SPONSOR_PROMO_CODE,10,252,,
+SANTI_SPONS_PROMO1,SPONSOR_PROMO_CODE,10,,santipalenque@gmail.com
+SANTI_SPONS_PROMO2,SPONSOR_PROMO_CODE,10
+CSV;
+
+        $reader = CSVReader::buildFrom($data);
+        $this->assertTrue($reader->hasColumn("contact_email"));
+        $this->assertTrue($reader->count() == 4);
+    }
     public function test3ColCSV()
     {
         $data = <<<CSV