chore: PR review

Author: smarcet

app/Http/Utils/FilterAvailableSummitsStrategy.php

@@ -12,7 +12,6 @@
  * limitations under the License.
  **/
 use App\Security\SummitScopes;
-use Illuminate\Support\Facades\Config;
 use models\oauth2\IResourceServerContext;
 /**
  * Class FilterAvailableSummitsStrategy
@@ -30,4 +29,4 @@ static public function shouldReturnAllSummits(IResourceServerContext $resource_s
         $needed_scope   = SummitScopes::ReadAllSummitData;
         return in_array($needed_scope, $scopes);
     }
-}
+}

app/Providers/AppServiceProvider.php

@@ -719,7 +719,10 @@ public function register()
     {
 
         if (!defined('SCOPE_BASE_REALM')) {
-            define('SCOPE_BASE_REALM', config('app.scope_base_realm'));
+            $scopeBaseRealm = rtrim((string) config('app.scope_base_realm', ''), '/');
+            if ($scopeBaseRealm === '')
+                throw new \RuntimeException('Missing required config: app.scope_base_realm');
+             define('SCOPE_BASE_REALM', $scopeBaseRealm);
         }
 
         App::singleton(IResourceServerContext::class, ResourceServerContext::class);

tests/ProtectedApiTestCase.php

@@ -27,7 +27,6 @@
 use App\Models\Foundation\Main\IGroup;
 use App\Security\CompanyScopes;
 use App\Security\SponsoredProjectScope;
-use App\Security\GroupsScopes;
 use App\Security\TeamScopes;
 use Mockery;
 /**
@@ -226,7 +225,6 @@ public function get($token_value)
             SummitScopes::ReadSummitsConfirmExternalOrders,
             SummitScopes::WriteSummitsConfirmExternalOrders,
             SummitScopes::WriteVideoData,
-            SummitScopes::WriteVideoData,
             SummitScopes::MeRead,
             SummitScopes::ReadNotifications,
             MemberScopes::ReadMemberData,