Skip to content

Commit 7110c51

Browse files
committed
fix: ticket import , check null email attendees
Change-Id: Ia587771c6a94a5e23e536f2336e82dfe8af9c610
1 parent 29da8d5 commit 7110c51

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

app/Jobs/ProcessTicketDataImport.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class ProcessTicketDataImport implements ShouldQueue
3030
{
3131
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
3232

33-
public $tries = 2;
33+
public $tries = 1;
3434

3535
// no timeout
3636
public $timeout = 0;

app/Repositories/Summit/DoctrineMemberRepository.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,7 @@ protected function getOrderMappings()
470470
public function getByEmail($email): ?Member
471471
{
472472
$email = PunnyCodeHelper::encodeEmail($email);
473+
if(empty($email)) return null;
473474
return $this->getEntityManager()
474475
->createQueryBuilder()
475476
->select("e")

app/Services/Model/Imp/SummitOrderService.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3942,17 +3942,18 @@ public function processTicketData(int $summit_id, string $filename)
39423942
}
39433943
// process attendee data ( try to get an existent attendee or create a new one)
39443944
if ($attendee_data_present) {
3945-
Log::debug(sprintf("SummitOrderService::processTicketData - has attendee data present ... trying to get attendee %s", $row['attendee_email']));
3945+
$attendee_email = $row['attendee_email'] ?? '';
3946+
Log::debug(sprintf("SummitOrderService::processTicketData - has attendee data present ... trying to get attendee %s", $attendee_email));
39463947
// check if attendee exists
3947-
$attendee = $this->attendee_repository->getBySummitAndEmail($summit, $row['attendee_email']);
3948-
$member = $this->member_repository->getByEmail($row['attendee_email']);
3948+
$attendee = $this->attendee_repository->getBySummitAndEmail($summit, $attendee_email);
3949+
$member = $this->member_repository->getByEmail($attendee_email);
39493950

3950-
if (is_null($attendee)) {
3951+
if (is_null($attendee) && !empty($attendee_email)){
39513952

3952-
Log::debug(sprintf("SummitOrderService::processTicketData - attendee %s does not exists", $row['attendee_email']));
3953+
Log::debug(sprintf("SummitOrderService::processTicketData - attendee %s does not exists", $attendee_email));
39533954
// create attendee ( populate payload)
39543955
$payload = [
3955-
'email' => $row['attendee_email'],
3956+
'email' => $attendee_email,
39563957
'first_name' => $row['attendee_first_name'],
39573958
'last_name' => $row['attendee_last_name'],
39583959
];

0 commit comments

Comments
 (0)