fix on job time out

* AttendeeService::resynchAttendeesStatusBySummit refactor

Change-Id: Ifbbb8243ebcf2617085e1902a0af8c656a40b934

Author: smarcet

app/Console/Commands/RecalculateAttendeesStatusCommand.php

@@ -77,7 +77,7 @@ public function handle()
             $summit_id = $this->argument('summit_id');
             if(empty($summit_id))
                 throw new \InvalidArgumentException("summit_id is required");
-            $this->service->recalculateAttendeeStatus(intval($summit_id));
+            $this->service->resynchAttendeesStatusBySummit(intval($summit_id));
             $end   = time();
             $delta = $end - $start;
             $this->info(sprintf("execution call %s seconds", $delta));

app/Jobs/SynchAllAttendeesStatus.php

@@ -11,29 +11,26 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  **/
+
+use App\Services\Model\IAttendeeService;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Log;
 use libs\utils\ITransactionService;
-use models\exceptions\EntityNotFoundException;
 use models\summit\ISummitAttendeeRepository;
 use models\summit\ISummitRepository;
-use models\summit\Summit;
-use models\summit\SummitAttendee;
 
 /**
  * Class SynchAllAttendeesStatus
  * @package App\Jobs
  */
-class SynchAllAttendeesStatus implements ShouldQueue
+final class SynchAllAttendeesStatus implements ShouldQueue
 {
     public $tries = 1;
 
-    public $timeout = 0;
-
     use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
 
     /**
@@ -51,36 +48,22 @@ public function __construct(int $summit_id)
     }
 
     /**
+     * @param IAttendeeService $service
      * @param ISummitRepository $repository
+     * @param ISummitAttendeeRepository $attendeeRepository
      * @param ITransactionService $tx_service
+     * @return void
      * @throws \Exception
      */
-    public function handle(
-        ISummitRepository $repository,
-        ISummitAttendeeRepository $attendeeRepository,
-        ITransactionService $tx_service
-    )
+    public function handle(IAttendeeService $service)
     {
         Log::debug(sprintf("SynchAllAttendeesStatus::handle summit %s", $this->summit_id));
-        $attendees_ids = $tx_service->transaction(function() use($repository){
-            $attendees_ids = [];
-            $summit = $repository->getById($this->summit_id);
-            if(!$summit instanceof Summit)
-                throw new EntityNotFoundException(sprintf("Summit %s not found", $this->summit_id));
-
-            foreach($summit->getAttendees() as $a)
-                $attendees_ids[] = $a->getId();
-
-            return $attendees_ids;
-        });
+        $service->resynchAttendeesStatusBySummit($this->summit_id);
+    }
 
-        foreach ($attendees_ids as $attendee_id){
-            $tx_service->transaction(function() use($attendeeRepository, $attendee_id){
-                $attendee = $attendeeRepository->getById($attendee_id);
-                if(!$attendee instanceof SummitAttendee) return;
-                $attendee->updateStatus();
-            });
-        }
+    public function failed(\Throwable $exception)
+    {
+        Log::error($exception);
     }
 }
 

app/Services/Model/AttendeeService.php

@@ -551,17 +551,6 @@ public function send(int $summit_id, array $payload, Filter $filter = null): voi
             $summit_id, $flow_event, is_null($filter) ? '' : $filter->__toString(), $count));
     }
 
-    public function recalculateAttendeeStatus(int $summit_id):void{
-        $this->tx_service->transaction(function() use($summit_id){
-            $summit = $this->summit_repository->getById($summit_id);
-            if(is_null($summit) || !$summit instanceof Summit) return;
-
-            foreach($summit->getAttendees() as $attendee){
-                $attendee->updateStatus();
-            }
-        });
-    }
-
     public function doVirtualCheckin(Summit $summit, int $attendee_id): ?SummitAttendee
     {
         return $this->tx_service->transaction(function() use($summit, $attendee_id){
@@ -739,4 +728,62 @@ public function updateAttendeesByMemberId(int $member_id): void
             }
         });
     }
+
+    /**
+     * @param int $summit_id
+     * @return void
+     * @throws EntityNotFoundException
+     */
+    public function resynchAttendeesStatusBySummit(int $summit_id): void
+    {
+
+        Log::debug(sprintf("AttendeeService::resynchAttendeesStatusBySummit summit id %s", $summit_id));
+        $summit = $this->summit_repository->getById($summit_id);
+        if(!$summit instanceof Summit)
+            throw new EntityNotFoundException(sprintf("Summit %s not found", $summit_id));
+
+        $count = 0;
+        $maxPageSize = 100;
+        $current_page = 1;
+        $filter = new Filter();
+        $filter->addFilterCondition(FilterElement::makeEqual('summit_id', $summit_id));
+
+        do {
+            $attendees_ids =
+                $this->tx_service->transaction(function() use($summit, $current_page, $filter, $maxPageSize) {
+                    Log::debug(sprintf("AttendeeService::resynchAttendeesStatusBySummit page %s", $current_page));
+                    $this->attendee_repository->getAllIdsByPage(new PagingInfo($current_page, $maxPageSize), $filter);
+                });
+
+            if (!count($attendees_ids)) {
+                // if we are processing a page, then break it
+                Log::debug
+                (
+                    sprintf
+                    (
+                        "AttendeeService::resynchAttendeesStatusBySummit summit id %s page is empty, ending processing.",
+                        $summit_id
+                    )
+                );
+                break;
+            }
+
+            foreach ($attendees_ids as $attendee_id) {
+                try {
+                    $this->tx_service->transaction(function () use ($attendee_id) {
+                        $attendee = $this->attendee_repository->getById($attendee_id);
+                        if (!$attendee instanceof SummitAttendee) return;
+                        $attendee->updateStatus();
+                    });
+                    $count++;
+                }
+                catch (\Exception $ex){
+                    Log::warning($ex);
+                }
+            }
+            ++$current_page;
+        } while(true);
+
+        Log::debug(sprintf("AttendeeService::resynchAttendeesStatusBySummit summit id %s processed %s attendees", $summit_id, $count));
+    }
 }

app/Services/Model/IAttendeeService.php

@@ -103,11 +103,6 @@ public function triggerSend(Summit $summit, array $payload, $filter = null):void
      */
     public function send(int $summit_id, array $payload, Filter $filter = null):void;
 
-    /**
-     * @param int $summit_id
-     */
-    public function recalculateAttendeeStatus(int $summit_id):void;
-
     /**
      * @param Summit $summit_id
      * @param int $attendee_id
@@ -129,4 +124,6 @@ public function doCheckIn(Summit $summit, String $qr_code): void;
      * @param int $member_id
      */
     public function updateAttendeesByMemberId(int $member_id):void;
+
+    public function resynchAttendeesStatusBySummit(int $summit_id):void;
 }