fix: presentation review status

false rejected status

Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>

Author: smarcet

app/Models/Foundation/Summit/Events/Presentations/Presentation.php

@@ -2432,11 +2432,13 @@ public function getReviewStatus(): string
             return self::ReviewStatusNoSubmitted;
 
         $selection_plan = $this->selection_plan;
-
+        // submission period data
         $submission_begin_date = $selection_plan->getSubmissionBeginDate();
         $submission_end_date = $selection_plan->getSubmissionEndDate();
+        // selection period data
         $selection_begin_date = $selection_plan->getSelectionBeginDate();
         $selection_end_date = $selection_plan->getSelectionEndDate();
+        $selectionPeriodIsDefined = !is_null($selection_begin_date) & !is_null($selection_end_date);
         $submission_lock_down_presentation_status_date = $selection_plan->getSubmissionLockDownPresentationStatusDate();
 
         $now = new \DateTime('now', new \DateTimeZone('UTC'));
@@ -2483,11 +2485,11 @@ public function getReviewStatus(): string
             $submission_lock_down_presentation_status_date > $now;
 
         // if lock down period is enabled then short-circuit everything
-        if ($is_lock_down_period || ($submission_closed && $selection_open)) {
+        if ($is_lock_down_period || ($selectionPeriodIsDefined && $submission_closed && $selection_open)) {
             return self::ReviewStatusInReview;
         } else if ($this->isPublished()) {
             return self::ReviewStatusPublished;
-        } else if ($selection_closed) {
+        } else if ($selectionPeriodIsDefined && $selection_closed) {
             return $submission_accepted ? self::ReviewStatusAccepted : self::ReviewStatusRejected;
         }
 

database/migrations/model/Version20240531145157.php

@@ -81,7 +81,8 @@ public function up(Schema $schema): void
         THEN 'Accepted'
         WHEN (P.status = 'Received' OR P.status = 'Accepted') AND
         (
-            SP.SelectionBeginDate IS NULL OR SP.SelectionBeginDate > UTC_TIMESTAMP() OR SP.SelectionEndDate < UTC_TIMESTAMP() OR SP.SelectionEndDate IS NULL
+            SP.SelectionBeginDate IS NOT NULL AND SP.SelectionEndDate IS NOT NULL AND
+            SP.SelectionBeginDate < UTC_TIMESTAMP() AND SP.SelectionEndDate < UTC_TIMESTAMP()
         )
         AND NOT EXISTS (
             SELECT 1 FROM SummitSelectedPresentation SSP