fix: hidden selection plan with former allowed members

Author: smarcet

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSelectionPlansApiController.php

@@ -23,6 +23,7 @@
 use App\Services\Model\ISummitSelectionPlanService;
 use Illuminate\Http\Request as LaravelRequest;
 use libs\utils\HTMLCleaner;
+use libs\utils\PaginationValidationRules;
 use models\exceptions\EntityNotFoundException;
 use models\oauth2\IResourceServerContext;
 use models\summit\ISummitEventRepository;
@@ -1670,7 +1671,7 @@ public function getMySelectionPlans($id){
             $filter->addFilterCondition(FilterParser::buildFilter('is_enabled','==',true));
             $filter->addFilterCondition(FilterParser::buildFilter('allowed_member_email','==', $current_member->getEmail()));
 
-            $page = $this->repository->getAllByPage(new PagingInfo(1,1000), $filter);
+            $page = $this->repository->getAllByPage(new PagingInfo(1,PaginationValidationRules::PerPageMax), $filter);
 
             return $this->ok($page->toArray(
                 SerializerUtils::getExpand(),

app/Models/Foundation/Summit/SelectionPlan.php

@@ -432,6 +432,10 @@ public function isHidden(): bool
     public function setIsHidden(bool $is_hidden)
     {
         $this->is_hidden = $is_hidden;
+        if($this->is_hidden){
+            // clear allowed members on hidden
+            $this->allowed_members->clear();
+        }
     }
 
     /**

app/Repositories/Summit/DoctrineSelectionPlanRepository.php

@@ -83,7 +83,7 @@ protected function getFilterMappings()
                     ),
                 ]
             ),
-            'allowed_member_email' => 'SIZE(e.allowed_members) = 0 OR am.email',
+            'allowed_member_email' => 'e.is_hidden = true OR (e.is_hidden = false AND SIZE(e.allowed_members) = 0 ) OR am.email',
             'is_enabled' => 'e.is_enabled',
             'is_hidden' => 'e.is_hidden',
         ];