fix: sponsored projects parent project setup

Change-Id: I206e64e0a69ad850f0ee17c43b99c8fe4ccc066f

Author: smarcet

app/Http/Controllers/Apis/Protected/Main/OAuth2SponsoredProjectApiController.php

@@ -140,7 +140,7 @@ function getUpdateValidationRules(array $payload): array
      */
     protected function updateEntity($id, array $payload): IEntity
     {
-        return $this->service->update($id, HTMLCleaner::cleanData($payload, ['description']));
+        return $this->service->update(intval($id), HTMLCleaner::cleanData($payload, ['description']));
     }
 
     /**

app/Services/Model/Imp/SponsoredProjectService.php

@@ -118,6 +118,7 @@ public function add(array $payload): SponsoredProject
     public function update(int $project_id, array $payload): SponsoredProject
     {
         return $this->tx_service->transaction(function() use ($project_id, $payload){
+
             if(isset($payload['name'])) {
                 $name = trim($payload['name']);
                 $formerProject = $this->repository->getByName($name);
@@ -128,20 +129,30 @@ public function update(int $project_id, array $payload): SponsoredProject
 
             $sponsoredProject = $this->repository->getById($project_id);
 
-            if(is_null($sponsoredProject) || !$sponsoredProject instanceof SponsoredProject)
+            if(!$sponsoredProject instanceof SponsoredProject)
                 throw new EntityNotFoundException(sprintf("sponsored project %s not found.", $project_id));
 
             SponsoredProjectFactory::populate($sponsoredProject, $payload);
 
-            if(array_key_exists('parent_project_id', $payload) && is_null($payload['parent_project_id'])) {
-                $sponsoredProject->clearParentProject();
-            } else if(isset($payload['parent_project_id'])) {
-                $parentProject = $this->repository->getById(intval($payload['parent_project_id']));
-
-                if(is_null($parentProject) || !$parentProject instanceof SponsoredProject)
-                    throw new EntityNotFoundException(sprintf("sponsored project parent %s not found.", $project_id));
+            if(isset($payload['parent_project_id'])) {
 
-                $sponsoredProject->setParentProject($parentProject);
+                $parent_project_id = intval($payload['parent_project_id']);
+                $sponsoredProject->clearParentProject();
+                if($parent_project_id > 0) {
+                    $parentProject = $this->repository->getById(intval($payload['parent_project_id']));
+
+                    if (!$parentProject instanceof SponsoredProject)
+                        throw new EntityNotFoundException
+                        (
+                            sprintf
+                            (
+                                "sponsored project parent %s not found.",
+                                $parent_project_id
+                            )
+                        );
+
+                    $sponsoredProject->setParentProject($parentProject);
+                }
             }
 
             return $sponsoredProject;