Skip to content

Commit fc686ac

Browse files
committed
fix: serializer permissions level at promo code endpoints
Signed-off-by: smarcet@gmail.com <smarcet@gmail.com>
1 parent dd3dc73 commit fc686ac

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitPromoCodesApiController.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ function ($page, $per_page, $filter, $order, $applyExtraFilters) use ($summit) {
198198
call_user_func($applyExtraFilters, $filter),
199199
$order
200200
);
201-
}
201+
},
202+
['serializer_type' => SerializerRegistry::SerializerType_Private]
202203
);
203204
}
204205

@@ -282,7 +283,8 @@ function ($page, $per_page, $filter, $order, $applyExtraFilters) use ($summit) {
282283
call_user_func($applyExtraFilters, $filter),
283284
$order
284285
);
285-
}
286+
},
287+
[ 'serializer_type' => SerializerRegistry::SerializerType_Private ],
286288
);
287289
}
288290

@@ -387,7 +389,7 @@ function () {
387389
];
388390
},
389391
'promocodes-',
390-
[],
392+
[ 'serializer_type' => SerializerRegistry::SerializerType_Private ],
391393
function ($page, $per_page, $filter, $order, $applyExtraFilters) use ($summit) {
392394
return $this->repository->getBySummit
393395
(
@@ -396,7 +398,7 @@ function ($page, $per_page, $filter, $order, $applyExtraFilters) use ($summit) {
396398
call_user_func($applyExtraFilters, $filter),
397399
$order
398400
);
399-
}
401+
},
400402
);
401403
}
402404

@@ -488,7 +490,7 @@ function () {
488490
];
489491
},
490492
'sponsor-promocodes-',
491-
[],
493+
[ 'serializer_type' => SerializerRegistry::SerializerType_Private ],
492494
function ($page, $per_page, $filter, $order, $applyExtraFilters) use ($summit) {
493495
return $this->repository->getBySummit
494496
(

app/ModelSerializers/Summit/Registration/PromoCodes/SponsorSummitRegistrationDiscountCodeCSVSerializer.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
* limitations under the License.
1313
**/
1414

15+
use models\summit\SponsorSummitRegistrationDiscountCode;
16+
1517
/**
1618
* Class SponsorSummitRegistrationDiscountCodeCSVSerializer
1719
* @package ModelSerializers
@@ -31,7 +33,7 @@ class SponsorSummitRegistrationDiscountCodeCSVSerializer
3133
public function serialize($expand = null, array $fields = [], array $relations = [], array $params = [])
3234
{
3335
$code = $this->object;
34-
if(!$code instanceof SponsorSummitRegistrationDiscountCodeSerializer) return [];
36+
if(!$code instanceof SponsorSummitRegistrationDiscountCode) return [];
3537

3638
return self::serializeFields2CSV
3739
(

0 commit comments

Comments
 (0)