refactor(type): remove even more dynamic casts (x4)

SALTWOOD · SALTWOOD · commit d3dc8010fb01 · 2026-02-26T11:32:47.000+09:00
diff --git a/Plain Craft Launcher 2/Pages/PageLaunch/PageLoginProfile.xaml.cs b/Plain Craft Launcher 2/Pages/PageLaunch/PageLoginProfile.xaml.cs
@@ -90,7 +90,7 @@ private void SelectProfile(object sender, MouseButtonEventArgs e)
         ModProfile.SelectedProfile = (ModProfile.McProfile)((MyListItem)sender).Tag;
         ModBase.Log($"[Profile] 选定档案: {tag.Username}, 以 {tag.Type} 方式验证");
         ModProfile.LastUsedProfile =
-            ModProfile.ProfileList.IndexOf((ModProfile.McProfile)((dynamic)sender).Tag); // 获取当前档案的序号
+            ModProfile.ProfileList.IndexOf((ModProfile.McProfile)((MyListItem)sender).Tag); // 获取当前档案的序号
         ModProfile.SaveProfile(); // 保存档案配置，确保切换后的档案被正确保存
 
         // 清除登录验证缓存，确保使用新档案的验证信息
@@ -135,8 +135,7 @@ private void ProfileContMenuBuild(MyListItem sender, EventArgs e)
         ToolTipService.SetHorizontalOffset(btnDelete, 2d);
         btnDelete.Click += DeleteProfile;
         // 根据档案类型显示不同的菜单项
-        if (Conversions.ToBoolean(Operators.ConditionalCompareObjectEqual(((dynamic)sender.Tag).Type,
-                ModLaunch.McLoginType.Legacy, false)))
+        if (((ModProfile.McProfile)sender.Tag).Type == ModLaunch.McLoginType.Legacy)
             sender.Buttons = new[] { btnEditUuid, btnDelete };
         else
             sender.Buttons = new[] { btnCopyUuid, btnDelete };
@@ -155,12 +154,12 @@ private void BtnNew_Click(object sender, EventArgs e)
     // 编辑 UUID
     private void EditProfileUuid(object sender, EventArgs e)
     {
-        ModProfile.EditOfflineUuid((ModProfile.McProfile)((dynamic)sender).Tag);
+        ModProfile.EditOfflineUuid((ModProfile.McProfile)((MyIconButton)sender).Tag);
     }
 
     private void CopyProfileUuid(object sender, EventArgs e)
     {
-        ModBase.ClipboardSet(Conversions.ToString(((dynamic)sender).Tag.Uuid));
+        if (sender is MyIconButton { Tag: ModProfile.McProfile profile }) ModBase.ClipboardSet(profile.Uuid);
     }
 
     // 编辑验证服务器名称
diff --git a/Plain Craft Launcher 2/Pages/PageSelectLeft.xaml.cs b/Plain Craft Launcher 2/Pages/PageSelectLeft.xaml.cs
@@ -565,7 +565,7 @@ public void Remove_Click(object sender, RoutedEventArgs e)
     public void Delete_Click(object sender, RoutedEventArgs e)
     {
         var Folder =
-            (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((dynamic)sender).Parent).Parent).PlacementTarget)
+            (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((MyMenuItem)sender).Parent).Parent).PlacementTarget)
             .Tag;
         var DeleteText =
             (Folder.Type == ModMinecraft.McFolder.Types.Original ||
@@ -616,13 +616,13 @@ public void Delete_Click(object sender, RoutedEventArgs e)
 
     public void Open_Click(object sender, RoutedEventArgs e)
     {
-        ModBase.OpenExplorer(((MyListItem)((Popup)((ContextMenu)((dynamic)sender).Parent).Parent).PlacementTarget)
+        ModBase.OpenExplorer(((MyListItem)((Popup)((ContextMenu)((MyMenuItem)sender).Parent).Parent).PlacementTarget)
             .Info);
     }
 
     public void Refresh_Click(object sender, RoutedEventArgs e)
     {
-        var Data = (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((dynamic)sender).Parent).Parent)
+        var Data = (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((MyMenuItem)sender).Parent).Parent)
             .PlacementTarget).Tag;
         RefreshCurrent(Data.Location);
     }
diff --git a/Plain Craft Launcher 2/Pages/PageSetup/PageSetupLaunch.xaml b/Plain Craft Launcher 2/Pages/PageSetup/PageSetupLaunch.xaml
@@ -79,8 +79,7 @@
                                    Margin="0,0,25,0" />
                         <local:MyComboBox x:Name="ComboArgumentVisibie" Grid.Row="6" Grid.ColumnSpan="2"
                                           Tag="LaunchArgumentVisible" Grid.Column="1"
-                                          SizeChanged="ComboArgumentVisibie_SizeChanged"
-                                          SelectionChanged="ComboChange">
+                                          SelectionChanged="ComboArgumentVisibie_SelectionChanged">
                             <local:MyComboBoxItem Content="游戏启动后立即关闭" />
                             <local:MyComboBoxItem Content="" IsEnabled="False" Visibility="Collapsed" />
                             <local:MyComboBoxItem Content="游戏启动后隐藏，游戏退出后自动关闭" />
diff --git a/Plain Craft Launcher 2/Pages/PageSetup/PageSetupLaunch.xaml.cs b/Plain Craft Launcher 2/Pages/PageSetup/PageSetupLaunch.xaml.cs
@@ -514,8 +514,9 @@ private void WindowTypeUIRefresh()
     }
 
     // 可见性选择直接关闭的警告
-    private void ComboArgumentVisibie_SizeChanged(object sender, SizeChangedEventArgs sizeChangedEventArgs)
+    private void ComboArgumentVisibie_SelectionChanged(object sender, SelectionChangedEventArgs sizeChangedEventArgs)
     {
+        ComboChange(sender, sizeChangedEventArgs);
         if (ModAnimation.AniControlEnabled != 0)
             return;
         if (ComboArgumentVisibie.SelectedIndex == 0)
diff --git a/Plain Craft Launcher 2/Pages/PageSetup/PageSetupUI.xaml.cs b/Plain Craft Launcher 2/Pages/PageSetup/PageSetupUI.xaml.cs
@@ -876,11 +876,11 @@ public static void HiddenRefresh()
 
                 foreach (var category in categories)
                 {
-                    var isVisible = ((dynamic)category).Item2 || HiddenForceShow;
-                    ((dynamic)category).Item1.Visibility =
+                    var isVisible = category.Item2 || HiddenForceShow;
+                    category.Item1.Visibility =
                         Conversions.ToBoolean(isVisible) ? Visibility.Visible : Visibility.Collapsed;
                     if (Conversions.ToBoolean(isVisible))
-                        ((dynamic)category).Item1.Opacity = 0.6d;
+                        category.Item1.Opacity = 0.6d;
                 }
 
                 // 统计设置页可用项数量
diff --git a/Plain Craft Launcher 2/Pages/PageSpeedLeft.xaml.cs b/Plain Craft Launcher 2/Pages/PageSpeedLeft.xaml.cs
@@ -357,7 +357,7 @@ public void TaskRefresh(ModLoader.LoaderBase Loader)
                     Card.Children.Add(Cancel);
                     Cancel.Click += (sender, e) =>
                     {
-                        ModAnimation.AniDispose((dynamic)sender, false);
+                        ModAnimation.AniDispose((MyIconButton)sender, false);
                         ModAnimation.AniDispose(Card, true, _ =>
                         {
                             if (ModMain.FrmSpeedRight.PanMain.Children.Count == 0 &&
@@ -393,14 +393,15 @@ public void TaskRefresh(ModLoader.LoaderBase Loader)
 
     public void TaskRemove(object Loader)
     {
-        if (RightCards.ContainsKey(Conversions.ToString(((dynamic)Loader).Name)))
+        var loaderCombo = (ModLoader.LoaderCombo<string>)Loader;
+        if (RightCards.ContainsKey(Conversions.ToString(loaderCombo.Name)))
             ModBase.RunInUiWait(() =>
             {
                 // 移除已有的卡片
-                Grid Card = RightCards[Conversions.ToString(((dynamic)Loader).Name)];
+                Grid Card = RightCards[Conversions.ToString(loaderCombo.Name)];
                 ModMain.FrmSpeedRight.PanMain.Children.Remove(Card);
-                RightCards.Remove(Conversions.ToString(((dynamic)Loader).Name));
-                ModBase.Log($"[Watcher] 移除任务管理卡片：{((dynamic)Loader).Name}");
+                RightCards.Remove(Conversions.ToString(loaderCombo.Name));
+                ModBase.Log($"[Watcher] 移除任务管理卡片：{loaderCombo.Name}");
             });
     }
 
diff --git a/Plain Craft Launcher 2/Pages/PageTools/PageToolsHelp.xaml.cs b/Plain Craft Launcher 2/Pages/PageTools/PageToolsHelp.xaml.cs
@@ -238,7 +238,8 @@ private void PageOther_Loaded(object sender, RoutedEventArgs e)
     // 初始化加载器信息
     private void PageOther_Inited(object sender, EventArgs e)
     {
-        PageLoaderInit(Load, PanLoad, PanBack, null, ModMain.HelpLoader, a => this.HelpListLoad((dynamic)a));
+        PageLoaderInit(Load, PanLoad, PanBack, null, ModMain.HelpLoader,
+            a => this.HelpListLoad((ModLoader.LoaderTask<int, List<ModMain.HelpEntry>>)a));
     }
 
     #endregion
diff --git a/Plain Craft Launcher 2/Pages/PageTools/PageToolsLeft.xaml.cs b/Plain Craft Launcher 2/Pages/PageTools/PageToolsLeft.xaml.cs
@@ -34,9 +34,10 @@ private void PageOtherLeft_Unloaded(object sender, RoutedEventArgs e)
 
     public void Refresh(object sender, EventArgs e)
     {
-        if (((dynamic)sender).Tag is null)
+        var button = (MyIconButton)sender;
+        if (button.Tag is null)
             return;
-        double id = ModBase.Val(((MyIconButton)sender).Tag);
+        double id = ModBase.Val(button.Tag);
         switch (id)
         {
             case (double)FormMain.PageSubType.ToolsGameLink:

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ public void Remove_Click(object sender, RoutedEventArgs e)`
`565`	`565`	`public void Delete_Click(object sender, RoutedEventArgs e)`
`566`	`566`	`{`
`567`	`567`	`var Folder =`
`568`		`- (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((dynamic)sender).Parent).Parent).PlacementTarget)`
	`568`	`+ (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((MyMenuItem)sender).Parent).Parent).PlacementTarget)`
`569`	`569`	`.Tag;`
`570`	`570`	`var DeleteText =`
`571`	`571`	`(Folder.Type == ModMinecraft.McFolder.Types.Original \|\|`
`@@ -616,13 +616,13 @@ public void Delete_Click(object sender, RoutedEventArgs e)`
`616`	`616`
`617`	`617`	`public void Open_Click(object sender, RoutedEventArgs e)`
`618`	`618`	`{`
`619`		`- ModBase.OpenExplorer(((MyListItem)((Popup)((ContextMenu)((dynamic)sender).Parent).Parent).PlacementTarget)`
	`619`	`+ ModBase.OpenExplorer(((MyListItem)((Popup)((ContextMenu)((MyMenuItem)sender).Parent).Parent).PlacementTarget)`
`620`	`620`	`.Info);`
`621`	`621`	`}`
`622`	`622`
`623`	`623`	`public void Refresh_Click(object sender, RoutedEventArgs e)`
`624`	`624`	`{`
`625`		`- var Data = (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((dynamic)sender).Parent).Parent)`
	`625`	`+ var Data = (ModMinecraft.McFolder)((MyListItem)((Popup)((ContextMenu)((MyMenuItem)sender).Parent).Parent)`
`626`	`626`	`.PlacementTarget).Tag;`
`627`	`627`	`RefreshCurrent(Data.Location);`
`628`	`628`	`}`
Original file line number	Diff line number	Diff line change
`@@ -514,8 +514,9 @@ private void WindowTypeUIRefresh()`
`514`	`514`	`}`
`515`	`515`
`516`	`516`	`// 可见性选择直接关闭的警告`
`517`		`- private void ComboArgumentVisibie_SizeChanged(object sender, SizeChangedEventArgs sizeChangedEventArgs)`
	`517`	`+ private void ComboArgumentVisibie_SelectionChanged(object sender, SelectionChangedEventArgs sizeChangedEventArgs)`
`518`	`518`	`{`
	`519`	`+ ComboChange(sender, sizeChangedEventArgs);`
`519`	`520`	`if (ModAnimation.AniControlEnabled != 0)`
`520`	`521`	`return;`
`521`	`522`	`if (ComboArgumentVisibie.SelectedIndex == 0)`
Original file line number	Diff line number	Diff line change
`@@ -876,11 +876,11 @@ public static void HiddenRefresh()`
`876`	`876`
`877`	`877`	`foreach (var category in categories)`
`878`	`878`	`{`
`879`		`- var isVisible = ((dynamic)category).Item2 \|\| HiddenForceShow;`
`880`		`- ((dynamic)category).Item1.Visibility =`
	`879`	`+ var isVisible = category.Item2 \|\| HiddenForceShow;`
	`880`	`+ category.Item1.Visibility =`
`881`	`881`	`Conversions.ToBoolean(isVisible) ? Visibility.Visible : Visibility.Collapsed;`
`882`	`882`	`if (Conversions.ToBoolean(isVisible))`
`883`		`- ((dynamic)category).Item1.Opacity = 0.6d;`
	`883`	`+ category.Item1.Opacity = 0.6d;`
`884`	`884`	`}`
`885`	`885`
`886`	`886`	`// 统计设置页可用项数量`
Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ public void TaskRefresh(ModLoader.LoaderBase Loader)`
`357`	`357`	`Card.Children.Add(Cancel);`
`358`	`358`	`Cancel.Click += (sender, e) =>`
`359`	`359`	`{`
`360`		`- ModAnimation.AniDispose((dynamic)sender, false);`
	`360`	`+ ModAnimation.AniDispose((MyIconButton)sender, false);`
`361`	`361`	`ModAnimation.AniDispose(Card, true, _ =>`
`362`	`362`	`{`
`363`	`363`	`if (ModMain.FrmSpeedRight.PanMain.Children.Count == 0 &&`
`@@ -393,14 +393,15 @@ public void TaskRefresh(ModLoader.LoaderBase Loader)`
`393`	`393`
`394`	`394`	`public void TaskRemove(object Loader)`
`395`	`395`	`{`
`396`		`- if (RightCards.ContainsKey(Conversions.ToString(((dynamic)Loader).Name)))`
	`396`	`+ var loaderCombo = (ModLoader.LoaderCombo<string>)Loader;`
	`397`	`+ if (RightCards.ContainsKey(Conversions.ToString(loaderCombo.Name)))`
`397`	`398`	`ModBase.RunInUiWait(() =>`
`398`	`399`	`{`
`399`	`400`	`// 移除已有的卡片`
`400`		`- Grid Card = RightCards[Conversions.ToString(((dynamic)Loader).Name)];`
	`401`	`+ Grid Card = RightCards[Conversions.ToString(loaderCombo.Name)];`
`401`	`402`	`ModMain.FrmSpeedRight.PanMain.Children.Remove(Card);`
`402`		`- RightCards.Remove(Conversions.ToString(((dynamic)Loader).Name));`
`403`		`- ModBase.Log($"[Watcher] 移除任务管理卡片：{((dynamic)Loader).Name}");`
	`403`	`+ RightCards.Remove(Conversions.ToString(loaderCombo.Name));`
	`404`	`+ ModBase.Log($"[Watcher] 移除任务管理卡片：{loaderCombo.Name}");`
`404`	`405`	`});`
`405`	`406`	`}`
`406`	`407`
Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,8 @@ private void PageOther_Loaded(object sender, RoutedEventArgs e)`
`238`	`238`	`// 初始化加载器信息`
`239`	`239`	`private void PageOther_Inited(object sender, EventArgs e)`
`240`	`240`	`{`
`241`		`- PageLoaderInit(Load, PanLoad, PanBack, null, ModMain.HelpLoader, a => this.HelpListLoad((dynamic)a));`
	`241`	`+ PageLoaderInit(Load, PanLoad, PanBack, null, ModMain.HelpLoader,`
	`242`	`+ a => this.HelpListLoad((ModLoader.LoaderTask<int, List<ModMain.HelpEntry>>)a));`
`242`	`243`	`}`
`243`	`244`
`244`	`245`	`#endregion`
Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,10 @@ private void PageOtherLeft_Unloaded(object sender, RoutedEventArgs e)`
`34`	`34`
`35`	`35`	`public void Refresh(object sender, EventArgs e)`
`36`	`36`	`{`
`37`		`- if (((dynamic)sender).Tag is null)`
	`37`	`+ var button = (MyIconButton)sender;`
	`38`	`+ if (button.Tag is null)`
`38`	`39`	`return;`
`39`		`- double id = ModBase.Val(((MyIconButton)sender).Tag);`
	`40`	`+ double id = ModBase.Val(button.Tag);`
`40`	`41`	`switch (id)`
`41`	`42`	`{`
`42`	`43`	`case (double)FormMain.PageSubType.ToolsGameLink:`