Check for duplicates
Description
When a block or workspace comment (or other ICopyable thing) is cut or pasted, several events are fired at once:
for cut
- Selected (old: block id, new: null)
- Delete block or delete comment
for paste, or duplicate context menu option
- selected (old: whatever was previously selected, new: id of pasted thing)
- Create block or create comment
These two events should be grouped since they are part of the same user action. They are only grouped for the case of cutting a block specifically, because the cut callback calls a block's checkAndDelete method which handles event grouping. For the case of cutting other non-block types, or pasting anything including blocks, or using the duplicate context menu item, there is no group id set on the events fired in those cases.
Reproduction steps
- Enable event logging in the playground
- Cut a block with ctrl+x and notice the events fired have a group id
- Cut a workspace comment with ctrl-x and notice they don't
Stack trace
Screenshots
No response
Browsers
No response
Check for duplicates
Description
When a block or workspace comment (or other
ICopyablething) is cut or pasted, several events are fired at once:for cut
for paste, or duplicate context menu option
These two events should be grouped since they are part of the same user action. They are only grouped for the case of cutting a block specifically, because the cut callback calls a block's
checkAndDeletemethod which handles event grouping. For the case of cutting other non-block types, or pasting anything including blocks, or using the duplicate context menu item, there is no group id set on the events fired in those cases.Reproduction steps
Stack trace
Screenshots
No response
Browsers
No response