Avoid warning of potential false positive in API Client tests. (#675)

I was seeing warnings that `expect {}.not_to
raise_error(Faraday::Error)` was risking any other error causing the
test to pass. These test warnings are new (probably introduced in #666).

I think in this particular case it's a deliberate decision to test that
this one error is NOT generated for this one particular status code, so
I rewrote the test to avoid the warning but keep the intent of the test.

## What's changed?

- Rewrote the `does not raise faraday exception for 401` test to expect
an error but assert that it not be a `Faraday::Error`.

## Steps to perform after deploying to production

None. Test change only.

Author: fspeirs

spec/support/shared_examples/profile_api_client_examples.rb

@@ -54,7 +54,9 @@
 
   it 'does not raise faraday exception for 401' do
     stub_request(http_method, expected_url).to_return(status: 401)
-    expect { subject }.not_to raise_error(Faraday::Error)
+    expect { subject }.to raise_error { |error|
+      expect(error).not_to be_a(Faraday::Error)
+    }
   end
 
   it 'raises UnauthorizedError on 401' do