Merge branch 'master' into mac-single-buil

Author: RobLoach

.clang-format

@@ -0,0 +1,22 @@
+BasedOnStyle: LLVM
+IndentWidth: 2
+UseTab: Never
+ColumnLimit: 0
+BinPackArguments: false
+BinPackParameters: false
+AllowAllArgumentsOnNextLine: false
+AllowAllParametersOfDeclarationOnNextLine: false
+AlwaysBreakAfterReturnType: None
+PenaltyBreakAssignment: 100000000
+PenaltyBreakBeforeFirstCallParameter: 100000000
+PenaltyBreakComment: 100000000
+PenaltyBreakFirstLessLess: 100000000
+PenaltyBreakString: 100000000
+PenaltyExcessCharacter: 100000000
+PenaltyReturnTypeOnItsOwnLine: 100000000
+PenaltyIndentedWhitespace: 100000000
+ContinuationIndentWidth: 2
+AlignAfterOpenBracket: DontAlign
+AlignOperands: false
+BreakBeforeBinaryOperators: None
+BreakBeforeTernaryOperators: false

.github/workflows/release.yml

@@ -3,7 +3,7 @@ name: Release
 on:
   push:
     tags:
-      - 'v*'
+      - "v*"
 jobs:
   create_release:
     runs-on: ubuntu-latest

.github/workflows/test.yml

@@ -3,6 +3,18 @@ name: Test
 on: [push]
 
 jobs:
+  style:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - uses: actions/setup-node@v2
+      - name: Code Style Check
+        run: npx -y prettier -c .
+        # run: npx @biomejs/biome format . # do this after we move to biome config
+      
   build:
     strategy:
       fail-fast: false
@@ -68,4 +80,4 @@ jobs:
           path: ./node_modules
           key: modules-${{ hashFiles('package-lock.json') }}
       - name: Build for arm
-        run: docker run --platform linux/arm --rm -v "${PWD}:/work" -w /work node ./tools/crossbuild-drm.sh
+        run: docker run --platform linux/arm --rm -v "${PWD}:/work" -w /work node ./tools/crossbuild-drm.sh

.prettierrc

@@ -0,0 +1,21 @@
+{
+  "arrowParens": "always",
+  "bracketSameLine": false,
+  "bracketSpacing": true,
+  "embeddedLanguageFormatting": "auto",
+  "endOfLine": "lf",
+  "htmlWhitespaceSensitivity": "css",
+  "insertPragma": false,
+  "jsxSingleQuote": true,
+  "printWidth": 9999,
+  "proseWrap": "preserve",
+  "quoteProps": "as-needed",
+  "requirePragma": false,
+  "semi": false,
+  "singleAttributePerLine": false,
+  "singleQuote": true,
+  "tabWidth": 2,
+  "trailingComma": "none",
+  "useTabs": false,
+  "vueIndentScriptAndStyle": false
+}

CMakeLists.txt

@@ -1,6 +1,7 @@
 include(FetchContent)
 
-cmake_minimum_required(VERSION 3.11)
+# 2025-02-15: based on https://github.com/raysan5/raylib/blob/master/src/external/glfw/CMakeLists.txt, make sure the CMake version are between 3.4 and 3.28 or the whole raylib lib will face fatal errors
+cmake_minimum_required(VERSION 3.4...3.28 FATAL_ERROR)
 project (node-raylib
   VERSION 0.10.0
   DESCRIPTION "Node.js bindings for raylib"
@@ -11,36 +12,38 @@ if ( CMAKE_COMPILER_IS_GNUCC )
     set(CMAKE_C_FLAGS "-fPIC ${CMAKE_C_FLAGS} -Wno-unused-result")
     set(CMAKE_CXX_FLAGS "-Wall -Wextra")
 endif()
+# 2025-02-15: based on @link: https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-170. MSVC only accept O2 and don't have O3 optimization flag
 if ( MSVC )
     set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} /w")
+    set(CMAKE_CXX_FLAGS_RELEASE "-O2")
+else()
+    set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 endif()
 
 if(NOT CMAKE_BUILD_TYPE)
   set(CMAKE_BUILD_TYPE Release)
 endif()
 
 set(CMAKE_CXX_FLAGS_DEBUG "-g")
-set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 
 # single build for both Mac arches
 set(CMAKE_OSX_ARCHITECTURES arm64 x86_64)
 
 # version doesn't seem to pick correct version
-#find_package(raylib 4.5 QUIET EXACT)
+#find_package(raylib 5.5 QUIET EXACT)
 if (NOT raylib_FOUND)
   include(FetchContent)
   FetchContent_Declare(
     raylib
     GIT_REPOSITORY https://github.com/raysan5/raylib.git
-    GIT_TAG 4.5.0
+    GIT_TAG 5.5
     GIT_SHALLOW TRUE
   )
   FetchContent_GetProperties(raylib)
   if (NOT raylib_POPULATED)
     set(FETCHCONTENT_QUIET NO)
-    FetchContent_Populate(raylib)
+    FetchContent_MakeAvailable(raylib)
     set(BUILD_EXAMPLES OFF CACHE BOOL "" FORCE)
-    add_subdirectory(${raylib_SOURCE_DIR} ${raylib_BINARY_DIR})
   endif()
 endif()
 
@@ -78,7 +81,7 @@ set_target_properties(${PROJECT_NAME} PROPERTIES
   SUFFIX ".node"
 )
 
-target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_11)
+target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_20)
 
 target_include_directories(${PROJECT_NAME} PUBLIC
   "${CMAKE_JS_INC}"

README.md

@@ -1,6 +1,6 @@
 ![node-raylib Logo](logo/raylib-node_256x256.png)
 
-# node-raylib [![npm version](http://img.shields.io/npm/v/raylib.svg)](https://npmjs.org/package/raylib "View this project on npm") [![Tests](https://github.com/RobLoach/node-raylib/workflows/Tests/badge.svg)](https://github.com/RobLoach/node-raylib/actions?query=workflow%3ATests+branch%3Amaster "See automated test status on GitHub Actions")
+# node-raylib [![npm version](http://img.shields.io/npm/v/raylib.svg)](https://npmjs.org/package/raylib "View this project on npm") [![Tests](https://github.com/RobLoach/node-raylib/actions/workflows/test.yml/badge.svg)](https://github.com/RobLoach/node-raylib/actions/workflows/test.yml "See automated test status on GitHub Actions")
 
 [Node.js](https://nodejs.org) bindings for [raylib](https://www.raylib.com/), a simple and easy-to-use library to enjoy videogames programming (www.raylib.com).