Use realtime sanitizer to check against malloc and similar#885
Draft
inkreasing wants to merge 2 commits into
Draft
Use realtime sanitizer to check against malloc and similar#885inkreasing wants to merge 2 commits into
inkreasing wants to merge 2 commits into
Conversation
Member
|
This is cool. We’ve got ASAN and TSAN set up in cpal too. Using it as a pipe cleaner for realtime allocations is useful too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests that use the llvm realtime sanitizer. It checks known blocking libc calls. If you do a endless loop, it won't catch it.
I use the supertrait_item_shadowing thing to overwrite the Iterator::next method, so that it gets sanitized. This should be correct, as that is all audio code. That way it also applies to user written code. It leads to errors if both Source and Iterator are imported, but this is only for tests.
This is currently broken because
It could/should get extended by
also still need to figure out if it is better to do it with the cargo feature (like it is currently) or use a env-var with a tiny build script. This has the big advantage, that user crates don't have to pass the feature upwards and can just set the env var.
@yara-blue