Skip to content

[Refactor] Simplify normalizeDelimitedString#7565

Open
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-refactor-simplify-normalizedelimitedstring-14687650256661895799
Open

[Refactor] Simplify normalizeDelimitedString#7565
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-refactor-simplify-normalizedelimitedstring-14687650256661895799

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The current implementation of normalizeDelimitedString is imperative and uses several intermediate variables. It also manually implements deduplication instead of using the existing uniq utility helper.

WHAT is this pull request doing?

Refactors normalizeDelimitedString in packages/cli-kit/src/public/common/string.ts to use a declarative chaining approach and the uniq utility from common/array.ts.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 14687650256661895799 started by @gonzaloriestra

Refactor normalizeDelimitedString to use a declarative pipeline and the uniq helper.
This improves readability and consistency with other collection-handling code in the repository.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 17, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 18, 2026 11:45
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 18, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant