Merge pull request #521 from UiPath/fix/decouple_runtime_otel

fix: decouple runtime from tracing

Author: cristipufu

src/uipath/_cli/_runtime/_runtime.py

@@ -8,13 +8,8 @@
 from dataclasses import asdict, is_dataclass
 from typing import Any, Dict, Optional, Type, TypeVar, cast, get_type_hints
 
-from opentelemetry import trace
-from opentelemetry.sdk.trace import TracerProvider
-from opentelemetry.sdk.trace.export import BatchSpanProcessor
 from pydantic import BaseModel
 
-from uipath.tracing import LlmOpsHttpExporter
-
 from ._contracts import (
     UiPathBaseRuntime,
     UiPathErrorCategory,
@@ -43,11 +38,6 @@ async def execute(self) -> Optional[UiPathRuntimeResult]:
         await self.validate()
 
         try:
-            trace.set_tracer_provider(TracerProvider())
-            trace.get_tracer_provider().add_span_processor(  # type: ignore
-                BatchSpanProcessor(LlmOpsHttpExporter())
-            )
-
             if self.context.entrypoint is None:
                 return None
 
@@ -74,8 +64,6 @@ async def execute(self) -> Optional[UiPathRuntimeResult]:
                 f"Error: {str(e)}",
                 UiPathErrorCategory.SYSTEM,
             ) from e
-        finally:
-            trace.get_tracer_provider().shutdown()  # type: ignore
 
     async def validate(self) -> None:
         """Validate runtime inputs."""

src/uipath/_cli/cli_run.py

@@ -10,6 +10,7 @@
 from dotenv import load_dotenv
 
 from uipath._cli._utils._debug import setup_debugging
+from uipath.tracing import LlmOpsHttpExporter
 
 from .._utils.constants import (
     ENV_JOB_ID,
@@ -18,6 +19,7 @@
 from ._runtime._contracts import (
     UiPathRuntimeContext,
     UiPathRuntimeError,
+    UiPathRuntimeFactory,
     UiPathTraceContext,
 )
 from ._runtime._runtime import UiPathRuntime
@@ -61,39 +63,42 @@ def python_run_middleware(
         )
 
     try:
+        context = UiPathRuntimeContext.from_config(
+            env.get("UIPATH_CONFIG_PATH", "uipath.json"), **kwargs
+        )
+        context.entrypoint = entrypoint
+        context.input = input
+        context.resume = resume
+        context.job_id = env.get("UIPATH_JOB_KEY")
+        context.trace_id = env.get("UIPATH_TRACE_ID")
+        context.input_file = kwargs.get("input_file", None)
+        context.execution_output_file = kwargs.get("execution_output_file", None)
+        context.is_eval_run = kwargs.get("is_eval_run", False)
+        context.logs_min_level = env.get("LOG_LEVEL", "INFO")
+        context.tracing_enabled = env.get("UIPATH_TRACING_ENABLED", True)
+        context.trace_context = UiPathTraceContext(
+            trace_id=env.get("UIPATH_TRACE_ID"),
+            parent_span_id=env.get("UIPATH_PARENT_SPAN_ID"),
+            root_span_id=env.get("UIPATH_ROOT_SPAN_ID"),
+            enabled=env.get("UIPATH_TRACING_ENABLED", True),
+            job_id=env.get("UIPATH_JOB_KEY"),
+            org_id=env.get("UIPATH_ORGANIZATION_ID"),
+            tenant_id=env.get("UIPATH_TENANT_ID"),
+            process_key=env.get("UIPATH_PROCESS_UUID"),
+            folder_key=env.get("UIPATH_FOLDER_KEY"),
+            reference_id=env.get("UIPATH_JOB_KEY") or str(uuid4()),
+        )
+
+        runtime_factory = UiPathRuntimeFactory(UiPathRuntime, UiPathRuntimeContext)
+
+        if context.job_id:
+            runtime_factory.add_span_exporter(LlmOpsHttpExporter())
 
         async def execute():
-            context = UiPathRuntimeContext.from_config(
-                env.get("UIPATH_CONFIG_PATH", "uipath.json"), **kwargs
-            )
-            context.entrypoint = entrypoint
-            context.input = input
-            context.resume = resume
-            context.job_id = env.get("UIPATH_JOB_KEY")
-            context.trace_id = env.get("UIPATH_TRACE_ID")
-            context.input_file = kwargs.get("input_file", None)
-            context.execution_output_file = kwargs.get("execution_output_file", None)
-            context.is_eval_run = kwargs.get("is_eval_run", False)
-            context.tracing_enabled = env.get("UIPATH_TRACING_ENABLED", True)
-            context.trace_context = UiPathTraceContext(
-                trace_id=env.get("UIPATH_TRACE_ID"),
-                parent_span_id=env.get("UIPATH_PARENT_SPAN_ID"),
-                root_span_id=env.get("UIPATH_ROOT_SPAN_ID"),
-                enabled=env.get("UIPATH_TRACING_ENABLED", True),
-                job_id=env.get("UIPATH_JOB_KEY"),
-                org_id=env.get("UIPATH_ORGANIZATION_ID"),
-                tenant_id=env.get("UIPATH_TENANT_ID"),
-                process_key=env.get("UIPATH_PROCESS_UUID"),
-                folder_key=env.get("UIPATH_FOLDER_KEY"),
-                reference_id=env.get("UIPATH_JOB_KEY") or str(uuid4()),
-            )
-            context.logs_min_level = env.get("LOG_LEVEL", "INFO")
-            async with UiPathRuntime.from_context(context) as runtime:
-                await runtime.execute()
+            await runtime_factory.execute(context)
 
         asyncio.run(execute())
 
-        # Return success
         return MiddlewareResult(should_continue=False)
 
     except UiPathRuntimeError as e: