Skip to content

feat: add models-list command#1474

Open
GabrielVasilescu04 wants to merge 1 commit intomainfrom
feature/add-list-models-command
Open

feat: add models-list command#1474
GabrielVasilescu04 wants to merge 1 commit intomainfrom
feature/add-list-models-command

Conversation

@GabrielVasilescu04
Copy link
Copy Markdown
Contributor

@GabrielVasilescu04 GabrielVasilescu04 commented Mar 20, 2026 •
edited by github-actions Bot
Loading

Development Packages

uipath

[project]
dependencies = [
  # Exact version:
  "uipath==2.10.54.dev1014746196",

  # Any version from PR
  "uipath>=2.10.54.dev1014740000,<2.10.54.dev1014750000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath = { index = "testpypi" }

@GabrielVasilescu04 GabrielVasilescu04 self-assigned this Mar 20, 2026
@github-actions github-actions Bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Mar 20, 2026
ionmincu
ionmincu reviewed Mar 20, 2026
View reviewed changes
Comment thread packages/uipath/src/uipath/_cli/cli_list_models.py Outdated
from ._utils._service_base import ServiceCommandBase, service_command


@click.command(name="list-models")
Copy link
Copy Markdown
Contributor

@ionmincu ionmincu Mar 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also add a testcase for this 😄 , or alter an existing one to also run this cli command

radu-mocanu
radu-mocanu reviewed Mar 22, 2026
View reviewed changes
Comment thread packages/uipath/src/uipath/_cli/__init__.py Outdated
"debug": "cli_debug",
"assets": "services.cli_assets",
"buckets": "services.cli_buckets",
"list-models": "cli_list_models",
Copy link
Copy Markdown
Collaborator

@radu-mocanu radu-mocanu Mar 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"list-models": "cli_list_models",
"list models": "cli_list_models",

we should follow a standard format for CLI commands

list models
list buckets 
list assets 
etc.

Copy link
Copy Markdown
Collaborator

@radu-mocanu radu-mocanu Mar 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a generic cli_list, similar to cli_add and match by resource type

@GabrielVasilescu04 GabrielVasilescu04 force-pushed the feature/add-list-models-command branch 2 times, most recently from 2a7d376 to d31ab37 Compare April 23, 2026 10:11
@GabrielVasilescu04 GabrielVasilescu04 added the build:dev Create a dev build from the pr label Apr 23, 2026
@GabrielVasilescu04 GabrielVasilescu04 force-pushed the feature/add-list-models-command branch from d31ab37 to 57df1bf Compare April 23, 2026 11:39
@GabrielVasilescu04 GabrielVasilescu04 force-pushed the feature/add-list-models-command branch from 57df1bf to e9f63eb Compare April 23, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ionmincu ionmincu Awaiting requested review from ionmincu

@radu-mocanu radu-mocanu Awaiting requested review from radu-mocanu

At least 1 approving review is required to merge this pull request.

Assignees

@GabrielVasilescu04 GabrielVasilescu04

Labels

build:dev Create a dev build from the pr test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GabrielVasilescu04 @ionmincu @radu-mocanu