Commit d54fed2
authored
fix(signal-tracker): firefox and chromium loop over different stack traces (@Leonabcd123) (monkeytypegame#7754)
### Description
First signal's first frame in `frames` array in
https://github.com/monkeytypegame/monkeytype/blob/82bf09564c2fdaaeb8273c638ec1eb7e7e6eb3cb/frontend/src/ts/dev/signal-tracker.ts#L35
Chromium:
`at getCallerInfo
(http://localhost:3000/ts/dev/signal-tracker.ts?t=1774961577350:5:16)`
Firefox:
`DEV.hooks.afterRegisterGraph@http://localhost:3000/ts/dev/signal-tracker.ts?t=1774961577350:84:34`
They both should be referring to `getCallerInfo`, but only chromium
does, because firefox slices off that frame in the code linked above,
while chromium slices off the string "Error".
Doesn't really matter because the `getCallerInfo` frame will be skipped
anyways, but this should still be done to make behavior more consistent
across different browsers.1 parent e8f8bf8 commit d54fed2
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
230 | | - | |
| 230 | + | |
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
| |||
0 commit comments