clean up warnings

Author: joelhawksley

.github/workflows/ci.yml

@@ -58,7 +58,6 @@ jobs:
         bundle exec appraisal rails-${{ matrix.rails_version }} bundle --quiet
         MEASURE_COVERAGE=true bundle exec appraisal rails-${{ matrix.rails_version }} rake all_tests
       env:
-        RAISE_ON_WARNING: 1
         RAILS_VERSION: ${{ matrix.rails_version }}
         RUBY_VERSION: ${{ matrix.ruby_version }}
     - name: Upload coverage results

spec/spec_helper.rb

@@ -6,6 +6,18 @@
 
 require "bundler/setup"
 
+module Warning
+  PROJECT_ROOT = File.expand_path("..", __dir__).freeze
+
+  def self.warn(message)
+    called_by = caller_locations(1, 1).first.path
+    return super unless called_by&.start_with?(PROJECT_ROOT) && !called_by.start_with?("#{PROJECT_ROOT}/vendor")
+    return if message.include?("Template format for")
+
+    raise "Warning: #{message}"
+  end
+end
+
 # Configure Rails Environment
 ENV["RAILS_ENV"] = "test"
 

test/test_helper.rb

@@ -7,17 +7,15 @@
 require "minitest/autorun"
 require "minitest/mock"
 
-if ENV["RAISE_ON_WARNING"]
-  module Warning
-    PROJECT_ROOT = File.expand_path("..", __dir__).freeze
+module Warning
+  PROJECT_ROOT = File.expand_path("..", __dir__).freeze
 
-    def self.warn(message)
-      called_by = caller_locations(1, 1).first.path
-      return super unless called_by&.start_with?(PROJECT_ROOT) && !called_by.start_with?("#{PROJECT_ROOT}/vendor")
-      return super if message.include?("Template format for")
+  def self.warn(message)
+    called_by = caller_locations(1, 1).first.path
+    return super unless called_by&.start_with?(PROJECT_ROOT) && !called_by.start_with?("#{PROJECT_ROOT}/vendor")
+    return if message.include?("Template format for")
 
-      raise "Warning: #{message}"
-    end
+    raise "Warning: #{message}"
   end
 end