Skip to content

Commit 359a365

Browse files
🐛 removed dot in configmap key
1 parent adcd452 commit 359a365

4 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/actions/helm-deploy/action.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ inputs:
2525
required: true
2626
default: 'backend'
2727
helm_set_files:
28-
description: 'Comma-separated --set-file args, e.g. "configMapData.download\.sh=scripts/download.sh"'
28+
description: 'Comma-separated --set-file args, e.g. "configMapData.download=scripts/download.sh"'
2929
required: false
3030
default: ''
3131
github_token:
@@ -101,7 +101,8 @@ runs:
101101
if [ -n "${{ inputs.helm_set_files }}" ]; then
102102
IFS=',' read -ra PAIRS <<< "${{ inputs.helm_set_files }}"
103103
for pair in "${PAIRS[@]}"; do
104-
pair=$(echo "$pair" | xargs)
104+
pair="${pair#"${pair%%[![:space:]]*}"}"
105+
pair="${pair%"${pair##*[![:space:]]}"}"
105106
[ -n "$pair" ] && SET_FILE_FLAGS="$SET_FILE_FLAGS --set-file $pair"
106107
done
107108
fi

.github/workflows/cd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,6 @@ jobs:
8383
helm_values_env: ${{ secrets.HELM_VALUES_ENV }}
8484
helm_values_persistence_hostpath: ${{ secrets.HELM_VALUES_PERSISTENCE_HOSTPATH }}
8585
helm_values_persistence_nodename: ${{ secrets.HELM_VALUES_PERSISTENCE_NODENAME }}
86-
helm_set_files: 'configMapData.download\.sh=scripts/download.sh'
86+
helm_set_files: 'configMapData.download=scripts/download.sh'
8787
namespace: ${{ env.NAMESPACE }}
8888
github_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ jobs:
2929
helm_values_env: ${{ secrets.HELM_VALUES_ENV }}
3030
helm_values_persistence_hostpath: ${{ secrets.HELM_VALUES_PERSISTENCE_HOSTPATH }}
3131
helm_values_persistence_nodename: ${{ secrets.HELM_VALUES_PERSISTENCE_NODENAME }}
32-
helm_set_files: 'configMapData.download\.sh=scripts/download.sh'
32+
helm_set_files: 'configMapData.download=scripts/download.sh'
3333
namespace: ${{ env.NAMESPACE }}
3434
github_token: ${{ secrets.GITHUB_TOKEN }}

deploy/helm/values.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ probes:
128128
successThreshold: 1
129129
failureThreshold: 5
130130

131-
# Content is injected at deploy time via: --set-file "configMapData.download\.sh=scripts/download.sh"
131+
# Content is injected at deploy time via: --set-file configMapData.download=scripts/download.sh
132132
configMapData: {}
133133

134134
# Volumes and volumeMounts rendered via tpl so template expressions work.
@@ -140,6 +140,9 @@ volumes:
140140
configMap:
141141
name: '{{ include "slm-server.fullname" . }}-scripts'
142142
defaultMode: 0755
143+
items:
144+
- key: download
145+
path: download.sh
143146

144147
volumeMounts:
145148
- name: models-storage

0 commit comments

Comments
 (0)