Skip to content

Commit cf5c56d

Browse files
author
maruthan
committed
fix(@angular/build): preserve error stack traces during prerendering
Reorder the nullish coalescing chain from `err.message ?? err.stack` to `err.stack ?? err.message` so that the full stack trace is preserved when available. Since `err.message` is almost always defined on Error objects, the previous order meant `err.stack` was never reached. Fixes #32503
1 parent f1ed025 commit cf5c56d

File tree

1 file changed

+3
-3
lines changed
  • packages/angular/build/src/utils/server-rendering

1 file changed

+3
-3
lines changed

packages/angular/build/src/utils/server-rendering/prerender.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export async function prerenderPages(
117117
outputMode,
118118
).catch((err) => {
119119
return {
120-
errors: [`An error occurred while extracting routes.\n\n${err.message ?? err.stack ?? err}`],
120+
errors: [`An error occurred while extracting routes.\n\n${err.stack ?? err.message ?? err}`],
121121
serializedRouteTree: [],
122122
appShellRoute: undefined,
123123
};
@@ -266,7 +266,7 @@ async function renderPages(
266266
})
267267
.catch((err) => {
268268
errors.push(
269-
`An error occurred while prerendering route '${route}'.\n\n${err.message ?? err.stack ?? err.code ?? err}`,
269+
`An error occurred while prerendering route '${route}'.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
270270
);
271271
void renderWorker.destroy();
272272
});
@@ -371,7 +371,7 @@ async function getAllRoutes(
371371

372372
return {
373373
errors: [
374-
`An error occurred while extracting routes.\n\n${err.message ?? err.stack ?? err.code ?? err}`,
374+
`An error occurred while extracting routes.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
375375
],
376376
serializedRouteTree: [],
377377
};

0 commit comments

Comments
 (0)