refactor(@angular-devkit/architect): use custom indent logger #33152
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the use of createConsoleLogger with logging.IndentLogger in both the architect and schematics CLIs. The logging logic is now manually handled via subscriptions, allowing for more direct control over output streams and styling. Additionally, the schematics CLI tests were updated to use PassThrough streams and stripVTControlCharacters for more robust output verification. I have no feedback to provide.
clydin
force-pushed
the
refactor/custom-logging
branch
3 times, most recently
from
ae361e7 to
4334bd3
Compare
Replaces `createConsoleLogger` with a custom `logging.IndentLogger` implementation to remove dependency on `@angular-devkit/core/node` helper.
…d improve tests Replaces `createConsoleLogger` with a custom `logging.IndentLogger` implementation that respects custom output streams. Also refactors tests to use standard `PassThrough` streams and `stripVTControlCharacters` instead of custom mocks.
alan-agius4
force-pushed
the
refactor/custom-logging
branch
from
4334bd3 to
cd08f7d
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Replaces
createConsoleLoggerwith a customlogging.IndentLoggerimplementation to remove dependency on@angular-devkit/core/nodehelper.