chore: fix linter and mypy errors in replace API and tests

- Fixed positional argument type mismatch for `snapshot_properties` in [_RewriteFiles](iceberg-python/pyiceberg/table/update/snapshot.py)
- Added missing `Catalog` type annotations to pytest fixtures in [test_replace.py](iceberg-python/tests/table/test_replace.py)
- Added strict `is not None` assertions for `table.current_snapshot()` to satisfy mypy Optional checking
- Auto-formatted tests with ruff

Author: qzyu999

pyiceberg/table/update/snapshot.py

@@ -666,11 +666,12 @@ def _get_entries(manifest: ManifestFile) -> list[ManifestEntry]:
         else:
             return []
 
+
 class _RewriteFiles(_SnapshotProducer["_RewriteFiles"]):
     """A snapshot producer that rewrites data files."""
 
     def __init__(self, operation: Operation, transaction: Transaction, io: FileIO, snapshot_properties: dict[str, str]):
-        super().__init__(operation, transaction, io, snapshot_properties)
+        super().__init__(operation, transaction, io, snapshot_properties=snapshot_properties)
 
     def _commit(self) -> UpdatesAndRequirements:
         # Only produce a commit when there is something to rewrite
@@ -806,6 +807,8 @@ def replace(self) -> _RewriteFiles:
             io=self._io,
             snapshot_properties=self._snapshot_properties,
         )
+
+
 class _ManifestMergeManager(Generic[U]):
     _target_size_bytes: int
     _min_count_to_merge: int

tests/table/test_replace.py

@@ -1,19 +1,18 @@
-import uuid
-import pytest
+from pyiceberg.catalog import Catalog
 from pyiceberg.manifest import DataFile, DataFileContent, FileFormat
-from pyiceberg.table.snapshots import Operation
-from pyiceberg.partitioning import PartitionSpec
 from pyiceberg.schema import Schema
+from pyiceberg.table.snapshots import Operation
 from pyiceberg.typedef import Record
 
-def test_replace_api(catalog):
+
+def test_replace_api(catalog: Catalog) -> None:
     # Setup a basic table using the catalog fixture
     catalog.create_namespace("default")
     table = catalog.create_table(
         identifier="default.test_replace",
         schema=Schema(),
     )
-    
+
     # Create mock DataFiles for the test
     file_to_delete = DataFile.from_args(
         file_path="s3://bucket/test/data/deleted.parquet",
@@ -24,7 +23,7 @@ def test_replace_api(catalog):
         content=DataFileContent.DATA,
     )
     file_to_delete.spec_id = 0
-    
+
     file_to_add = DataFile.from_args(
         file_path="s3://bucket/test/data/added.parquet",
         file_format=FileFormat.PARQUET,
@@ -34,28 +33,29 @@ def test_replace_api(catalog):
         content=DataFileContent.DATA,
     )
     file_to_add.spec_id = 0
-    
+
     # Initially append to have something to replace
     with table.transaction() as tx:
         with tx.update_snapshot().fast_append() as append_snapshot:
             append_snapshot.append_data_file(file_to_delete)
-    
+
     # Verify initial append snapshot
     assert len(table.history()) == 1
     snapshot = table.current_snapshot()
+    assert snapshot is not None
+    assert snapshot.summary is not None
     assert snapshot.summary["operation"] == Operation.APPEND
-    
+
     # Call the replace API
-    table.replace(
-        files_to_delete=[file_to_delete],
-        files_to_add=[file_to_add]
-    )
-    
+    table.replace(files_to_delete=[file_to_delete], files_to_add=[file_to_add])
+
     # Verify the replacement created a REPLACE snapshot
     assert len(table.history()) == 2
     snapshot = table.current_snapshot()
+    assert snapshot is not None
+    assert snapshot.summary is not None
     assert snapshot.summary["operation"] == Operation.REPLACE
-    
+
     # Verify the correct files are added and deleted
     # The summary property tracks these counts
     assert snapshot.summary["added-data-files"] == "1"
@@ -65,28 +65,29 @@ def test_replace_api(catalog):
 
     # Verify the new file exists in the new manifest
     manifest_files = snapshot.manifests(table.io)
-    assert len(manifest_files) == 2 # One for ADDED, one for DELETED
-    
+    assert len(manifest_files) == 2  # One for ADDED, one for DELETED
+
     # Check that sequence numbers were handled properly natively by verifying the manifest contents
     entries = []
     for manifest in manifest_files:
         for entry in manifest.fetch_manifest_entry(table.io, discard_deleted=False):
             entries.append(entry)
-            
+
     # One entry for ADDED (new file), one for DELETED (old file)
     assert len(entries) == 2
-    
-def test_replace_empty_files(catalog):
+
+
+def test_replace_empty_files(catalog: Catalog) -> None:
     # Setup a basic table using the catalog fixture
     catalog.create_namespace("default")
     table = catalog.create_table(
         identifier="default.test_replace_empty",
         schema=Schema(),
     )
-    
+
     # Replacing empty lists should not throw errors, but should produce no changes.
     table.replace([], [])
-    
+
     # History should be completely empty since no files were rewritten
     assert len(table.history()) == 0
     assert table.current_snapshot() is None