Action dies when selected record is deleted just before it is pressed

[EffpehKah]

Describe the bug

When you have an action, e.g. csv download, and someone else deletes one of the records you selected the action will just die. This is something that might happen when multiple users are allowed to act on or delete records.

Reproduction

just use main avo demo, go to projects, create a new project, open another tab with project index page so you have 2 tabs with the same index page open. Then delete the newly created project in one tab and try to download csv where the deleted project is selected in the other tab.

Expected behavior & Actual behavior

Avo should just remove records that it can't find as it could have been deleted / discarded or something like that by another user at the same time. The action just dies instead which is never a good thing.

License type:

• Community
• Pro
• Advanced

Are you using Avo monkey patches, overriding views or view components?

• Yes. If so, please post code samples.
• No

Impact

• High impact (It makes my app un-usable.)
• Medium impact (I'm annoyed, but I'll live.)
• Low impact (It's really a tiny thing that I could live with.)

Urgency

• High urgency (I can't continue development without it.)
• Medium urgency (I found a workaround, but I'd love to have it fixed.)
• Low urgency (It can wait. I just wanted you to know about it.)
• It's a nasty edge case that happens rarely.

[linear]

AVO-806 Action dies when selected record is deleted just before it is pressed

[Paul-Bob]

Hi @EffpehKah, thanks for the detailed issue.

This is happening because actions are using find to query the records.

For example, Project.find(1, 2) raises ActiveRecord::RecordNotFound whenever it can't find one of the records in the array.

Using find_by or where would fix the issue, but find is also powerful, since some gems like FriendlyId modify the find method (when using finders) to make it possible to do Project.find("one").

Any suggestions are welcome.