docs: Update SPEC-19 with sync_status_service removal and Logfire instrumentation

Updated Phase 1 implementation checklist to reflect:
- Removal of sync_status_service (unnecessary complexity)
- Addition of Logfire instrumentation for observability
- All 1184 tests passing after cleanup

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

specs/SPEC-19 Sync Performance and Memory Optimization.md

@@ -437,7 +437,13 @@ ALTER TABLE entity ADD COLUMN size INTEGER;
   - [x] Removed `SyncService._compute_checksum_async()` wrapper method
   - [x] Inlined all 7 checksum calls to use `file_service.compute_checksum()` directly
   - [x] All file I/O operations now properly consolidated in FileService with non-blocking I/O
-- [ ] Keep sync status service (used by MCP tools)
+- [x] Removed sync_status_service completely (unnecessary complexity and state tracking)
+  - [x] Removed `sync_status_service.py` and `sync_status` MCP tool
+  - [x] Removed all `sync_status_tracker` calls from `sync_service.py`
+  - [x] Removed migration status checks from MCP tools (`write_note`, `read_note`, `build_context`)
+  - [x] Removed `check_migration_status()` and `wait_for_migration_or_return_status()` from `utils.py`
+  - [x] Removed all related tests (4 test files deleted)
+  - [x] All 1184 tests passing
 
 **Phase 1 Implementation Summary:**
 
@@ -484,6 +490,13 @@ Phase 1 is now complete with all core fixes implemented and tested:
 - I/O efficiency: True async with aiofiles (no thread pool blocking)
 - Network efficiency: 50% fewer calls on TigrisFS via scandir caching
 - Architecture: Clean separation of concerns (FileService owns all file I/O)
+- Reduced complexity: Removed unnecessary sync_status_service state tracking
+
+**Observability**:
+- [x] Added Logfire instrumentation to `sync_file()` and `sync_markdown_file()`
+- [x] Logfire disabled by default via `ignore_no_config = true` in pyproject.toml
+- [x] No telemetry in FOSS version unless explicitly configured
+- [x] Cloud deployment can enable Logfire for performance monitoring
 
 **Next Steps**: Phase 2 cloud-specific fixes and Phase 3 production measurement.
 

src/basic_memory/mcp/tools/utils.py

@@ -510,5 +510,3 @@ async def call_delete(
 
     except HTTPStatusError as e:
         raise ToolError(error_message) from e
-
-

tests/mcp/test_tool_utils.py

@@ -1,6 +1,6 @@
 """Tests for MCP tool utilities."""
 
-from unittest.mock import AsyncMock, patch, MagicMock
+from unittest.mock import AsyncMock
 
 import pytest
 from httpx import AsyncClient, HTTPStatusError