fix: restore MCP telemetry compatibility and outcomes

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/api/v2/routers/search_router.py

@@ -57,7 +57,10 @@ async def search(
         page_size=page_size,
         retrieval_mode=query.retrieval_mode.value,
         has_query=bool(
-            (query.text and query.text.strip()) or query.title or query.permalink or query.permalink_match
+            (query.text and query.text.strip())
+            or query.title
+            or query.permalink
+            or query.permalink_match
         ),
         has_filters=bool(query.note_types or query.entity_types or query.metadata_filters),
     ):

src/basic_memory/api/v2/utils.py

@@ -39,7 +39,9 @@ async def to_graph_context(
         entity_ids_needed: set[int] = set()
         for context_item in context_result.results:
             for item in (
-                [context_item.primary_result] + context_item.observations + context_item.related_results
+                [context_item.primary_result]
+                + context_item.observations
+                + context_item.related_results
             ):
                 if item.type == SearchItemType.ENTITY:
                     # Entity's own ID for its external_id
@@ -100,9 +102,7 @@ def to_summary(item: SearchIndexRow | ContextResultRow):
                         created_at=item.created_at,
                     )
                 case SearchItemType.RELATION:
-                    from_title = (
-                        entity_title_lookup.get(item.from_id) if item.from_id else None
-                    )  # pyright: ignore
+                    from_title = entity_title_lookup.get(item.from_id) if item.from_id else None  # pyright: ignore
                     to_title = entity_title_lookup.get(item.to_id) if item.to_id else None
                     from_ext_id = (
                         entity_external_id_lookup.get(item.from_id) if item.from_id else None
@@ -154,7 +154,8 @@ def to_summary(item: SearchIndexRow | ContextResultRow):
             generated_at=context_result.metadata.generated_at,
             primary_count=context_result.metadata.primary_count,
             related_count=context_result.metadata.related_count,
-            total_results=context_result.metadata.primary_count + context_result.metadata.related_count,
+            total_results=context_result.metadata.primary_count
+            + context_result.metadata.related_count,
             total_relations=context_result.metadata.total_relations,
             total_observations=context_result.metadata.total_observations,
         )

src/basic_memory/mcp/tools/build_context.py

@@ -206,7 +206,7 @@ async def build_context(
         "mcp.tool.build_context",
         entrypoint="mcp",
         tool_name="build_context",
-        project_name=project,
+        requested_project=project,
         workspace_id=workspace,
         depth=depth or 1,
         timeframe=timeframe,

src/basic_memory/mcp/tools/edit_note.py

@@ -275,7 +275,7 @@ async def edit_note(
         "mcp.tool.edit_note",
         entrypoint="mcp",
         tool_name="edit_note",
-        project_name=project,
+        requested_project=project,
         workspace_id=workspace,
         edit_operation=operation,
         output_format=output_format,

src/basic_memory/mcp/tools/read_note.py

@@ -16,8 +16,8 @@
     resolve_project_and_path,
 )
 from basic_memory.mcp.server import mcp
+from basic_memory.mcp.tools.search import search_notes
 from basic_memory.schemas.memory import memory_url_path
-from basic_memory.schemas.search import SearchQuery
 from basic_memory.utils import validate_project_path
 
 
@@ -144,7 +144,7 @@ async def read_note(
         "mcp.tool.read_note",
         entrypoint="mcp",
         tool_name="read_note",
-        project_name=project,
+        requested_project=project,
         workspace_id=workspace,
         output_format=output_format,
         page=page,
@@ -199,12 +199,11 @@ async def read_note(
                 )
 
                 # Import here to avoid circular import
-                from basic_memory.mcp.clients import KnowledgeClient, ResourceClient, SearchClient
+                from basic_memory.mcp.clients import KnowledgeClient, ResourceClient
 
                 # Use typed clients for API calls
                 knowledge_client = KnowledgeClient(client, active_project.external_id)
                 resource_client = ResourceClient(client, active_project.external_id)
-                search_client = SearchClient(client, active_project.external_id)
 
                 async def _read_json_payload(entity_id: str) -> dict:
                     with telemetry.scope(
@@ -214,7 +213,9 @@ async def _read_json_payload(entity_id: str) -> dict:
                         phase="shape_response",
                     ):
                         entity = await knowledge_client.get_entity(entity_id)
-                        response = await resource_client.read(entity_id, page=page, page_size=page_size)
+                        response = await resource_client.read(
+                            entity_id, page=page, page_size=page_size
+                        )
                         content_text = response.text
                         body_content, parsed_frontmatter = _parse_opening_frontmatter(content_text)
                         return {
@@ -241,15 +242,22 @@ def _search_results(payload: object) -> list[dict]:
                     return results if isinstance(results, list) else []
 
                 async def _search_candidates(identifier_text: str, *, title_only: bool) -> dict:
-                    query = SearchQuery(title=identifier_text) if title_only else SearchQuery(
-                        text=identifier_text
-                    )
-                    response = await search_client.search(
-                        query.model_dump(mode="json", exclude_none=True),
+                    # Trigger: direct entity resolution failed for the caller's identifier.
+                    # Why: search_notes applies the same memory:// normalization and tool-level
+                    #      query handling as the rest of MCP routing, which raw client calls skip.
+                    # Outcome: unresolved memory URLs still fall back through normalized search.
+                    search_type = "title" if title_only else "text"
+                    response = await search_notes(
+                        project=active_project.name,
+                        workspace=workspace,
+                        query=identifier_text,
+                        search_type=search_type,
                         page=page,
                         page_size=page_size,
+                        output_format="json",
+                        context=context,
                     )
-                    return response.model_dump(mode="json")
+                    return response if isinstance(response, dict) else {}
 
                 def _result_title(item: dict) -> str:
                     return str(item.get("title") or "")

src/basic_memory/mcp/tools/search.py

@@ -528,7 +528,7 @@ async def search_notes(
         "mcp.tool.search_notes",
         entrypoint="mcp",
         tool_name="search_notes",
-        project_name=project,
+        requested_project=project,
         workspace_id=workspace,
         search_type=search_type or "default",
         output_format=output_format,
@@ -537,7 +537,9 @@ async def search_notes(
         has_query=bool(query and query.strip()),
         note_type_filter_count=len(note_types),
         entity_type_filter_count=len(entity_types),
-        has_filters=bool(metadata_filters or tags or status or note_types or entity_types or after_date),
+        has_filters=bool(
+            metadata_filters or tags or status or note_types or entity_types or after_date
+        ),
         has_tags_filter=bool(tags),
         has_status_filter=bool(status),
     ):