fix: validate page/page_size in recent_activity before API call

Prevents negative OFFSET errors from reaching the database when
invalid pagination values (page=0, page_size=-1, etc.) are passed.
Raises clear ValueError messages at the tool boundary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/mcp/tools/recent_activity.py

@@ -111,6 +111,15 @@ async def recent_activity(
         - For focused queries, consider using build_context with a specific URI
         - Max timeframe is 1 year in the past
     """
+    # Validate pagination arguments before they reach the API layer,
+    # where negative offset would cause a database error.
+    if page < 1:
+        raise ValueError(f"page must be >= 1, got {page}")
+    if page_size < 1:
+        raise ValueError(f"page_size must be >= 1, got {page_size}")
+    if page_size > 100:
+        raise ValueError(f"page_size must be <= 100, got {page_size}")
+
     # Build common parameters for API calls
     params: dict = {
         "page": page,

tests/mcp/test_tool_recent_activity.py

@@ -493,6 +493,25 @@ async def test_recent_activity_pagination_params(client, test_project, test_grap
     assert "Recent Activity:" in result
 
 
+@pytest.mark.asyncio
+async def test_recent_activity_pagination_validation():
+    """Invalid page/page_size values should raise clear ValueError messages."""
+    with pytest.raises(ValueError, match="page must be >= 1, got 0"):
+        await recent_activity.fn(page=0)
+
+    with pytest.raises(ValueError, match="page must be >= 1, got -1"):
+        await recent_activity.fn(page=-1)
+
+    with pytest.raises(ValueError, match="page_size must be >= 1, got 0"):
+        await recent_activity.fn(page_size=0)
+
+    with pytest.raises(ValueError, match="page_size must be >= 1, got -5"):
+        await recent_activity.fn(page_size=-5)
+
+    with pytest.raises(ValueError, match="page_size must be <= 100, got 999"):
+        await recent_activity.fn(page_size=999)
+
+
 def test_format_project_output_has_more_pagination_guidance():
     """When has_more is True, activity summary should show pagination guidance."""
     import importlib