fix: Rename write_note entity_type parameter to note_type for clarity

Resolves inconsistency between write_note's entity_type parameter
and search_notes's entity_types parameter. The write_note parameter
sets the frontmatter type field (note, guide, person, etc.), while
search_notes's entity_types filters by Entity/Observation/Relation types.

Renaming to note_type makes it clear this parameter sets the note's
type in frontmatter, not the database entity type.

Changes:
- Renamed entity_type → note_type in write_note MCP tool
- Updated parameter documentation with clearer description
- Updated all examples in AI assistant guide
- Updated all test cases
- Internal Entity schema field remains entity_type (no breaking change)

Fixes #403

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Paul Hernandez <phernandez@users.noreply.github.com>

Author: 3 people

docs/ai-assistant-guide-extended.md

@@ -576,7 +576,7 @@ Adopt GraphQL instead of REST for our API layer.
 """,
     folder="decisions",
     tags=["decision", "api", "graphql"],
-    entity_type="decision",
+    note_type="decision",
     project="main"
 )
 ```
@@ -613,7 +613,7 @@ await write_note(
 """,
     folder="meetings",
     tags=["meeting", "api", "team"],
-    entity_type="meeting",
+    note_type="meeting",
     project="main"
 )
 ```
@@ -665,7 +665,7 @@ Specification for user authentication system using JWT tokens.
 """,
     folder="specs",
     tags=["spec", "auth", "security"],
-    entity_type="spec",
+    note_type="spec",
     project="main"
 )
 ```
@@ -1631,7 +1631,7 @@ await write_note(
 {related_entities}
 """,
     folder="decisions",
-    entity_type="decision",
+    note_type="decision",
     project="main"
 )
 ```
@@ -2706,14 +2706,14 @@ await write_note(
 
 ### Content Management
 
-**write_note(title, content, folder, tags, entity_type, project)**
+**write_note(title, content, folder, tags, note_type, project)**
 - Create or update markdown notes
 - Parameters:
   - `title` (required): Note title
   - `content` (required): Markdown content
   - `folder` (required): Destination folder
   - `tags` (optional): List of tags
-  - `entity_type` (optional): Entity type (note, person, meeting, etc.)
+  - `note_type` (optional): Type of note (stored in frontmatter). Can be "note", "person", "meeting", "guide", etc.
   - `project` (required unless default_project_mode): Target project
 - Returns: Created/updated entity with permalink
 - Example:
@@ -2723,7 +2723,7 @@ await write_note(
     content="# API Design\n...",
     folder="specs",
     tags=["api", "design"],
-    entity_type="spec",
+    note_type="spec",
     project="main"
 )
 ```

src/basic_memory/mcp/tools/write_note.py

@@ -29,7 +29,7 @@ async def write_note(
     folder: str,
     project: Optional[str] = None,
     tags=None,
-    entity_type: str = "note",
+    note_type: str = "note",
     context: Context | None = None,
 ) -> str:
     """Write a markdown note to the knowledge base.
@@ -70,7 +70,8 @@ async def write_note(
                 available projects.
         tags: Tags to categorize the note. Can be a list of strings, a comma-separated string, or None.
               Note: If passing from external MCP clients, use a string format (e.g. "tag1,tag2,tag3")
-        entity_type: Type of entity to create. Defaults to "note". Can be "guide", "report", "config", etc.
+        note_type: Type of note to create (stored in frontmatter). Defaults to "note".
+                   Can be "guide", "report", "config", "person", etc.
         context: Optional FastMCP context for performance caching.
 
     Returns:
@@ -96,14 +97,14 @@ async def write_note(
             content="# Weekly Standup\\n\\n- [decision] Use SQLite for storage #tech"
         )
 
-        # Create a note with tags and entity type
+        # Create a note with tags and note type
         write_note(
             project="work-project",
             title="API Design",
             folder="specs",
             content="# REST API Specification\\n\\n- implements [[Authentication]]",
             tags=["api", "design"],
-            entity_type="guide"
+            note_type="guide"
         )
 
         # Update existing note (same title/folder)
@@ -147,7 +148,7 @@ async def write_note(
         entity = Entity(
             title=title,
             folder=folder,
-            entity_type=entity_type,
+            entity_type=note_type,
             content_type="text/markdown",
             content=content,
             entity_metadata=metadata,

tests/mcp/test_tool_write_note.py

@@ -538,7 +538,7 @@ async def test_write_note_with_custom_entity_type(app, test_project):
         folder="guides",
         content="# Guide Content\nThis is a guide",
         tags=["guide", "documentation"],
-        entity_type="guide",
+        note_type="guide",
     )
 
     assert result
@@ -574,14 +574,14 @@ async def test_write_note_with_custom_entity_type(app, test_project):
 
 @pytest.mark.asyncio
 async def test_write_note_with_report_entity_type(app, test_project):
-    """Test creating a note with entity_type="report"."""
+    """Test creating a note with note_type="report"."""
     result = await write_note.fn(
         project=test_project.name,
         title="Monthly Report",
         folder="reports",
         content="# Monthly Report\nThis is a monthly report",
         tags=["report", "monthly"],
-        entity_type="report",
+        note_type="report",
     )
 
     assert result
@@ -599,13 +599,13 @@ async def test_write_note_with_report_entity_type(app, test_project):
 
 @pytest.mark.asyncio
 async def test_write_note_with_config_entity_type(app, test_project):
-    """Test creating a note with entity_type="config"."""
+    """Test creating a note with note_type="config"."""
     result = await write_note.fn(
         project=test_project.name,
         title="System Config",
         folder="config",
         content="# System Configuration\nThis is a config file",
-        entity_type="config",
+        note_type="config",
     )
 
     assert result
@@ -659,21 +659,21 @@ async def test_write_note_update_existing_with_different_entity_type(app, test_p
         folder="test",
         content="# Initial Content\nThis starts as a note",
         tags=["test"],
-        entity_type="note",
+        note_type="note",
     )
 
     assert result1
     assert "# Created note" in result1
     assert f"project: {test_project.name}" in result1
 
-    # Update the same note with a different entity_type
+    # Update the same note with a different note_type
     result2 = await write_note.fn(
         project=test_project.name,
         title="Changeable Type",
         folder="test",
         content="# Updated Content\nThis is now a guide",
         tags=["guide"],
-        entity_type="guide",
+        note_type="guide",
     )
 
     assert result2
@@ -976,7 +976,7 @@ async def test_write_note_security_with_all_parameters(self, app, test_project):
             folder="../../../etc/malicious",
             content="# Malicious Content\nThis should be blocked by security validation.",
             tags=["malicious", "test"],
-            entity_type="guide",
+            note_type="guide",
         )
 
         assert isinstance(result, str)
@@ -1026,7 +1026,7 @@ async def test_write_note_preserves_functionality_with_security(self, app, test_
                 Additional content with various formatting.
             """).strip(),
             tags=["security", "test", "full-feature"],
-            entity_type="guide",
+            note_type="guide",
         )
 
         # Should succeed normally