Convert 33 specs to lightweight_spec_helper for faster test loading

johha · johha · commit ef56d24e53b7 · 2026-03-13T15:54:54.000+01:00
This batch converts specs that test pure Ruby logic without database
dependencies, allowing them to load in ~0.6s instead of ~10s.

Converted lib specs (24 files, ~240 tests):
- Diego lifecycle data specs (buildpack, cnb, docker)
- Diego utilities (failure_reason_sanitizer, ssh_key, droplet_url_generator, docker_uri_converter)
- Core utilities (http_response_error, http_request_error, structured_error, index_stopper)
- Routing/paging (router_group, disabled_routing_api_client, pagination_options)
- Other utils (uri_utils, digester, adjective_noun_generator, database_uri_generator, etc.)

Converted message specs (9 files, ~111 tests):
- List message specs: processes, stacks, spaces, builds, deployments,
  droplets, events, tasks, sidecars

Also fixed:
- validators_spec.rb: Added Config stub for LifecycleValidator tests

Load time improvement: ~10x faster for converted specs
diff --git a/spec/unit/lib/cloud_controller/adjective_noun_generator_spec.rb b/spec/unit/lib/cloud_controller/adjective_noun_generator_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/adjective_noun_generator'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/blob_sender/default_blob_sender_spec.rb b/spec/unit/lib/cloud_controller/blob_sender/default_blob_sender_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'steno/steno'
 require 'cloud_controller/blob_sender/default_blob_sender'
 
 module CloudController
diff --git a/spec/unit/lib/cloud_controller/clock/distributed_scheduler_spec.rb b/spec/unit/lib/cloud_controller/clock/distributed_scheduler_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'clockwork'
 require 'cloud_controller/clock/distributed_scheduler'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/database_uri_generator_spec.rb b/spec/unit/lib/cloud_controller/database_uri_generator_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'cloud_controller/database_uri_generator'
 
 RSpec.describe VCAP::CloudController::DatabaseUriGenerator do
   let(:service_uris) { ['postgres://username:password@host/db'] }
diff --git a/spec/unit/lib/cloud_controller/diego/buildpack/lifecycle_data_spec.rb b/spec/unit/lib/cloud_controller/diego/buildpack/lifecycle_data_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'membrane'
 require 'cloud_controller/diego/buildpack/lifecycle_data'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/diego/cnb/lifecycle_data_spec.rb b/spec/unit/lib/cloud_controller/diego/cnb/lifecycle_data_spec.rb
@@ -1,5 +1,6 @@
-require 'spec_helper'
-require 'cloud_controller/diego/buildpack/lifecycle_data'
+require 'lightweight_spec_helper'
+require 'membrane'
+require 'cloud_controller/diego/cnb/lifecycle_data'
 
 module VCAP::CloudController
   module Diego
diff --git a/spec/unit/lib/cloud_controller/diego/docker/docker_uri_converter_spec.rb b/spec/unit/lib/cloud_controller/diego/docker/docker_uri_converter_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'addressable/uri'
 require 'cloud_controller/diego/docker/docker_uri_converter'
 require 'utils/uri_utils'
 
diff --git a/spec/unit/lib/cloud_controller/diego/docker/lifecycle_data_spec.rb b/spec/unit/lib/cloud_controller/diego/docker/lifecycle_data_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'membrane'
 require 'cloud_controller/diego/docker/lifecycle_data'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/diego/droplet_url_generator_spec.rb b/spec/unit/lib/cloud_controller/diego/droplet_url_generator_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/diego/droplet_url_generator'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/diego/failure_reason_sanitizer_spec.rb b/spec/unit/lib/cloud_controller/diego/failure_reason_sanitizer_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/diego/failure_reason_sanitizer'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/diego/ssh_key_spec.rb b/spec/unit/lib/cloud_controller/diego/ssh_key_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/diego/ssh_key'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/metrics/request_metrics_spec.rb b/spec/unit/lib/cloud_controller/metrics/request_metrics_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/metrics/request_metrics'
 
 module VCAP::CloudController::Metrics
diff --git a/spec/unit/lib/cloud_controller/paging/pagination_options_spec.rb b/spec/unit/lib/cloud_controller/paging/pagination_options_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/paging/pagination_options'
 
 module VCAP::CloudController
diff --git a/spec/unit/lib/cloud_controller/routing_api/disabled_routing_api_client_spec.rb b/spec/unit/lib/cloud_controller/routing_api/disabled_routing_api_client_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'cloud_controller/routing_api/disabled_routing_api_client'
 
 module VCAP::CloudController::RoutingApi
   RSpec.describe DisabledClient do
diff --git a/spec/unit/lib/cloud_controller/routing_api/router_group_spec.rb b/spec/unit/lib/cloud_controller/routing_api/router_group_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'cloud_controller/routing_api/router_group'
 
 module VCAP::CloudController::RoutingApi
diff --git a/spec/unit/lib/http_request_error_spec.rb b/spec/unit/lib/http_request_error_spec.rb
@@ -1,4 +1,6 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'cloud_controller/structured_error'
+require 'cloud_controller/http_request_error'
 
 RSpec.describe HttpRequestError do
   let(:endpoint) { 'http://www.example.com/' }
diff --git a/spec/unit/lib/http_response_error_spec.rb b/spec/unit/lib/http_response_error_spec.rb
@@ -1,4 +1,6 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'oj'
+require 'cloud_controller/http_response_error'
 
 RSpec.describe HttpResponseError do
   describe '#initialize' do
diff --git a/spec/unit/lib/index_stopper_spec.rb b/spec/unit/lib/index_stopper_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'cloud_controller/index_stopper'
 
 module VCAP::CloudController
   RSpec.describe IndexStopper do
diff --git a/spec/unit/lib/rest_controller/common_params_spec.rb b/spec/unit/lib/rest_controller/common_params_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'cloud_controller/rest_controller/common_params'
 
 module VCAP::CloudController::RestController
   RSpec.describe CommonParams do
diff --git a/spec/unit/lib/structured_error_spec.rb b/spec/unit/lib/structured_error_spec.rb
@@ -1,4 +1,5 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
+require 'cloud_controller/structured_error'
 
 RSpec.describe StructuredError do
   context 'with a hash source' do
diff --git a/spec/unit/lib/utils/uri_utils_spec.rb b/spec/unit/lib/utils/uri_utils_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'utils/uri_utils'
 
 RSpec.describe UriUtils do
diff --git a/spec/unit/lib/vcap/digester_spec.rb b/spec/unit/lib/vcap/digester_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'vcap/digester'
 
 RSpec.describe Digester do
diff --git a/spec/unit/lib/vcap/host_system_spec.rb b/spec/unit/lib/vcap/host_system_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'vcap/host_system'
 
 RSpec.describe VCAP::HostSystem do
diff --git a/spec/unit/messages/builds_list_message_spec.rb b/spec/unit/messages/builds_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/builds_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/deployments_list_message_spec.rb b/spec/unit/messages/deployments_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/deployments_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/droplets_list_message_spec.rb b/spec/unit/messages/droplets_list_message_spec.rb
@@ -1,5 +1,6 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/droplets_list_message'
+require 'messages/spaces_list_message'
 
 module VCAP::CloudController
   RSpec.describe DropletsListMessage do
diff --git a/spec/unit/messages/events_list_message_spec.rb b/spec/unit/messages/events_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/events_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/processes_list_message_spec.rb b/spec/unit/messages/processes_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/processes_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/sidecars_list_message_spec.rb b/spec/unit/messages/sidecars_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/sidecars_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/spaces_list_message_spec.rb b/spec/unit/messages/spaces_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/spaces_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/stacks_list_message_spec.rb b/spec/unit/messages/stacks_list_message_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/stacks_list_message'
 
 module VCAP::CloudController
diff --git a/spec/unit/messages/tasks_list_message_spec.rb b/spec/unit/messages/tasks_list_message_spec.rb
@@ -1,5 +1,6 @@
-require 'spec_helper'
+require 'lightweight_spec_helper'
 require 'messages/tasks_list_message'
+require 'messages/packages_list_message'
 
 module VCAP::CloudController
   RSpec.describe TasksListMessage do
diff --git a/spec/unit/messages/validators_spec.rb b/spec/unit/messages/validators_spec.rb
@@ -6,6 +6,7 @@
 require 'cloud_controller/diego/lifecycles/app_docker_lifecycle'
 require 'cloud_controller/diego/lifecycles/app_buildpack_lifecycle'
 require 'cloud_controller/diego/lifecycles/lifecycles'
+require 'cloud_controller/config'
 require 'rspec/collection_matchers'
 require 'pry'
 
@@ -428,6 +429,11 @@ def validate_each(record, attr_name, value)
     end
 
     describe 'LifecycleValidator' do
+      before do
+        config = instance_double(VCAP::CloudController::Config, get: 'buildpack')
+        allow(VCAP::CloudController::Config).to receive(:config).and_return(config)
+      end
+
       let(:lifecycle_class) do
         Class.new(fake_class) do
           attr_accessor :lifecycle

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-require 'spec_helper'`
	`1`	`+require 'lightweight_spec_helper'`
`2`	`2`	`require 'cloud_controller/adjective_noun_generator'`
`3`	`3`
`4`	`4`	`module VCAP::CloudController`