Merge branch 'mirror-on-request-fix' into 0.6

Author: codedmonkey

src/Controller/ApiController.php

@@ -88,7 +88,7 @@ public function packageMetadata(Request $request): Response
         $packageName = $request->attributes->getString('package');
         $basePackageName = u($packageName)->trimSuffix('~dev')->toString();
 
-        if (null === $this->findPackage($basePackageName)) {
+        if (null === $this->findPackage($basePackageName, create: true)) {
             throw $this->createNotFoundException();
         }
 

tests/FunctionalTests/Controller/ApiControllerPublicTest.php

@@ -2,13 +2,21 @@
 
 namespace CodedMonkey\Dirigent\Tests\FunctionalTests\Controller;
 
+use CodedMonkey\Dirigent\Doctrine\Entity\Package;
+use CodedMonkey\Dirigent\Doctrine\Entity\Registry;
+use CodedMonkey\Dirigent\Doctrine\Entity\RegistryPackageMirroring;
 use CodedMonkey\Dirigent\Tests\FunctionalTests\PublicKernel;
+use CodedMonkey\Dirigent\Tests\Helper\KernelTestCaseTrait;
+use CodedMonkey\Dirigent\Tests\Helper\MockEntityFactoryTrait;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 
 class ApiControllerPublicTest extends KernelTestCase
 {
+    use KernelTestCaseTrait;
+    use MockEntityFactoryTrait;
+
     #[\Override]
     protected static function getKernelClass(): string
     {
@@ -28,7 +36,7 @@ public function testRoot(): void
         ], $rootData);
     }
 
-    public function testPackage(): void
+    public function testPackagMetadata(): void
     {
         self::bootKernel();
 
@@ -37,7 +45,7 @@ public function testPackage(): void
         $this->assertNotSame([], $packageData);
     }
 
-    public function testPackageDev(): void
+    public function testPackageMetadataDev(): void
     {
         self::bootKernel();
 
@@ -46,6 +54,37 @@ public function testPackageDev(): void
         $this->assertNotSame([], $packageData);
     }
 
+    public function testPackageMetadataIsNotFound(): void
+    {
+        self::bootKernel();
+
+        $request = Request::create('/p2/psr/container.json', 'GET');
+        $response = self::$kernel->handle($request);
+
+        $this->assertSame(Response::HTTP_NOT_FOUND, $response->getStatusCode());
+    }
+
+    public function testPackageMetadataIsMirroredOnRequest(): void
+    {
+        self::bootKernel();
+
+        // Verify the package doesn't already exist
+        $package = $this->findEntity(Package::class, ['name' => 'psr/container']);
+
+        $this->assertNull($package);
+
+        // Update the registry so that it allows dynamically adding packages on request from the API
+        $registry = $this->findEntity(Registry::class, ['name' => 'Packagist']);
+        $registry->setPackageMirroring(RegistryPackageMirroring::Automatic);
+
+        $this->persistEntities($registry);
+
+        // Execute the API endpoint
+        $packageData = $this->requestJson('/p2/psr/container.json', 'GET');
+
+        $this->assertNotSame([], $packageData);
+    }
+
     private function requestJson(...$requestArguments)
     {
         $request = Request::create(...$requestArguments);

tests/Helper/KernelTestCaseTrait.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace CodedMonkey\Dirigent\Tests\Helper;
+
+trait KernelTestCaseTrait
+{
+    /**
+     * @template TServiceClass of object
+     *
+     * @param class-string<TServiceClass> $class
+     *
+     * @return TServiceClass
+     */
+    protected function getService(string $class, ?string $name = null): object
+    {
+        return self::getContainer()->get($name ?: $class);
+    }
+}