Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock (#4465)

Author: shai-almog

.github/scripts/generate-quality-report.py

@@ -924,7 +924,10 @@ def _is_exempt(f: Finding) -> bool:
             "UselessQualifiedThis",
             "AvoidBranchingStatementAsLastInLoop",
             "AvoidUsingVolatile",
-            "DoNotCallGarbageCollectionExplicitly"
+            "DoNotCallGarbageCollectionExplicitly",
+            "SuspiciousEqualsMethodName",
+            "UseUtilityClass",
+            "EmptyCatchBlock"
         }
         violations = [f for f in pmd.findings if f.rule in forbidden_pmd_rules]
         if violations:

CodenameOne/src/com/codename1/capture/Capture.java

@@ -49,7 +49,7 @@
  *
  * @author Chen
  */
-public class Capture {
+public abstract class Capture {
 
     /**
      * Returns true if the device has camera false otherwise.

CodenameOne/src/com/codename1/charts/util/ColorUtil.java

@@ -26,7 +26,7 @@
 /**
  * @author shannah
  */
-public class ColorUtil {
+public abstract class ColorUtil {
     public static final int LTGRAY = IColor.LightGray.argb;
     public static final int BLUE = IColor.Blue.argb;
     public static final int BLACK = IColor.Black.argb;

CodenameOne/src/com/codename1/charts/views/PkgUtils.java

@@ -27,7 +27,8 @@
 /**
  * @author shannah
  */
-class PkgUtils {
+final class PkgUtils {
+    private PkgUtils() {}
     static Rectangle2D makeRect(double x1, double y1, double x2, double y2) {
         return new Rectangle2D(x1, y1, x2 - x1, y2 - y1);
     }

CodenameOne/src/com/codename1/compat/java/util/Objects.java

@@ -37,13 +37,16 @@
  * @author shannah
  */
 public final class Objects {
+    private Objects() {}
+
     /**
      * Returns true if the arguments are equal to each other and false otherwise. Consequently, if both arguments are null, true is returned and if exactly one argument is null, false is returned. Otherwise, equality is determined by using the equals method of the first argument.
      *
      * @param a
      * @param b
      * @return
      */
+    @SuppressWarnings("PMD.SuspiciousEqualsMethodName")
     public static boolean equals(Object a, Object b) {
         if (a == b) { //NOPMD CompareObjectsWithEquals
             return true;

CodenameOne/src/com/codename1/components/MasterDetail.java

@@ -41,7 +41,9 @@
  * @author Shai Almog
  * @deprecated this was a half baked idea that made it into the public API
  */
-public class MasterDetail {
+public final class MasterDetail {
+    private MasterDetail() {}
+
     /**
      * @deprecated this was a half baked idea that made it into the public API
      */

CodenameOne/src/com/codename1/io/ConnectionRequest.java

@@ -1402,6 +1402,7 @@ private Date parseDate(String date, String... formats) {
                 SimpleDateFormat sdf = new SimpleDateFormat(format);
                 return sdf.parse(date);
             } catch (Throwable t) {
+                Log.e(t);
             }
         }
         return null;

CodenameOne/src/com/codename1/io/FileSystemStorage.java

@@ -160,6 +160,7 @@ public void delete(String file) {
      * @param file       file to delete
      * @param retryCount the number of times to retry
      */
+    @SuppressWarnings("PMD.EmptyCatchBlock")
     public void deleteRetry(final String file, final int retryCount) {
         try {
             Util.getImplementation().deleteFile(file);

CodenameOne/src/com/codename1/io/JSONParser.java

@@ -366,7 +366,7 @@ public static void parse(Reader i, JSONParseCallback callback) throws IOExceptio
                                         callback.keyValue(lastKey, currentToken.toString());
                                         lastKey = null;
                                     }
-                                } catch (NumberFormatException err) {
+                                } catch (NumberFormatException err) { // NOPMD EmptyCatchBlock
                                     // this isn't a number!
                                 }
                             }
@@ -404,7 +404,7 @@ public static void parse(Reader i, JSONParseCallback callback) throws IOExceptio
                                         callback.keyValue(lastKey, currentToken.toString());
                                         lastKey = null;
                                     }
-                                } catch (NumberFormatException err) {
+                                } catch (NumberFormatException err) { // NOPMD EmptyCatchBlock
                                     // this isn't a number!
                                 }
                             }

CodenameOne/src/com/codename1/io/Preferences.java

@@ -47,15 +47,15 @@
  * @author Shai Almog
  * @author Miguel Mu\u00f1oz
  */
-public class Preferences {
+public final class Preferences {
     private static final HashMap<String, ArrayList<PreferenceListener>> listenerMap = new HashMap<String, ArrayList<PreferenceListener>>();
     private static Hashtable<String, Object> p;
     private static String preferencesLocation = "CN1Preferences";
 
     /**
      * Block instantiation of preferences
      */
-    Preferences() {
+    private Preferences() {
     }
 
     /**