fix #13954: Unnamed bit fields are removed.#7611
Conversation
ludviggunne
force-pushed
the
13954
branch
8 times, most recently
from
263ea07 to
3f9f968
Compare
ludviggunne
force-pushed
the
13954
branch
2 times, most recently
from
5859d52 to
491e305
Compare
|
what does the test-my-pr.py say? are there diffs..? |
I've only run it with e2764f0 so far, so I should probably run it again. There are some diffs, most of them seem to be eliminated false positive similar to #13653 & #13850. |
There was a problem hiding this comment.
As I understand it the test-my-pr.py show no diffs for a large number of packages and after days of execution.
The tests are unfortunate. We can't know the exact size of a bitfield struct so it should not have a "known" value. Some kind of "portability" values would be fine. But as far as I see we already had this problem in latest 2.17 release so it's not caused by this PR.
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
sorry but I think the Token isAnonymous() attribute would be necessary to have for addons also. Can you please add this attribute in the dumpfile?
|
This introduced a performance regression (hang): https://trac.cppcheck.net/ticket/13995. |
3 participants
No description provided.