Skip to content

Commit 1276a3a

Browse files
committed
Fix acceptance tests to actually verify config-based engine resolution
Change DATABRICKS_BUNDLE_ENGINE from ["direct"] to [] in bind/unbind engine-from-config tests. With ["direct"], env and config agreed so a regression back to engine.FromEnv() would still pass. With [], the env var is unset and the tests verify that bind/unbind read engine from bundle.engine config. Task-review: /Users/denis.bilenko/work/prompts/features/bundle-engine-vs-env/003.SUMMARY.md Co-authored-by: Isaac
1 parent 34a944b commit 1276a3a

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

acceptance/bundle/deployment/bind/job/engine-from-config/out.test.toml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Cloud = false # test leaves deployed job
22
Ignore = [".databricks"]
33

4-
# Use ["direct"] to verify bind respects bundle.engine config (not just env var).
4+
# Omit DATABRICKS_BUNDLE_ENGINE so bind must read engine from bundle.engine config.
55
[EnvMatrix]
6-
DATABRICKS_BUNDLE_ENGINE = ["direct"]
6+
DATABRICKS_BUNDLE_ENGINE = []

acceptance/bundle/deployment/unbind/engine-from-config/out.test.toml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Cloud = false # test leaves deployed job
22
Ignore = [".databricks"]
33

4-
# Use ["direct"] to verify unbind respects bundle.engine config (not just env var).
4+
# Omit DATABRICKS_BUNDLE_ENGINE so unbind must read engine from bundle.engine config.
55
[EnvMatrix]
6-
DATABRICKS_BUNDLE_ENGINE = ["direct"]
6+
DATABRICKS_BUNDLE_ENGINE = []

0 commit comments

Comments
 (0)