Code review changes done

Author: david-liska

examples/high_level_functions_demos/addon_steel_design.js

@@ -48,7 +48,7 @@ SteelDesignFireResistanceConfiguration.prototype.SetName = function (name) {
  * Defines final temperature
  * @param {String} property_define_final_temperature    Final temperature (MANUALLY, ANALYTICALLY), can be undefined (is not set, ANALYTICALLY as default)
  */
-SteelDesignFireResistanceConfiguration.prototype.FinalTemperature = function (property_define_final_temperature) {
+SteelDesignFireResistanceConfiguration.prototype.SetFinalTemperature = function (property_define_final_temperature) {
     if (IsCurrentCodeOfStandard("EN")) {
         var container = this.addon.settings_ec3;
     }
@@ -70,7 +70,7 @@ SteelDesignFireResistanceConfiguration.prototype.FinalTemperature = function (pr
  * @param {Boolean} property_fire_exposure_3_sides_covered_width_user_defined       Assume user-defined width of section as covered, can be undefined (is not set, false as default)
  * @param {Number} property_fire_exposure_3_sides_covered_width_user_defined_value  User-defined width, can be undefined (is not set, 0 s. as default)
  */
-SteelDesignFireResistanceConfiguration.prototype.AnalyticallyDesignSettings = function (property_required_time_of_fire_resistance,
+SteelDesignFireResistanceConfiguration.prototype.SetAnalyticallyDesignSettings = function (property_required_time_of_fire_resistance,
     property_time_interval_of_analysis,
     property_fire_exposure,
     property_fire_exposure_3_sides_covered_width_calculated,
@@ -97,7 +97,7 @@ SteelDesignFireResistanceConfiguration.prototype.AnalyticallyDesignSettings = fu
  * @param {Number} property_specific_heat           Specific heat, can be undefined (is not set, 1200.0 as default)
  * @param {Number} property_thickness               Thickness, can be undefined (is not set, 10.0 as default)
  */
-SteelDesignFireResistanceConfiguration.prototype.AnalyticallyFireProtection = function (property_protection_type,
+SteelDesignFireResistanceConfiguration.prototype.SetAnalyticallyFireProtection = function (property_protection_type,
     property_unit_mass,
     property_thermal_conductivity,
     property_specific_heat,
@@ -121,7 +121,7 @@ SteelDesignFireResistanceConfiguration.prototype.AnalyticallyFireProtection = fu
  * @param {Boolean} property_hydrocarbon_curve                              Hydrocarbon curve, can be undefined (is not set, false as default)
  * @param {Number} property_coefficient_of_heat_transfer_by_convention      Coefficient of heat transfer by convection, can be undefined (is not set, 25 as default)
  */
-SteelDesignFireResistanceConfiguration.prototype.AnalyticallyTemperatureCurve = function (property_standard_temperature_time_curve,
+SteelDesignFireResistanceConfiguration.prototype.SetAnalyticallyTemperatureCurve = function (property_standard_temperature_time_curve,
     property_external_fire_curve,
     property_hydrocarbon_curve,
     property_coefficient_of_heat_transfer_by_convention) {
@@ -146,7 +146,7 @@ SteelDesignFireResistanceConfiguration.prototype.AnalyticallyTemperatureCurve =
  * @param {Number} property_temperature_limit_of_galvanization_effect                               Galvanized surface of carbon steel member, Temperature limit of galvanization effect, can be undefined (is not set, 500 as default)
  * @param {Number} property_surface_emissivity_of_carbon_steel_member_with_temperature_below_limit  Galvanized surface of carbon steel member, Surface emissivity of carbon steel member with temperature below, can be undefined (is not set, 0.350 as default)
  */
-SteelDesignFireResistanceConfiguration.prototype.AnalyticallyThermalActions = function (property_configuration_factor,
+SteelDesignFireResistanceConfiguration.prototype.SetAnalyticallyThermalActions = function (property_configuration_factor,
     property_surface_emissivity_of_carbon_steel_member,
     property_surface_emissivity_of_stainless_steel_member,
     property_emissivity_of_fire,
@@ -171,7 +171,7 @@ SteelDesignFireResistanceConfiguration.prototype.AnalyticallyThermalActions = fu
  * @param {String} property_fire_exposure                   Fire exposure (3_SIDES, ALL_SIDES), can be undefined (is not set, ALL_SIDES as default)
  * @param {Boolean} property_member_with_fire_protection    Member with fire protection, can be undefined (is not set, false as default)
  */
-SteelDesignFireResistanceConfiguration.prototype.ManuallyFinalTemperature = function (property_material_final_temperature,
+SteelDesignFireResistanceConfiguration.prototype.SetManuallyFinalTemperature = function (property_material_final_temperature,
     property_fire_exposure,
     property_member_with_fire_protection) {
     if (IsCurrentCodeOfStandard("EN")) {

includes/AddOns/SteelDesign/FireResistanceConfiguration.js

@@ -51,7 +51,7 @@ SteelDesignServiceabilityConfiguration.prototype.SetName = function (name) {
  * @param {Boolean} property_lowb_road_bridge                       Limitation of web breathing, Road bridge, can be undefined (is not set, true as default) 
  * @param {Boolean} property_lowb_railway_bridge                    Limitation of web breathing, Railway bridge, can be undefined (is not set, false as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersEC3 = function (property_sl_beam_limit_characteristic,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersEC3 = function (property_sl_beam_limit_characteristic,
     property_sl_beam_limit_frequent,
     property_sl_beam_limit_quasi_permanent,
     property_sl_cantilever_limit_characteristic,
@@ -100,7 +100,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersEC3 = function
  * @param {Number} property_sl_beam_limit           Beam limits, can be undefined (is not set, 360 as default)
  * @param {Number} property_sl_cantilever_limit     Cantilever limits, can be undefined (is not set, 180 as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersAISC = function (property_sl_beam_limit,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersAISC = function (property_sl_beam_limit,
     property_sl_cantilever_limit) {
     if (typeof property_sl_beam_limit !== "undefined") {
         this.addon.settings_aisc.property_sl_beam_limit = property_sl_beam_limit;
@@ -115,7 +115,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersAISC = function
  * @param {Number} property_sl_beam_limit           Beam limits, can be undefined (is not set, 360 as default)
  * @param {Number} property_sl_cantilever_limit     Cantilever limits, can be undefined (is not set, 180 as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersIS = function (property_sl_beam_limit,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersIS = function (property_sl_beam_limit,
     property_sl_cantilever_limit) {
     if (typeof property_sl_beam_limit !== "undefined") {
         this.addon.settings_is.property_sl_beam_limit = property_sl_beam_limit;
@@ -131,7 +131,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersIS = function (
  * @param {Number} property_sl_cantilever_limit_value   Cantilever limits, can be undefined (is not set, 180 as default)
  * @param {Number} property_vibration_design            Vibration design, can be undefined (is not set, 5 mm as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersBS = function (property_sl_beam_limit_value,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersBS = function (property_sl_beam_limit_value,
     property_sl_cantilever_limit_value,
     property_vibration_design) {
     if (typeof property_sl_beam_limit_value !== "undefined") {
@@ -152,7 +152,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersBS = function (
  * @param {Number} property_sl_cantilever_limit_characteristic_permanent_and_variable    Cantilever limits acc. to GB 50017, Annex B, permanent and variable, can be undefined (is not set, 500 as default)
  * @param {Number} property_sl_cantilever_limit_characteristic_variable                  Cantilever limits acc. to GB 50017, Annex B, variable, can be undefined (is not set, 500 as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersGB = function (property_sl_beam_limit_characteristic_permanent_and_variable,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersGB = function (property_sl_beam_limit_characteristic_permanent_and_variable,
     property_sl_beam_limit_characteristic_variable,
     property_sl_cantilever_limit_characteristic_permanent_and_variable,
     property_sl_cantilever_limit_characteristic_variable) {
@@ -175,7 +175,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersGB = function (
  * @param {Number} property_sl_beam_limit           Beam limits, can be undefined (is not set, 360 as default)
  * @param {Number} property_sl_cantilever_limit     Cantilever limits, can be undefined (is not set, 180 as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersCSA = function (property_sl_beam_limit,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersCSA = function (property_sl_beam_limit,
     property_sl_cantilever_limit) {
     if (typeof property_sl_beam_limit !== "undefined") {
         this.addon.settings_csa.property_sl_beam_limit = property_sl_beam_limit;
@@ -192,7 +192,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersCSA = function
  * @param {Number} property_sl_cantilever_limit_short_term_effects      Cantilever limits, short-term effects, can be undefined (is not set, 250 as default)
  * @param {Number} property_sl_cantilever_limit_long_term_effects       Cantilever effects, long-term effects, can be undefined (is not set, 125 as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersAS = function (property_sl_beam_limit_short_term_effects,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersAS = function (property_sl_beam_limit_short_term_effects,
     property_sl_beam_limit_long_term_effects,
     property_sl_cantilever_limit_short_term_effects,
     property_sl_cantilever_limit_long_term_effects) {
@@ -215,7 +215,7 @@ SteelDesignServiceabilityConfiguration.prototype.DesignParametersAS = function (
  * @param {Number} property_sl_beam_limit           Beam limits, can be undefined (is not set, 360 as default)
  * @param {Number} property_sl_cantilever_limit     Cantilever limits, can be undefined (is not set, 180 as default)
  */
-SteelDesignServiceabilityConfiguration.prototype.DesignParametersSP = function (property_sl_beam_limit,
+SteelDesignServiceabilityConfiguration.prototype.SetDesignParametersSP = function (property_sl_beam_limit,
     property_sl_cantilever_limit) {
     if (typeof property_sl_beam_limit !== "undefined") {
         this.addon.settings_sp16.property_sl_beam_limit = property_sl_beam_limit;

includes/AddOns/SteelDesign/ServiceabilityConfiguration.js

@@ -2,6 +2,8 @@
 Member sets cannot be set?? What condition for member sets?
 */
 
+include("../../Tools/global.js");
+
 function createBaseSteelDesignConfiguration (object_to_create,
     no,
     members_no,
@@ -29,6 +31,7 @@ setSteelDesign_Members = function (object_to_set,
         members_no = [];
         for (var i = 0; i < member_list.length; ++i) {
             if (members.exist(member_list[i])) {
+                ASSERT(__hasSteelSection(members[member_list[i]].section_start) && __hasSteelSection(members[member_list[i]].section_end), "Member no. " + member_list[i] + " must have section with " + materials.TYPE_STEEL + " material type");
                 members_no.push(member_list[i]);
             }
             else {
@@ -43,6 +46,9 @@ setSteelDesign_Members = function (object_to_set,
         member_sets_no = [];
         for (var i = 0; i < member_sets_list.length; ++i) {
             if (member_sets.exist(member_sets_list[i])) {
+                for (var j = 0; j < member_sets[member_sets_list[i]].members.length; ++j) {
+                    ASSERT(__hasSteelSection(member_sets[member_sets_list[i]].members[j].section_start) && __hasSteelSection(member_sets[member_sets_list[i]].members[j].section_end), "Member no. " + member_sets_list[i].members[j] + " (member set no. " + member_sets_list[i] + ") must have section with " + materials.TYPE_STEEL + " material type");
+                }
                 member_sets_no.push(member_sets_list[i]);
             }
             else {

includes/AddOns/SteelDesign/SteelDesignSupport.js

@@ -42,7 +42,7 @@ SteelDesignStrengthConfigurationAISC.prototype.SetName = function (name) {
  * Sets general design parameters
  * @param {Boolean} property_perform_stability_analysis     Perform stability design, can be undefined (true as default)
  */
-SteelDesignStrengthConfigurationAISC.prototype.General = function (property_perform_stability_analysis) {
+SteelDesignStrengthConfigurationAISC.prototype.SetGeneral = function (property_perform_stability_analysis) {
     if (typeof property_perform_stability_analysis === "undefined") {
         property_perform_stability_analysis = true;
     }
@@ -59,7 +59,7 @@ SteelDesignStrengthConfigurationAISC.prototype.General = function (property_perf
  * @param {Number} property_limit_values_bending_about_major_axis_y     Bending about major axis Y, can be undefined (is not set, 0.001 as default)
  * @param {Number} property_limit_values_bending_about_minor_axis_z     Bending about minor axis Z, can be undefined (is not set, 0.001 as default)
  */
-SteelDesignStrengthConfigurationAISC.prototype.LimitValues = function (property_limit_values_tension,
+SteelDesignStrengthConfigurationAISC.prototype.SetLimitValues = function (property_limit_values_tension,
     property_limit_values_compression,
     property_limit_values_shear_y,
     property_limit_values_shear_z,
@@ -76,7 +76,7 @@ SteelDesignStrengthConfigurationAISC.prototype.LimitValues = function (property_
  * @param {Number} property_unstiffened_elements                                                Unstiffened elements, can be undefined (is not set, 12.500)
  * @param {Number} property_stiffened_elements                                                  Stiffened elements, can be undefined (is not set, 42.000 as default)
  */
-SteelDesignStrengthConfigurationAISC.prototype.LocalBuckling = function (property_check_width_thickness_ratio_of_elements_not_defined_in_tab_b4_1b,
+SteelDesignStrengthConfigurationAISC.prototype.SetLocalBuckling = function (property_check_width_thickness_ratio_of_elements_not_defined_in_tab_b4_1b,
     property_unstiffened_elements,
     property_stiffened_elements) {
     if (typeof property_check_width_thickness_ratio_of_elements_not_defined_in_tab_b4_1b !== "undefined") {
@@ -99,7 +99,7 @@ SteelDesignStrengthConfigurationAISC.prototype.LocalBuckling = function (propert
  * @param {Boolean} property_load_acts_vp_at_center_point                   At center point, can be undefined (is not set, false as default)
  * @param {Boolean} property_load_acts_vp_downwards_on_bottom_flange        On profile edge (stabilizing effect)
  */
-SteelDesignStrengthConfigurationAISC.prototype.PositionOfPositiveTransverse = function (property_load_acts_vp_downwards_on_top_flange,
+SteelDesignStrengthConfigurationAISC.prototype.SetPositionOfPositiveTransverse = function (property_load_acts_vp_downwards_on_top_flange,
     property_load_acts_vp_at_shear_point,
     property_load_acts_vp_at_center_point,
     property_load_acts_vp_downwards_on_bottom_flange) {

includes/AddOns/SteelDesign/StrengthConfigurationAISC.js

@@ -42,7 +42,7 @@ SteelDesignUltimateConfigurationAS.prototype.SetName = function (name) {
  * Sets general design parameters
  * @param {Boolean} property_perform_stability_analysis     Perform stability design, can be undefined (true as default)
  */
-SteelDesignUltimateConfigurationAS.prototype.General = function (property_perform_stability_analysis) {
+SteelDesignUltimateConfigurationAS.prototype.SetGeneral = function (property_perform_stability_analysis) {
     if (typeof property_perform_stability_analysis === "undefined") {
         property_perform_stability_analysis = true;
     }
@@ -59,7 +59,7 @@ SteelDesignUltimateConfigurationAS.prototype.General = function (property_perfor
  * @param {Number} property_limit_values_bending_about_major_axis_y     Bending about major axis Y, can be undefined (is not set, 0.001 as default)
  * @param {Number} property_limit_values_bending_about_minor_axis_z     Bending about minor axis Z, can be undefined (is not set, 0.001 as default)
  */
-SteelDesignUltimateConfigurationAS.prototype.LimitValues = function (property_limit_values_tension,
+SteelDesignUltimateConfigurationAS.prototype.SetLimitValues = function (property_limit_values_tension,
     property_limit_values_compression,
     property_limit_values_shear_y,
     property_limit_values_shear_z,
@@ -76,7 +76,7 @@ SteelDesignUltimateConfigurationAS.prototype.LimitValues = function (property_li
  * @param {Boolean} property_options_use_proportioning_method           Use proportioning method acc. to 5.12.2, can be undefined (is not set, false as default)
  * @param {Boolean} property_options_use_alternative_calculation        Use alternative calculation acc. to 8.3 and 8.4, can be undefined (is not set, false as default)
  */
-SteelDesignUltimateConfigurationAS.prototype.Options = function (property_options_plastic_design_acc_to_45_and_843,
+SteelDesignUltimateConfigurationAS.prototype.SetOptions = function (property_options_plastic_design_acc_to_45_and_843,
     property_options_use_proportioning_method,
     property_options_use_alternative_calculation) {
     if (typeof property_options_plastic_design_acc_to_45_and_843 !== "undefined") {
@@ -95,7 +95,7 @@ SteelDesignUltimateConfigurationAS.prototype.Options = function (property_option
  * @param {Boolean} property_residual_stresses_user_defined     User-defined residual stresses to calculate slenderness limits acc. to tab. 5.2 or tab. 6.2.4, can be undefined (is not set, false as default)
  * @param {String} property_residual_stresses_type              Residual stress (SR - stress relieved, HR - hot-rolled or hot -finished, CF - cold-formed, LW - lightly welded longitudinally, HW - heavily welded longitudinally), can be undefined (is not set, Sr as default)
  */
-SteelDesignUltimateConfigurationAS.prototype.SectionManufacture = function (property_residual_stresses_user_defined,
+SteelDesignUltimateConfigurationAS.prototype.SetSectionManufacture = function (property_residual_stresses_user_defined,
     property_residual_stresses_type) {
     if (typeof property_residual_stresses_user_defined != "undefined") {
         this.addon.settings_as4100.property_residual_stresses_user_defined = property_residual_stresses_user_defined;
@@ -110,7 +110,7 @@ SteelDesignUltimateConfigurationAS.prototype.SectionManufacture = function (prop
  * @param {Boolean} property_vertical_position_at_center_point                   At center point, can be undefined (is not set, false as default)
  * @param {Boolean} property_vertical_position_downwards_on_bottom_flange        On profile edge (stabilizing effect)
  */
-SteelDesignUltimateConfigurationAS.prototype.PositionOfPositiveTransverse = function (property_vertical_position_downwards_on_top_flange,
+SteelDesignUltimateConfigurationAS.prototype.SetPositionOfPositiveTransverse = function (property_vertical_position_downwards_on_top_flange,
     property_vertical_position_at_shear_point,
     property_vertical_position_at_center_point,
     property_vertical_position_downwards_on_bottom_flange) {
@@ -134,7 +134,7 @@ SteelDesignUltimateConfigurationAS.prototype.PositionOfPositiveTransverse = func
  * @param {Boolean} property_welded_sections_rolled_flange      Rolled flange edges, can be undefined (is not set, true as default)
  * @param {Boolean} property_welded_sections_flame_cut_flange   Flame-cut flange edges, can be undefined (is not set, false as default)
  */
-SteelDesignUltimateConfigurationAS.prototype.FabricationOfWeldedSections = function (property_welded_sections_rolled_flange,
+SteelDesignUltimateConfigurationAS.prototype.SetFabricationOfWeldedSections = function (property_welded_sections_rolled_flange,
     property_welded_sections_flame_cut_flange) {
     ASSERT(this.addon.settings_as4100.property_perform_stability_analysis, "Perform stability design must be on");
     if (typeof property_welded_sections_rolled_flange !== "undefined") {