Skip to content

Commit 32a6f21

Browse files
kategenglerkategengler
committed
Fix integration tests for template tag
1 parent 82b0695 commit 32a6f21

8 files changed

Lines changed: 162 additions & 174 deletions

File tree

‎app/components/api-index-filter.gjs‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ import sortBy from 'lodash.sortby';
1616
* @extends Component<{ Args: Args, Blocks: Blocks }>
1717
*/
1818
export default class ApiIndexFilter extends Component {
19-
<template>
20-
<div class="api-index-filter">
21-
{{yield this.filteredData}}
22-
</div>
23-
</template>
2419
get filteredMethods() {
2520
return this.filterItems('methods');
2621
}
@@ -112,4 +107,10 @@ export default class ApiIndexFilter extends Component {
112107
return nextItem;
113108
}
114109
}
110+
111+
<template>
112+
<div class="api-index-filter">
113+
{{yield this.filteredData}}
114+
</div>
115+
</template>
115116
}

‎tests/integration/components/api-index-filter-test.gjs‎

Lines changed: 74 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,17 @@ module('Integration | Component | api index filter', function (hooks) {
7777
@tracked showDeprecated = false;
7878
}
7979

80-
this.model = createModel();
81-
this.filterData = new FilterData();
82-
this.updateFilter = (field) => {
83-
this.filterData[field] = !this.filterData[field];
80+
const model = createModel();
81+
const filterData = new FilterData();
82+
const updateFilter = (field) => {
83+
filterData[field] = !filterData[field];
8484
};
8585

8686
await render(
8787
<template>
8888
<ApiIndexFilter
89-
@model={{this.model}}
90-
@filterData={{this.filterData}}
89+
@model={{model}}
90+
@filterData={{filterData}}
9191
as |myModel|
9292
>
9393
<section>
@@ -96,35 +96,35 @@ module('Integration | Component | api index filter', function (hooks) {
9696
<input
9797
id="inherited-toggle"
9898
type="checkbox"
99-
checked={{this.filterData.showInherited}}
100-
onchange={{fn this.updateFilter "showInherited"}}
99+
checked={{filterData.showInherited}}
100+
onchange={{fn updateFilter "showInherited"}}
101101
/>
102102
Inherited
103103
</label>
104104
<label class="access-checkbox">
105105
<input
106106
id="protected-toggle"
107107
type="checkbox"
108-
checked={{this.filterData.showProtected}}
109-
onchange={{fn this.updateFilter "showProtected"}}
108+
checked={{filterData.showProtected}}
109+
onchange={{fn updateFilter "showProtected"}}
110110
/>
111111
Protected
112112
</label>
113113
<label class="access-checkbox">
114114
<input
115115
id="private-toggle"
116116
type="checkbox"
117-
checked={{this.filterData.showPrivate}}
118-
onchange={{fn this.updateFilter "showPrivate"}}
117+
checked={{filterData.showPrivate}}
118+
onchange={{fn updateFilter "showPrivate"}}
119119
/>
120120
Private
121121
</label>
122122
<label class="access-checkbox">
123123
<input
124124
id="deprecated-toggle"
125125
type="checkbox"
126-
checked={{this.filterData.showDeprecated}}
127-
onchange={{fn this.updateFilter "showDeprecated"}}
126+
checked={{filterData.showDeprecated}}
127+
onchange={{fn updateFilter "showDeprecated"}}
128128
/>
129129
</label>
130130
</section>
@@ -156,17 +156,17 @@ module('Integration | Component | api index filter', function (hooks) {
156156
@tracked showDeprecated = false;
157157
}
158158

159-
this.model = createModel();
160-
this.filterData = new FilterData();
161-
this.updateFilter = (field) => {
162-
this.filterData[field] = !this.filterData[field];
159+
const model = createModel();
160+
const filterData = new FilterData();
161+
const updateFilter = (field) => {
162+
filterData[field] = !filterData[field];
163163
};
164164

165165
await render(
166166
<template>
167167
<ApiIndexFilter
168-
@model={{this.model}}
169-
@filterData={{this.filterData}}
168+
@model={{model}}
169+
@filterData={{filterData}}
170170
as |myModel|
171171
>
172172
<section>
@@ -175,35 +175,35 @@ module('Integration | Component | api index filter', function (hooks) {
175175
<input
176176
id="inherited-toggle"
177177
type="checkbox"
178-
checked={{this.filterData.showInherited}}
179-
onchange={{fn this.updateFilter "showInherited"}}
178+
checked={{filterData.showInherited}}
179+
onchange={{fn updateFilter "showInherited"}}
180180
/>
181181
Inherited
182182
</label>
183183
<label class="access-checkbox">
184184
<input
185185
id="protected-toggle"
186186
type="checkbox"
187-
checked={{this.filterData.showProtected}}
188-
onchange={{fn this.updateFilter "showProtected"}}
187+
checked={{filterData.showProtected}}
188+
onchange={{fn updateFilter "showProtected"}}
189189
/>
190190
Protected
191191
</label>
192192
<label class="access-checkbox">
193193
<input
194194
id="private-toggle"
195195
type="checkbox"
196-
checked={{this.filterData.showPrivate}}
197-
onchange={{fn this.updateFilter "showPrivate"}}
196+
checked={{filterData.showPrivate}}
197+
onchange={{fn updateFilter "showPrivate"}}
198198
/>
199199
Private
200200
</label>
201201
<label class="access-checkbox">
202202
<input
203203
id="deprecated-toggle"
204204
type="checkbox"
205-
checked={{this.filterData.showDeprecated}}
206-
onchange={{fn this.updateFilter "showDeprecated"}}
205+
checked={{filterData.showDeprecated}}
206+
onchange={{fn updateFilter "showDeprecated"}}
207207
/>
208208
</label>
209209
</section>
@@ -235,17 +235,17 @@ module('Integration | Component | api index filter', function (hooks) {
235235
@tracked showDeprecated = false;
236236
}
237237

238-
this.model = createModel();
239-
this.filterData = new FilterData();
240-
this.updateFilter = (field) => {
241-
this.filterData[field] = !this.filterData[field];
238+
const model = createModel();
239+
const filterData = new FilterData();
240+
const updateFilter = (field) => {
241+
filterData[field] = !filterData[field];
242242
};
243243

244244
await render(
245245
<template>
246246
<ApiIndexFilter
247-
@model={{this.model}}
248-
@filterData={{this.filterData}}
247+
@model={{model}}
248+
@filterData={{filterData}}
249249
as |myModel|
250250
>
251251
<section>
@@ -254,35 +254,35 @@ module('Integration | Component | api index filter', function (hooks) {
254254
<input
255255
id="inherited-toggle"
256256
type="checkbox"
257-
checked={{this.filterData.showInherited}}
258-
onchange={{fn this.updateFilter "showInherited"}}
257+
checked={{filterData.showInherited}}
258+
onchange={{fn updateFilter "showInherited"}}
259259
/>
260260
Inherited
261261
</label>
262262
<label class="access-checkbox">
263263
<input
264264
id="protected-toggle"
265265
type="checkbox"
266-
checked={{this.filterData.showProtected}}
267-
onchange={{fn this.updateFilter "showProtected"}}
266+
checked={{filterData.showProtected}}
267+
onchange={{fn updateFilter "showProtected"}}
268268
/>
269269
Protected
270270
</label>
271271
<label class="access-checkbox">
272272
<input
273273
id="private-toggle"
274274
type="checkbox"
275-
checked={{this.filterData.showPrivate}}
276-
onchange={{fn this.updateFilter "showPrivate"}}
275+
checked={{filterData.showPrivate}}
276+
onchange={{fn updateFilter "showPrivate"}}
277277
/>
278278
Private
279279
</label>
280280
<label class="access-checkbox">
281281
<input
282282
id="deprecated-toggle"
283283
type="checkbox"
284-
checked={{this.filterData.showDeprecated}}
285-
onchange={{fn this.updateFilter "showDeprecated"}}
284+
checked={{filterData.showDeprecated}}
285+
onchange={{fn updateFilter "showDeprecated"}}
286286
/>
287287
</label>
288288
</section>
@@ -318,17 +318,17 @@ module('Integration | Component | api index filter', function (hooks) {
318318
@tracked showDeprecated = false;
319319
}
320320

321-
this.model = createModel();
322-
this.filterData = new FilterData();
323-
this.updateFilter = (field) => {
324-
this.filterData[field] = !this.filterData[field];
321+
const model = createModel();
322+
const filterData = new FilterData();
323+
const updateFilter = (field) => {
324+
filterData[field] = !filterData[field];
325325
};
326326

327327
await render(
328328
<template>
329329
<ApiIndexFilter
330-
@model={{this.model}}
331-
@filterData={{this.filterData}}
330+
@model={{model}}
331+
@filterData={{filterData}}
332332
as |myModel|
333333
>
334334
<section>
@@ -337,35 +337,35 @@ module('Integration | Component | api index filter', function (hooks) {
337337
<input
338338
id="inherited-toggle"
339339
type="checkbox"
340-
checked={{this.filterData.showInherited}}
341-
onchange={{fn this.updateFilter "showInherited"}}
340+
checked={{filterData.showInherited}}
341+
onchange={{fn updateFilter "showInherited"}}
342342
/>
343343
Inherited
344344
</label>
345345
<label class="access-checkbox">
346346
<input
347347
id="protected-toggle"
348348
type="checkbox"
349-
checked={{this.filterData.showProtected}}
350-
onchange={{fn this.updateFilter "showProtected"}}
349+
checked={{filterData.showProtected}}
350+
onchange={{fn updateFilter "showProtected"}}
351351
/>
352352
Protected
353353
</label>
354354
<label class="access-checkbox">
355355
<input
356356
id="private-toggle"
357357
type="checkbox"
358-
checked={{this.filterData.showPrivate}}
359-
onchange={{fn this.updateFilter "showPrivate"}}
358+
checked={{filterData.showPrivate}}
359+
onchange={{fn updateFilter "showPrivate"}}
360360
/>
361361
Private
362362
</label>
363363
<label class="access-checkbox">
364364
<input
365365
id="deprecated-toggle"
366366
type="checkbox"
367-
checked={{this.filterData.showDeprecated}}
368-
onchange={{fn this.updateFilter "showDeprecated"}}
367+
checked={{filterData.showDeprecated}}
368+
onchange={{fn updateFilter "showDeprecated"}}
369369
/>
370370
</label>
371371
</section>
@@ -409,17 +409,17 @@ module('Integration | Component | api index filter', function (hooks) {
409409
@tracked showDeprecated = true;
410410
}
411411

412-
this.model = createModel();
413-
this.filterData = new FilterData();
414-
this.updateFilter = (field) => {
415-
this.filterData[field] = !this.filterData[field];
412+
const model = createModel();
413+
const filterData = new FilterData();
414+
const updateFilter = (field) => {
415+
filterData[field] = !filterData[field];
416416
};
417417

418418
await render(
419419
<template>
420420
<ApiIndexFilter
421-
@model={{this.model}}
422-
@filterData={{this.filterData}}
421+
@model={{model}}
422+
@filterData={{filterData}}
423423
as |myModel|
424424
>
425425
<section>
@@ -428,35 +428,35 @@ module('Integration | Component | api index filter', function (hooks) {
428428
<input
429429
id="inherited-toggle"
430430
type="checkbox"
431-
checked={{this.filterData.showInherited}}
432-
onchange={{fn this.updateFilter "showInherited"}}
431+
checked={{filterData.showInherited}}
432+
onchange={{fn updateFilter "showInherited"}}
433433
/>
434434
Inherited
435435
</label>
436436
<label class="access-checkbox">
437437
<input
438438
id="protected-toggle"
439439
type="checkbox"
440-
checked={{this.filterData.showProtected}}
441-
onchange={{fn this.updateFilter "showProtected"}}
440+
checked={{filterData.showProtected}}
441+
onchange={{fn updateFilter "showProtected"}}
442442
/>
443443
Protected
444444
</label>
445445
<label class="access-checkbox">
446446
<input
447447
id="private-toggle"
448448
type="checkbox"
449-
checked={{this.filterData.showPrivate}}
450-
onchange={{fn this.updateFilter "showPrivate"}}
449+
checked={{filterData.showPrivate}}
450+
onchange={{fn updateFilter "showPrivate"}}
451451
/>
452452
Private
453453
</label>
454454
<label class="access-checkbox">
455455
<input
456456
id="deprecated-toggle"
457457
type="checkbox"
458-
checked={{this.filterData.showDeprecated}}
459-
onchange={{fn this.updateFilter "showDeprecated"}}
458+
checked={{filterData.showDeprecated}}
459+
onchange={{fn updateFilter "showDeprecated"}}
460460
/>
461461
</label>
462462
</section>
@@ -508,14 +508,14 @@ module('Integration | Component | api index filter', function (hooks) {
508508
@tracked showDeprecated = false;
509509
}
510510

511-
this.model = createModel();
512-
this.filterData = new FilterData();
511+
const model = createModel();
512+
const filterData = new FilterData();
513513

514514
await render(
515515
<template>
516516
<ApiIndexFilter
517-
@model={{this.model}}
518-
@filterData={{this.filterData}}
517+
@model={{model}}
518+
@filterData={{filterData}}
519519
as |myModel|
520520
>
521521
<h2>Methods</h2>

0 commit comments

Comments
 (0)