Refine fallback render detection for memoized fibers

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Author: cursoragent

exercises/06.rerenders/01.problem.memo/tests/memoized.test.ts

@@ -13,7 +13,7 @@ test('Only ListItem should not rerender when clicking force rerender', async ({
 			<script>
 				let internals
 				const PerformedWorkFlag = 0b000000000000000000000000001
-				const UserCodeFiberTags = new Set([0, 1, 9, 11, 14, 15])
+				const UserCodeFiberTags = new Set([0, 1, 9, 11, 15])
 
 				let activeFallbackComponentNames = null
 
@@ -50,7 +50,7 @@ test('Only ListItem should not rerender when clicking force rerender', async ({
 				}
 
 				function didFiberRender(previousFiber, nextFiber) {
-					if (!previousFiber) return true
+					if (!previousFiber) return false
 					return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 				}
 

exercises/06.rerenders/01.solution.memo/tests/memoized.test.ts

@@ -13,7 +13,7 @@ test('Only ListItem should not rerender when clicking force rerender', async ({
 			<script>
 				let internals
 				const PerformedWorkFlag = 0b000000000000000000000000001
-				const UserCodeFiberTags = new Set([0, 1, 9, 11, 14, 15])
+				const UserCodeFiberTags = new Set([0, 1, 9, 11, 15])
 
 				let activeFallbackComponentNames = null
 
@@ -50,7 +50,7 @@ test('Only ListItem should not rerender when clicking force rerender', async ({
 				}
 
 				function didFiberRender(previousFiber, nextFiber) {
-					if (!previousFiber) return true
+					if (!previousFiber) return false
 					return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 				}
 

exercises/06.rerenders/02.problem.comparator/tests/memoized.test.ts

@@ -13,7 +13,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 			<script>
 				let internals
 				const PerformedWorkFlag = 0b000000000000000000000000001
-				const UserCodeFiberTags = new Set([0, 1, 9, 11, 14, 15])
+				const UserCodeFiberTags = new Set([0, 1, 9, 11, 15])
 
 				let activeFallbackComponentNames = null
 
@@ -50,7 +50,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 				}
 
 				function didFiberRender(previousFiber, nextFiber) {
-					if (!previousFiber) return true
+					if (!previousFiber) return false
 					return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 				}
 

exercises/06.rerenders/02.solution.comparator/tests/memoized.test.ts

@@ -13,7 +13,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 			<script>
 				let internals
 				const PerformedWorkFlag = 0b000000000000000000000000001
-				const UserCodeFiberTags = new Set([0, 1, 9, 11, 14, 15])
+				const UserCodeFiberTags = new Set([0, 1, 9, 11, 15])
 
 				let activeFallbackComponentNames = null
 
@@ -50,7 +50,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 				}
 
 				function didFiberRender(previousFiber, nextFiber) {
-					if (!previousFiber) return true
+					if (!previousFiber) return false
 					return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 				}
 

exercises/06.rerenders/03.problem.primitives/tests/memoized.test.ts

@@ -13,7 +13,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 			<script>
 				let internals
 				const PerformedWorkFlag = 0b000000000000000000000000001
-				const UserCodeFiberTags = new Set([0, 1, 9, 11, 14, 15])
+				const UserCodeFiberTags = new Set([0, 1, 9, 11, 15])
 
 				let activeFallbackComponentNames = null
 
@@ -50,7 +50,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 				}
 
 				function didFiberRender(previousFiber, nextFiber) {
-					if (!previousFiber) return true
+					if (!previousFiber) return false
 					return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 				}
 

exercises/06.rerenders/03.solution.primitives/tests/memoized.test.ts

@@ -13,7 +13,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 			<script>
 				let internals
 				const PerformedWorkFlag = 0b000000000000000000000000001
-				const UserCodeFiberTags = new Set([0, 1, 9, 11, 14, 15])
+				const UserCodeFiberTags = new Set([0, 1, 9, 11, 15])
 
 				let activeFallbackComponentNames = null
 
@@ -50,7 +50,7 @@ test('Only two ListItems should not rerender when the highlighted item changes',
 				}
 
 				function didFiberRender(previousFiber, nextFiber) {
-					if (!previousFiber) return true
+					if (!previousFiber) return false
 					return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 				}
 

shared/get-component-calls.tsx

@@ -11,7 +11,6 @@ const FunctionComponentTag = 0
 const ClassComponentTag = 1
 const ContextConsumerTag = 9
 const ForwardRefTag = 11
-const MemoComponentTag = 14
 const SimpleMemoComponentTag = 15
 
 let activeFallbackComponentNames: Array<string> | null = null
@@ -22,7 +21,6 @@ function isUserCodeFiberTag(tag: number) {
 		tag === ClassComponentTag ||
 		tag === ContextConsumerTag ||
 		tag === ForwardRefTag ||
-		tag === MemoComponentTag ||
 		tag === SimpleMemoComponentTag
 	)
 }
@@ -56,7 +54,7 @@ function getFiberDisplayName(fiber: any) {
 }
 
 function didFiberRender(previousFiber: any, nextFiber: any) {
-	if (!previousFiber) return true
+	if (!previousFiber) return false
 	return (nextFiber.flags & PerformedWorkFlag) === PerformedWorkFlag
 }