-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathindex.test.ts
More file actions
592 lines (516 loc) · 16.8 KB
/
index.test.ts
File metadata and controls
592 lines (516 loc) · 16.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
import { afterEach, beforeEach, describe, expect, it, test } from "bun:test";
import MagicString, { type SourceMapOptions } from "magic-string";
import { type ParseLiteralsOptions, type Template, type TemplatePart, parseLiterals } from "parse-literals";
import {
type SourceMap,
defaultGenerateSourceMap,
defaultShouldMinify,
defaultShouldMinifyCSS,
defaultValidation,
minifyHTMLLiterals,
} from "./";
import { defaultMinifyOptions, defaultStrategy } from "./strategy";
/**
* get code snippet from function body
*/
const fn_body = (fn: Function, tabSize = 2) => {
const fn_str = fn.toString();
const body_str = fn_str
.slice(fn_str.indexOf("{") + 1, fn_str.lastIndexOf("}"))
// remove trailing whitespace
.trimEnd()
// remove empty lines
.replace(/^([\s\t]*$\r?\n)+/gm, "")
// use spaces uniformly: current indentStyle is "tab",and tab-width == 2(spaces)
.replace(/^\t+/gm, (tabs) => " ".repeat(tabs.length * tabSize));
/// remove indent
const indent = body_str.match(/\s+/)?.[0];
if (!indent) {
return body_str.trim();
}
const indent_reg = new RegExp(`^\\s{${indent.length}}`, "gm");
return body_str.replace(indent_reg, "");
};
// https://github.com/explodingcamera/esm/issues/1
describe("handle key value pairs correctly", () => {
it("should minify css", async () => {
const source = fn_body((css = String.raw) => {
const cssText = css`:host{
${"color"}: ${"red"};
}`;
});
expect((await minifyHTMLLiterals(source))?.code).toMatch(
fn_body((css = String.raw) => {
const cssText = css`:host{${"color"}:${"red"}}`;
}),
);
});
it("should minify css with unit", async () => {
const source = fn_body((css = String.raw) => {
const cssText = css`:host{
${"width"}: ${10}px;
}`;
});
expect((await minifyHTMLLiterals(source))?.code).toMatch(
fn_body((css = String.raw) => {
const cssText = css`:host{${"width"}:${10}px}`;
}),
);
});
it("should minify css within css-function", async () => {
const source = fn_body((css = String.raw) => {
const cssText = css`:host{
${"width"}: calc(${10}px + ${"var(--data)"});
}`;
});
expect((await minifyHTMLLiterals(source))?.code).toMatch(
fn_body((css = String.raw) => {
const cssText = css`:host{${"width"}:calc(${10}px + ${"var(--data)"})}`;
}),
);
});
});
// Comments https://github.com/asyncLiz/minify-html-literals/issues/49
describe("handle comments correctly", () => {
it("should remove comments", async () => {
const source = `const el = html\`<div><!-- comment --></div>\``;
const expected = `const el = html\`<div></div>\``;
expect((await minifyHTMLLiterals(source))?.code).toBe(expected);
});
it("templates inside of html comments are not minified", async () => {
const source = `const el = html\`<div><!-- \${console.log(1)} --></div>\``;
expect(await minifyHTMLLiterals(source)).toBe(null);
});
it("comments inside of literals are not removed", async () => {
const source = `const el = html\`<div>\${/*console.log(1)*/}</div>\``;
expect(await minifyHTMLLiterals(source)).toBe(null);
});
});
// https://github.com/asyncLiz/minify-html-literals/issues/46
// currently, we skip the entire file if we find a template literal that uses unsafeCSS / unsafeHTML.
// instead, we should ideally just skip the template literal (but we need to update parse-literals for that)
describe("don't minify code with unsafeCSS / unsafeHTML", () => {
it("should not remove styles from dynamically inserted selectors", async () => {
const source = `
css\`
foo {
bar: baz;
}
\${unsafeCSS('#foo-id')} {
bar: baz;
}
\`
`.trim();
expect(await minifyHTMLLiterals(source)).toBe(null);
});
});
// https://github.com/asyncLiz/minify-html-literals/issues/37
describe("minify templates with static tag literals", () => {
it("should minify html", async () => {
const STATIC_LITERAL_IN_TAG_NAME = `
html\`<\${Component.litTagName} id="container">
<span>Some content here</span>
</\${Component.litTagName}>
\`
`.trim();
const expected = `html\`<\${Component.litTagName} id="container"><span>Some content here</span></\${Component.litTagName}>\``;
expect((await minifyHTMLLiterals(STATIC_LITERAL_IN_TAG_NAME))?.code).toBe(expected);
});
});
test("example", async () => {
const source = `
const el = html\`<div > <h1> Hello World </h1 > </div>\`;
const css = css\` .foo { color: red; } \`;
`;
expect(await minifyHTMLLiterals(source)).toMatchSnapshot();
});
class MagicStringLike {
generateMap(options?: Partial<SourceMapOptions>): SourceMap {
return {
version: 3,
file: options?.file || null,
sources: [options?.source || null],
sourcesContent: [],
names: [],
mappings: "",
toString() {
return "";
},
toUrl() {
return "";
},
};
}
overwrite(_start: number, _end: number, _content: string): any {
// noop
}
toString(): string {
return "";
}
}
describe("minifyHTMLLiterals()", () => {
const SOURCE = `
function render(title, items, styles) {
return html\`
<style>
\${styles}
</style>
<h1 class="heading">\${title}</h1>
<button onclick="\${() => eventHandler()}"></button>
<ul>
\${items.map(item => {
return getHTML()\`
<li>\${item}</li>
\`;
})}
</ul>
\`;
}
function noMinify() {
return \`
<div>Not tagged html</div>
\`;
}
function taggednoMinify(extra) {
return other\`
<style>
.heading {
font-size: 24px;
}
\${extra}
</style>
\`;
}
function taggedCSSMinify(extra) {
return css\`
.heading {
font-size: 24px;
}
\${extra}
\`;
}
function cssProperty(property) {
const width = '20px';
return css\`
.foo {
font-size: 1rem;
width: \${width};
color: \${property};
}
\`;
}
`;
const SOURCE_MIN = `
function render(title, items, styles) {
return html\`<style>\${styles}</style><h1 class="heading">\${title}</h1><button onclick="\${() => eventHandler()}"></button><ul>\${items.map(item => {
return getHTML()\`<li>\${item}</li>\`;
})}</ul>\`;
}
function noMinify() {
return \`
<div>Not tagged html</div>
\`;
}
function taggednoMinify(extra) {
return other\`
<style>
.heading {
font-size: 24px;
}
\${extra}
</style>
\`;
}
function taggedCSSMinify(extra) {
return css\`.heading{font-size:24px}\${extra}\`;
}
function cssProperty(property) {
const width = '20px';
return css\`.foo{font-size:1rem;width:\${width};color:\${property}}\`;
}
`;
const SVG_SOURCE = `
function taggedSVGMinify() {
return svg\`
<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24">
<path d="M6 19h12v2H6z" />
<path d="M0 0h24v24H0V0z" fill="none" />
</svg>
\`;
}
`;
const SVG_SOURCE_MIN = `
function taggedSVGMinify() {
return svg\`<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M6 19h12v2H6z"/><path d="M0 0h24v24H0V0z" fill="none"/></svg>\`;
}
`;
const COMMENT_SOURCE = `
function minifyWithComment() {
return html\`
<div .icon=\${0/*JS Comment */}>
</div>
\`;
}
`;
const COMMENT_SOURCE_MIN = `
function minifyWithComment() {
return html\`<div .icon="\${0/*JS Comment */}"></div>\`;
}
`;
const SVG_MULTILINE_SOURCE = `
function multiline() {
return html\`
<pre>
Keep newlines
within certain tags
</pre>
<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24">
<path d="M6 19h12v2H6z" />
<path d="M0
0h24v24H0V0z"
fill="none" />
</svg>
\`;
}
`;
const SVG_MULTILINE_SOURCE_MIN = `
function multiline() {
return html\`<pre>
Keep newlines
within certain tags
</pre><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M6 19h12v2H6z"/><path d="M0 0h24v24H0V0z" fill="none"/></svg>\`;
}
`;
const SHADOW_PARTS_SOURCE = `
function parts() {
return css\`
foo-bar::part(.space .separated) {
color: red;
}
\`;
}
`;
const SHADOW_PARTS_SOURCE_MIN = `
function parts() {
return css\`foo-bar::part(.space .separated){color:red}\`;
}
`;
const MEMBER_EXPRESSION_LITERAL_SOURCE = `
function nested() {
return LitHtml.html\`<div id="container">
<span>Some content here</span>
</div>
\`;
}
`;
const MEMBER_EXPRESSION_LITERAL_SOURCE_MIN = `
function nested() {
return LitHtml.html\`<div id="container"><span>Some content here</span></div>\`;
}
`;
it('should minify "html" and "css" tagged templates', async () => {
const result = await minifyHTMLLiterals(SOURCE, { fileName: "test.js" });
expect(result).toBeTypeOf("object");
expect(result!.code).toEqual(SOURCE_MIN);
});
it('should minify "svg" tagged templates', async () => {
const result = await minifyHTMLLiterals(SVG_SOURCE, { fileName: "test.js" });
expect(result).toBeTypeOf("object");
expect(result!.code).toEqual(SVG_SOURCE_MIN);
});
it("should minify html with attribute placeholders that have no quotes and JS comments", async () => {
const result = await minifyHTMLLiterals(COMMENT_SOURCE, { fileName: "test.js" });
expect(result).toBeTypeOf("object");
expect(result!.code).toEqual(COMMENT_SOURCE_MIN);
});
it("should minify html tagged with a member expression ending in html", async () => {
const result = await minifyHTMLLiterals(MEMBER_EXPRESSION_LITERAL_SOURCE, {
fileName: "test.js",
});
expect(result).toBeTypeOf("object");
expect(result!.code).toEqual(MEMBER_EXPRESSION_LITERAL_SOURCE_MIN);
});
it("should minify multiline svg elements", async () => {
const result = await minifyHTMLLiterals(SVG_MULTILINE_SOURCE, {
fileName: "test.js",
});
expect(result).toBeTypeOf("object");
expect(result!.code).toEqual(SVG_MULTILINE_SOURCE_MIN);
});
it("should not remove spaces in ::part()", async () => {
const result = await minifyHTMLLiterals(SHADOW_PARTS_SOURCE, {
fileName: "test.js",
});
expect(result).toBeTypeOf("object");
expect(result!.code).toEqual(SHADOW_PARTS_SOURCE_MIN);
});
it("should return null if source is already minified", async () => {
const result = await minifyHTMLLiterals(SOURCE_MIN, { fileName: "test.js" });
expect(result).toBeNull();
});
it("should return a v3 source map", async () => {
const result = await minifyHTMLLiterals(SOURCE, { fileName: "test.js" });
expect(result).toBeTypeOf("object");
expect(result!.map).toBeTypeOf("object");
expect(result!.map!.version).toEqual(3);
expect(result!.map!.mappings).toBeTypeOf("string");
});
describe("options", () => {
it("should use defaultMinifyOptions", () => {
minifyHTMLLiterals(SOURCE, { fileName: "test.js" });
const parts = parseLiterals(SOURCE)[1]!.parts;
defaultStrategy.combineHTMLStrings(parts, defaultStrategy.getPlaceholder(parts));
});
it("should allow custom partial minifyOptions", async () => {
const minifyOptions = { caseSensitive: false };
await minifyHTMLLiterals(SOURCE, { fileName: "test.js", minifyOptions });
const parts = parseLiterals(SOURCE)[1]!.parts;
defaultStrategy.combineHTMLStrings(parts, defaultStrategy.getPlaceholder(parts));
});
it("should use MagicString constructor", async () => {
let msUsed: MagicStringLike | undefined;
await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
generateSourceMap(ms) {
msUsed = ms;
return undefined;
},
});
expect(msUsed).toBeInstanceOf(MagicString);
});
it("should allow custom MagicStringLike constructor", async () => {
let msUsed: MagicStringLike | undefined;
await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
MagicString: MagicStringLike,
generateSourceMap(ms) {
msUsed = ms;
return undefined;
},
});
expect(msUsed).toBeInstanceOf(MagicStringLike);
});
it("should allow custom parseLiterals()", async () => {
const customParseLiterals = (source: string, options?: ParseLiteralsOptions) => {
return parseLiterals(source, options);
};
await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
parseLiterals: customParseLiterals,
});
});
it("should allow custom shouldMinify()", async () => {
const customShouldMinify = (template: Template) => {
return defaultShouldMinify(template);
};
await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
shouldMinify: customShouldMinify,
});
});
it("should use defaultValidation", () => {
minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
strategy: {
getPlaceholder: () => {
return ""; // cause an error
},
combineHTMLStrings: defaultStrategy.combineHTMLStrings,
minifyHTML: defaultStrategy.minifyHTML,
splitHTMLByPlaceholder: defaultStrategy.splitHTMLByPlaceholder,
},
});
expect(async () => {
await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
strategy: {
getPlaceholder: defaultStrategy.getPlaceholder,
combineHTMLStrings: defaultStrategy.combineHTMLStrings,
minifyHTML: defaultStrategy.minifyHTML,
splitHTMLByPlaceholder: () => {
return []; // cause an error
},
},
});
}).toThrow();
});
it("should allow disabling validation", async () => {
await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
strategy: {
getPlaceholder: () => {
return ""; // cause an error
},
combineHTMLStrings: defaultStrategy.combineHTMLStrings,
minifyHTML: defaultStrategy.minifyHTML,
splitHTMLByPlaceholder: defaultStrategy.splitHTMLByPlaceholder,
},
validate: false,
});
});
it("should allow disabling generateSourceMap", async () => {
const result = await minifyHTMLLiterals(SOURCE, {
fileName: "test.js",
generateSourceMap: false,
});
expect(result).toBeTypeOf("object");
expect(result!.map).toBeUndefined();
});
});
describe("defaultShouldMinify()", () => {
it('should return true if the template is tagged with any "html" text', () => {
expect(defaultShouldMinify({ tag: "html", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "HTML", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "hTML", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "getHTML()", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "templateHtml()", parts: [] })).toBe(true);
});
it('should return false if the template is not tagged or does not contain "html"', () => {
expect(defaultShouldMinify({ parts: [] })).toBe(false);
expect(defaultShouldMinify({ tag: "css", parts: [] })).toBe(false);
});
it('should return true if the template is tagged with any "svg" text', () => {
expect(defaultShouldMinify({ tag: "svg", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "SVG", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "sVg", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "getSVG()", parts: [] })).toBe(true);
expect(defaultShouldMinify({ tag: "templateSvg()", parts: [] })).toBe(true);
});
});
describe("defaultShouldMinifyCSS()", () => {
it('should return true if the template is tagged with any "css" text', () => {
expect(defaultShouldMinifyCSS({ tag: "css", parts: [] })).toBe(true);
expect(defaultShouldMinifyCSS({ tag: "CSS", parts: [] })).toBe(true);
expect(defaultShouldMinifyCSS({ tag: "csS", parts: [] })).toBe(true);
expect(defaultShouldMinifyCSS({ tag: "getCSS()", parts: [] })).toBe(true);
expect(defaultShouldMinifyCSS({ tag: "templateCss()", parts: [] })).toBe(true);
});
it('should return false if the template is not tagged or does not contain "css"', () => {
expect(defaultShouldMinifyCSS({ parts: [] })).toBe(false);
expect(defaultShouldMinifyCSS({ tag: "html", parts: [] })).toBe(false);
});
});
describe("defaultValidation", () => {
describe("ensurePlaceholderValid()", () => {
it("should throw an error if the placeholder is not a string", () => {
expect(() => {
defaultValidation.ensurePlaceholderValid(undefined);
}).toThrow();
expect(() => {
defaultValidation.ensurePlaceholderValid(true);
}).toThrow();
expect(() => {
defaultValidation.ensurePlaceholderValid({});
}).toThrow();
});
it("should throw an error if the placeholder is an empty string", () => {
expect(() => {
defaultValidation.ensurePlaceholderValid("");
}).toThrow();
});
it("should not throw an error if the placeholder is a non-empty string", () => {
defaultValidation.ensurePlaceholderValid("EXP");
});
});
});
});