Skip to content

Commit 2e1c962

Browse files
committed
Add error handling in preparing dev_workspace envs. Remove useless code in project info provider
1 parent b5de3a8 commit 2e1c962

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

finecode_extension_runner/src/finecode_extension_runner/impls/project_info_provider.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,5 @@
66

77

88
class ProjectInfoProvider(iprojectinfoprovider.IProjectInfoProvider):
9-
def __init__(
10-
self,
11-
) -> None: ...
12-
139
async def get_project_raw_config(self) -> dict[str, Any]:
1410
return await project_raw_config_getter()

src/finecode/cli_app/prepare_envs.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,8 @@ async def check_or_recreate_all_dev_workspace_envs(
248248

249249
envs += invalid_envs
250250

251-
# TODO: check result
252251
try:
253-
await services.run_action(
252+
action_result = await services.run_action(
254253
action_name="prepare_dev_workspaces_envs",
255254
params={
256255
"envs": envs,
@@ -264,3 +263,8 @@ async def check_or_recreate_all_dev_workspace_envs(
264263
raise PrepareEnvsFailed(
265264
f"'prepare_dev_workspaces_env' failed in {current_project.name}: {exception.message}"
266265
)
266+
267+
if action_result.return_code != 0:
268+
raise PrepareEnvsFailed(
269+
f"'prepare_dev_workspaces_env' ended in {current_project.name} with return code {action_result.return_code}: {action_result.result}"
270+
)

0 commit comments

Comments
 (0)